Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fill tracking issue number for array_value_iter #65799

Merged
merged 1 commit into from
Oct 25, 2019
Merged

Fill tracking issue number for array_value_iter #65799

merged 1 commit into from
Oct 25, 2019

Conversation

LukasKalbertodt
Copy link
Member

Thanks for noticing!

r? @Centril

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 25, 2019
@Centril
Copy link
Contributor

Centril commented Oct 25, 2019

The #[stable(feature = "array_value_iter_impls", since = "1.38.0")]s also seem to have the wrong version number; also, what was the reason for keeping these "stable" and in a different gate again?

@LukasKalbertodt
Copy link
Member Author

LukasKalbertodt commented Oct 25, 2019 •
edited
Loading

also, what was the reason for keeping these "stable" and in a different gate again?

The impls are insta-stable, so you asked me to mark them as such: #62959 (comment)

The #[stable(feature = "array_value_iter_impls", since = "1.38.0")]s also seem to have the wrong version number

Thanks for noticing once again. Will change momentarily. 1.40.0 is correct, right?

@LukasKalbertodt LukasKalbertodt force-pushed the fill-array-value-iter-tracking-issue branch from a2ff8ca to dcf3436 Compare October 25, 2019 09:38
@Centril
Copy link
Contributor

Centril commented Oct 25, 2019

Thanks! r=me rollup when green :)

@lqd
Copy link
Member

lqd commented Oct 25, 2019

@bors r=Centril rollup

@bors
Copy link
Contributor

bors commented Oct 25, 2019

📌 Commit dcf3436 has been approved by Centril

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 25, 2019
Centril added a commit to Centril/rust that referenced this pull request Oct 25, 2019
@Centril
Rollup merge of rust-lang#65799 - LukasKalbertodt:fill-array-value-it…
5e05ab8 
…er-tracking-issue, r=Centril

Fill tracking issue number for `array_value_iter`

Thanks for [noticing](rust-lang#62959 (comment))!

r? @Centril
@Centril Centril mentioned this pull request Oct 25, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Oct 25, 2019
@Centril
Rollup merge of rust-lang#65799 - LukasKalbertodt:fill-array-value-it…
affcac6 
…er-tracking-issue, r=Centril

Fill tracking issue number for `array_value_iter`

Thanks for [noticing](rust-lang#62959 (comment))!

r? @Centril
@Centril Centril mentioned this pull request Oct 25, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Oct 25, 2019
@Centril
Rollup merge of rust-lang#65799 - LukasKalbertodt:fill-array-value-it…
fd20f12 
…er-tracking-issue, r=Centril

Fill tracking issue number for `array_value_iter`

Thanks for [noticing](rust-lang#62959 (comment))!

r? @Centril
@Centril Centril mentioned this pull request Oct 25, 2019
Closed
bors added a commit that referenced this pull request Oct 25, 2019
@bors
Auto merge of #65820 - Centril:rollup-8csuohg, r=Centril
f62dad7 
Rollup of 7 pull requests

Successful merges:

 - #63810 (Make <*const/mut T>::offset_from `const fn`)
 - #65705 (Add {String,Vec}::into_raw_parts)
 - #65749 (Insurance policy in case `iter.size_hint()` lies.)
 - #65799 (Fill tracking issue number for `array_value_iter`)
 - #65800 (self-profiling: Update measureme to 0.4.0 and remove non-RAII methods from profiler.)
 - #65806 (Add [T]::as_ptr_range() and [T]::as_mut_ptr_range().)
 - #65810 (SGX: Clear additional flag on enclave entry)

Failed merges:

r? @ghost
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Oct 25, 2019
@JohnTitor
Rollup merge of rust-lang#65799 - LukasKalbertodt:fill-array-value-it…
9192f36 
…er-tracking-issue, r=Centril

Fill tracking issue number for `array_value_iter`

Thanks for [noticing](rust-lang#62959 (comment))!

r? @Centril
@JohnTitor JohnTitor mentioned this pull request Oct 25, 2019
Merged
bors added a commit that referenced this pull request Oct 25, 2019
@bors
Auto merge of #65826 - JohnTitor:rollup-mr6crka, r=JohnTitor
246be7e 
Rollup of 6 pull requests

Successful merges:

 - #65705 (Add {String,Vec}::into_raw_parts)
 - #65749 (Insurance policy in case `iter.size_hint()` lies.)
 - #65799 (Fill tracking issue number for `array_value_iter`)
 - #65800 (self-profiling: Update measureme to 0.4.0 and remove non-RAII methods from profiler.)
 - #65806 (Add [T]::as_ptr_range() and [T]::as_mut_ptr_range().)
 - #65810 (SGX: Clear additional flag on enclave entry)

Failed merges:

r? @ghost
@bors bors merged commit dcf3436 into rust-lang:master Oct 25, 2019
@LukasKalbertodt LukasKalbertodt deleted the fill-array-value-iter-tracking-issue branch October 25, 2019 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Centril Centril

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@LukasKalbertodt @Centril @lqd @bors @rust-highfive