Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

invalid_value lint: use diagnostic items #66217

Merged
merged 1 commit into from
Nov 10, 2019

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented Nov 8, 2019

This adjusts the invalid_value lint to use diagnostic items.

@Centril @oli-obk For some reason, this fails to recognize transmute -- somehow the diagnostic item is not found. Any idea why?

r? @Centril

Cc #66075

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 8, 2019
@Centril
Copy link
Contributor

Centril commented Nov 8, 2019

Any idea why?

The only thing that pops out is that it's a directly exported intrinsic, but I'm not sure why that makes the difference tho. Nothing stands out from #60966 tho so it seems strange. (If you want, we could leave transmute for another day, if so, r=me with necessary changes)

@RalfJung
Copy link
Member Author

RalfJung commented Nov 9, 2019

Okay, I left transmute as-is here now. @oli-obk FYI, diagnostic-items seem to have a problem with intrinsics; would be good if you could have a look.

@bors r=Centril

@bors
Copy link
Contributor

bors commented Nov 9, 2019

📋 Looks like this PR is still in progress, ignoring approval.

Hint: Remove WIP from this PR's title when it is ready for review.

@RalfJung RalfJung changed the title WIP: invalid_value lint: use diagnostic items invalid_value lint: use diagnostic items Nov 9, 2019
@RalfJung
Copy link
Member Author

RalfJung commented Nov 9, 2019

@bors r=Centril

@bors
Copy link
Contributor

bors commented Nov 9, 2019

📌 Commit 769d527 has been approved by Centril

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 9, 2019
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Nov 10, 2019
invalid_value lint: use diagnostic items

This adjusts the invalid_value lint to use diagnostic items.

@Centril @oli-obk For some reason, this fails to recognize `transmute` -- somehow the diagnostic item is not found. Any idea why?

r? @Centril

Cc rust-lang#66075
bors added a commit that referenced this pull request Nov 10, 2019
Rollup of 7 pull requests

Successful merges:

 - #65719 (Refactor sync::Once)
 - #65831 (Don't cast directly from &[T; N] to *const T)
 - #66048 (Correct error in documentation for Ipv4Addr method)
 - #66058 (Correct deprecated `is_global` IPv6 documentation)
 - #66216 ([mir-opt] Handle return place in ConstProp and improve SimplifyLocals pass)
 - #66217 (invalid_value lint: use diagnostic items)
 - #66235 (rustc_metadata: don't let LLVM confuse rmeta blobs for COFF object files.)

Failed merges:

r? @ghost
@bors bors merged commit 769d527 into rust-lang:master Nov 10, 2019
@RalfJung RalfJung deleted the diagnostic-items branch November 13, 2019 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants