-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use proc-macro to derive HashStable everywhere #66279
Merged
Merged
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
3e969e0
Revert "Revert expansion of impl HashStable for Frame."
cjgillot 1de5fdb
Add StableHashingContextLike to HashStable_Generic derive.
cjgillot 640797f
Invert flow in impl HashStable of Span.
cjgillot bf7c9ba
Derive HashStable_Generic for ExpnData.
cjgillot 3c5ddfd
Derive HashStable_Generic for Ident.
cjgillot 0073d3b
Export HashStable for DelimSpan, Lit and Path.
cjgillot 31298b4
Invert implementations for TokenKind.
cjgillot e85c195
Derives for ast.
cjgillot 8c86a79
Retire impl_stable_hash_for_spanned.
cjgillot edc5232
Retire impl_stable_hash_for.
cjgillot 9efd320
Fix rebase fallout.
cjgillot ce30107
Rename StableHashingContextLike to HashStableContext.
cjgillot ea0c354
Move CachingSourceMapView to libsyntax_pos.
cjgillot 7e411e7
Implement HashStable for Span in libsyntax_pos.
cjgillot 4d1674f
Use proc-macro for TokenTree.
cjgillot 782cc9f
Derive HashStable for TokenKind.
cjgillot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could use
HashStable_Generic
now?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It requires hashing the
NodeId
. I have a commit with this change, I can add it to this PR.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, ok. You can leave that for a later PR.