Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve non-exhaustiveness handling in usefulness checking #66330

Merged
merged 3 commits into from
Nov 13, 2019
Merged

Improve non-exhaustiveness handling in usefulness checking #66330

merged 3 commits into from
Nov 13, 2019

Commits on Nov 12, 2019

  1. Match constructor first in Constructor methods 

    This makes it easier to add new non-standard constructors, and this also
ensures that we don't forget cases when adding a new constructor.
    @Nadrieril
    Nadrieril committed Nov 12, 2019
    Configuration menu
    Copy the full SHA
    eb99c73 View commit details
    Browse the repository at this point in the history

  2. Introduce Constructor::NonExhaustive 

    It counts as an extra constructor for types that are not allowed to be
matched exhaustively.
    @Nadrieril
    Nadrieril committed Nov 12, 2019
    Configuration menu
    Copy the full SHA
    357d53c View commit details
    Browse the repository at this point in the history

  3. Move NonExhaustive checks to the relevant match branches

    @Nadrieril
    Nadrieril committed Nov 12, 2019
    Configuration menu
    Copy the full SHA
    e398d89 View commit details
    Browse the repository at this point in the history