-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stabilize std::error::<dyn Error>::chain() and std::error::Chain #66448
Conversation
remove Copy from Iterator as per comment rust-lang#58520 (comment) and change #[unstable] to #[stable]
(rust_highfive has picked a reviewer for you, use r? to override) |
r? @tmandry |
It seems a bit far-fetched to make a breaking change to an unstable API and then stabilize it as soon as that's merged, especially since it was merged by @sfackler on the grounds that its just a change to an unstable API. In terms of semantics, this is the API surface I want and I think the libs team has consensus on that. But I still am not a fan of the choice of name you've given to this API, and I think the libs team as a whole needs to reach a consensus here. I would r+ the copy change immediately, however. |
The other issue I see blocking stability (aside from the name) is the Can this method be implemented on both |
PR #66511 |
Please add your comment to the tracker #58520 so we can discuss this |
remove Copy from Iterator as per comment
#58520 (comment)
and change #[unstable] to #[stable]
Tracker: #58520