-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 13 pull requests #66542
Rollup of 13 pull requests #66542
Commits on Nov 12, 2019
-
ci: replace MINGW_URL with CUSTOM_MINGW=1
This commit replaces the mirrors base URL contained in the MINGW_URL with a CUSTOM_MINGW=1 environment variable. The mirrors base URL will be fetched instead through the MIRRORS_BASE environment variable, defined in src/ci/shared.sh.
Configuration menu - View commit details
-
Copy full SHA for 71e5018 - Browse repository at this point
Copy the full SHA 71e5018View commit details -
Configuration menu - View commit details
-
Copy full SHA for 53c2c04 - Browse repository at this point
Copy the full SHA 53c2c04View commit details -
Configuration menu - View commit details
-
Copy full SHA for af6b266 - Browse repository at this point
Copy the full SHA af6b266View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6104aa7 - Browse repository at this point
Copy the full SHA 6104aa7View commit details -
Configuration menu - View commit details
-
Copy full SHA for d623c56 - Browse repository at this point
Copy the full SHA d623c56View commit details -
Configuration menu - View commit details
-
Copy full SHA for e209ee4 - Browse repository at this point
Copy the full SHA e209ee4View commit details -
ci: move validate-toolstate.sh in the mingw-check image
The task was already run just there, so this cleans things up.
Configuration menu - View commit details
-
Copy full SHA for c90cc12 - Browse repository at this point
Copy the full SHA c90cc12View commit details -
Configuration menu - View commit details
-
Copy full SHA for 14da85c - Browse repository at this point
Copy the full SHA 14da85cView commit details -
ci: download curl and openssl from s3 for dist-x86_64-linux
CentOS 5 only supports SSLv3 without SNI, and to get newer protocols working we need to download and compile OpenSSL and cURL from our mirror. Because of that, we can't use the CDN, as CloudFront requires TLSv1 with SNI. This commit changes the dist-x86_64-linux image to bypass the CDN for OpenSSL and cURL.
Configuration menu - View commit details
-
Copy full SHA for 85132b2 - Browse repository at this point
Copy the full SHA 85132b2View commit details
Commits on Nov 15, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 71cf364 - Browse repository at this point
Copy the full SHA 71cf364View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1bbb816 - Browse repository at this point
Copy the full SHA 1bbb816View commit details
Commits on Nov 16, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 405866a - Browse repository at this point
Copy the full SHA 405866aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 44b6811 - Browse repository at this point
Copy the full SHA 44b6811View commit details -
Configuration menu - View commit details
-
Copy full SHA for 09180d7 - Browse repository at this point
Copy the full SHA 09180d7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8952c8a - Browse repository at this point
Copy the full SHA 8952c8aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5e115a2 - Browse repository at this point
Copy the full SHA 5e115a2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4e1eeb9 - Browse repository at this point
Copy the full SHA 4e1eeb9View commit details -
Configuration menu - View commit details
-
Copy full SHA for dc137dd - Browse repository at this point
Copy the full SHA dc137ddView commit details
Commits on Nov 17, 2019
-
Suggest calling async closure when needed
When using an async closure as a value in a place that expects a future, suggest calling the closure. Fix rust-lang#65923.
1Configuration menu - View commit details
-
Copy full SHA for 0487f0c - Browse repository at this point
Copy the full SHA 0487f0cView commit details -
Configuration menu - View commit details
-
Copy full SHA for d7efa5b - Browse repository at this point
Copy the full SHA d7efa5bView commit details -
Configuration menu - View commit details
-
Copy full SHA for ce7a579 - Browse repository at this point
Copy the full SHA ce7a579View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7f49f7b - Browse repository at this point
Copy the full SHA 7f49f7bView commit details -
Add JohnTitor to rustc-guide toolstate notification list
Also update org names of some books
Configuration menu - View commit details
-
Copy full SHA for d8ea786 - Browse repository at this point
Copy the full SHA d8ea786View commit details
Commits on Nov 18, 2019
-
std::error::Chain: remove Copy
remove Copy from Iterator as per comment rust-lang#58520 (comment)
Configuration menu - View commit details
-
Copy full SHA for de122e6 - Browse repository at this point
Copy the full SHA de122e6View commit details -
Disable gdb pretty printer global section on wasm targets
The wasm targets don't support gdb anyway so there's no need for this section there.
Configuration menu - View commit details
-
Copy full SHA for eda67ba - Browse repository at this point
Copy the full SHA eda67baView commit details -
Fix 'type annotations needed' error with opaque types
Related: rust-lang#66426 This commit adds handling for opaque types during inference variable fallback. Type variables generated from the instantiatino of opaque types now fallback to the opque type itself. Normally, the type variable for an instantiated opaque type is either unified with the concrete type, or with the opaque type itself (e.g when a function returns an opaque type by calling another function). However, it's possible for the type variable to be left completely unconstrained. This can occur in code like this: ```rust pub type Foo = impl Copy; fn produce() -> Option<Foo> { None } ``` Here, we'll instantatiate the `Foo` in `Option<Foo>` to a fresh type variable, but we will never unify it with anything due to the fact that we return a `None`. This results in the error message: `type annotations needed: cannot resolve `_: std::marker::Copy`` pointing at `pub type Foo = impl Copy`. This message is not only confusing, it's incorrect. When an opaque type inference variable is completely unconstrained, we can always fall back to using the opaque type itself. This effectively turns that particular use of the opaque type into a non-defining use, even if it appears in a defining scope.
Configuration menu - View commit details
-
Copy full SHA for 0e2ccaa - Browse repository at this point
Copy the full SHA 0e2ccaaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 61c75bd - Browse repository at this point
Copy the full SHA 61c75bdView commit details -
Configuration menu - View commit details
-
Copy full SHA for f87177b - Browse repository at this point
Copy the full SHA f87177bView commit details -
Configuration menu - View commit details
-
Copy full SHA for a11abe0 - Browse repository at this point
Copy the full SHA a11abe0View commit details -
Add unix::process::CommandExt::arg0
This allows argv[0] to be overridden on the executable's command-line. This also makes the program executed independent of argv[0]. Does Fuchsia have the same semantics? Addresses: rust-lang#66510
Configuration menu - View commit details
-
Copy full SHA for 3de7bd2 - Browse repository at this point
Copy the full SHA 3de7bd2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 614da98 - Browse repository at this point
Copy the full SHA 614da98View commit details -
Configuration menu - View commit details
-
Copy full SHA for f74fe81 - Browse repository at this point
Copy the full SHA f74fe81View commit details
Commits on Nov 19, 2019
-
Move the definition of
QueryResult
intoplumbing.rs
.Because it's the only file that uses it, and removes the need for importing it.
Configuration menu - View commit details
-
Copy full SHA for c84fae1 - Browse repository at this point
Copy the full SHA c84fae1View commit details -
Rollup merge of rust-lang#66090 - pietroalbini:ci-improvements, r=ale…
…xcrichton Misc CI improvements This PR contains some misc improvements to our CI configuration: * The environment variables for MinGW builders were greatly simplified, with just `CUSTOM_MINGW=1` to tell the install scripts to install the vendored copy. All the others (`MINGW_URL`, `MINGW_DIR`, `MINGW_ARCHIVE` and `MSYS_BITS`) are detected either from the builder name or the environment. * Collecting CPU stats and running the build were moved into scripts. * Toolstate scripts validation was previously a separate step, ran just when `IMAGE=mingw-check`. This moves the validation code inside the actual image. * Vendored copies are now fetched from https://ci-mirrors.rust-lang.org instead of directly from the bucket. r? @alexcrichton
Configuration menu - View commit details
-
Copy full SHA for 1b23529 - Browse repository at this point
Copy the full SHA 1b23529View commit details -
Rollup merge of rust-lang#66239 - estebank:suggest-async-closure-call…
…, r=Centril Suggest calling async closure when needed When using an async closure as a value in a place that expects a future, suggest calling the closure. Fix rust-lang#65923.
Configuration menu - View commit details
-
Copy full SHA for 76a1e2c - Browse repository at this point
Copy the full SHA 76a1e2cView commit details -
Rollup merge of rust-lang#66430 - dns2utf8:fix_code_selection_click_h…
…andler, r=GuillaumeGomez [doc] Fix the source code highlighting on source comments The code would always forget the previous selection. r? @GuillaumeGomez
Configuration menu - View commit details
-
Copy full SHA for 0456a83 - Browse repository at this point
Copy the full SHA 0456a83View commit details -
Rollup merge of rust-lang#66431 - Aaron1011:fix/opaque-type-infer, r=…
…varkor Fix 'type annotations needed' error with opaque types Related: rust-lang#66426 This commit adds handling for opaque types during inference variable fallback. Type variables generated from the instantiation of opaque types now fallback to the opaque type itself. Normally, the type variable for an instantiated opaque type is either unified with the concrete type, or with the opaque type itself (e.g when a function returns an opaque type by calling another function). However, it's possible for the type variable to be left completely unconstrained. This can occur in code like this: ```rust pub type Foo = impl Copy; fn produce() -> Option<Foo> { None } ``` Here, we'll instantatiate the `Foo` in `Option<Foo>` to a fresh type variable, but we will never unify it with anything due to the fact that we return a `None`. This results in the error message: ``` type annotations needed: cannot resolve `_: std::marker::Copy ``` pointing at `pub type Foo = impl Copy`. This message is not only confusing, it's incorrect. When an opaque type inference variable is completely unconstrained, we can always fall back to using the opaque type itself. This effectively turns that particular use of the opaque type into a non-defining use, even if it appears in a defining scope.
Configuration menu - View commit details
-
Copy full SHA for 6b0c545 - Browse repository at this point
Copy the full SHA 6b0c545View commit details -
Rollup merge of rust-lang#66461 - clemencetbk:master, r=GuillaumeGomez
Add explanation message for E0641 Part of rust-lang#61137
Configuration menu - View commit details
-
Copy full SHA for 7186de2 - Browse repository at this point
Copy the full SHA 7186de2View commit details -
Configuration menu - View commit details
-
Copy full SHA for a80f69c - Browse repository at this point
Copy the full SHA a80f69cView commit details -
Rollup merge of rust-lang#66478 - petrochenkov:rmplugin, r=davidtwco
rustc_plugin: Remove the compatibility shim The compatibility crate was introduced in rust-lang#62727 to migrate Cargo and some other tools, but now it's no longer necessary.
Configuration menu - View commit details
-
Copy full SHA for f27a0e0 - Browse repository at this point
Copy the full SHA f27a0e0View commit details -
Rollup merge of rust-lang#66493 - JohnTitor:ping-me-rustc-guide, r=sp…
…astorino Add JohnTitor to rustc-guide toolstate notification list Add JohnTitor to rustc-guide toolstate notification list Also, update org names of some books r? @spastorino
Configuration menu - View commit details
-
Copy full SHA for fe5e073 - Browse repository at this point
Copy the full SHA fe5e073View commit details -
Rollup merge of rust-lang#66511 - haraldh:error_chain_nocopy, r=dtolnay
std::error::Chain: remove Copy remove Copy from Iterator as per comment rust-lang#58520 (comment) Tracker: rust-lang#58520
Configuration menu - View commit details
-
Copy full SHA for 8966f76 - Browse repository at this point
Copy the full SHA 8966f76View commit details -
Rollup merge of rust-lang#66512 - jsgf:process-argv0, r=sfackler
Add unix::process::CommandExt::arg0 This allows argv[0] to be overridden on the executable's command-line. This also makes the program executed independent of argv[0]. Does Fuchsia have the same semantics? I'm assuming so. Addresses: rust-lang#66510
Configuration menu - View commit details
-
Copy full SHA for 12834ff - Browse repository at this point
Copy the full SHA 12834ffView commit details -
Rollup merge of rust-lang#66520 - alexcrichton:disable-gdb-wasm, r=eddyb
Disable gdb pretty printer global section on wasm targets The wasm targets don't support gdb anyway so there's no need for this section there.
Configuration menu - View commit details
-
Copy full SHA for 11a8ca4 - Browse repository at this point
Copy the full SHA 11a8ca4View commit details -
Rollup merge of rust-lang#66529 - petrochenkov:reshelp2, r=davidtwco
resolve: Give derive helpers highest priority during resolution So they just shadow everything else and don't create ambiguity errors. This matches the old pre-rust-lang#64694 behavior most closely. --- The change doesn't apply to this "compatibility" case ```rust #[trait_helper] // The helper attribute is used before it introduced. // Sadly, compiles on stable, supported via hacks. // I plan to make a compatibility warning for this. #[derive(Trait)] struct S; ``` , such attributes still create ambiguities, but rust-lang#64694 didn't change anything for this case. Fixes rust-lang#66508 Fixes rust-lang#66525
Configuration menu - View commit details
-
Copy full SHA for 4acec41 - Browse repository at this point
Copy the full SHA 4acec41View commit details -
Rollup merge of rust-lang#66536 - nnethercote:mv-QueryResult, r=Centril
Move the definition of `QueryResult` into `plumbing.rs`. Because it's the only file that uses it, and removes the need for importing it. r? @Centril
Configuration menu - View commit details
-
Copy full SHA for 98d6429 - Browse repository at this point
Copy the full SHA 98d6429View commit details