Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 6 pull requests #66732

Closed
wants to merge 16 commits into from

Conversation

pietroalbini
Copy link
Member

Successful merges:

Failed merges:

r? @ghost

jsgf and others added 16 commits November 19, 2019 11:01
This allows argv[0] to be overridden on the executable's command-line. This also makes the program
executed independent of argv[0].

Does Fuchsia have the same semantics?

Addresses: rust-lang#66510
Some environment variables (like DEPLOY or DEPLOY_ALT for dist builders,
or IMAGE on Linux builders) are set on a lot of builders, and whether
they should be present or not can be detected automatically based on the
builder name and the platform.

This commit simplifies the CI configuration by automatically setting
those environment variables.
Add unix::process::CommandExt::arg0

This allows argv[0] to be overridden on the executable's command-line. This also makes the program
executed independent of argv[0].

Does Fuchsia have the same semantics? I'm assuming so.

Addresses: rust-lang#66510
GitHub Actions: preparations, part 1

This PR adds the first batch of commits in preparation for GitHub Actions:

* Added GitHub Actions support in `src/ci/shared.sh` and bootstrap.
* Addded a `setup-environment.sh` script which guesses and sets the `DEPLOY`, `DEPLOY_ALT` and `IMAGE` environment variables automatically, to reduce the verbosity of the CI configuration.

This PR does **not** yet add any builders on GitHub Actions.

r? @alexcrichton
…=davidtwco

Drive-by cleanup in region naming
…acrum

tidy: Remove unused import

It produces annoying warnings on `x.py` runs.
…entril

Move ErrorReported to rustc_errors

The new location is more consistent with what this type is for, though we don't remove it from the old location (via a re-export) to avoid changing the dozens of use sites (~139 at this time).
@pietroalbini
Copy link
Member Author

@bors r+ p=6 rollup=never

@bors
Copy link
Contributor

bors commented Nov 25, 2019

📌 Commit 083b373 has been approved by pietroalbini

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Nov 25, 2019
@pietroalbini pietroalbini added the rollup A PR which is a rollup label Nov 25, 2019
@bors
Copy link
Contributor

bors commented Nov 25, 2019

⌛ Testing commit 083b373 with merge 670b5bd8b447057e4c7199e188d6cb97c9044043...

@rust-highfive
Copy link
Collaborator

The job dist-arm-linux of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-11-25T09:00:45.0334552Z ##[command]git config gc.auto 0
2019-11-25T09:00:45.0413230Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-11-25T09:00:45.0490123Z ##[command]git config --get-all http.proxy
2019-11-25T09:00:45.0623814Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin
2019-11-25T09:00:46.1829507Z fatal: unable to access 'https://github.com/rust-lang/rust/': GnuTLS recv error (-24): Decryption has failed.
2019-11-25T09:00:46.3030433Z ##[warning]Git fetch failed with exit code 128, back off 2.263 seconds before retry.
---
2019-11-25T09:26:16.9603625Z [ 19%] Building CXX object lib/XRay/CMakeFiles/LLVMXRay.dir/FDRTraceExpander.cpp.o
2019-11-25T09:26:17.1700236Z [ 19%] Building CXX object lib/DebugInfo/PDB/CMakeFiles/LLVMDebugInfoPDB.dir/Native/NativeEnumGlobals.cpp.o
2019-11-25T09:26:17.1982117Z [ 19%] Building CXX object lib/XRay/CMakeFiles/LLVMXRay.dir/FDRTraceWriter.cpp.o
2019-11-25T09:26:17.4143044Z [ 19%] Building CXX object lib/XRay/CMakeFiles/LLVMXRay.dir/FileHeaderReader.cpp.o
2019-11-25T09:26:17.5574146Z sccache: encountered fatal error
2019-11-25T09:26:17.5574277Z sccache: error : Invalid checksum
2019-11-25T09:26:17.5576297Z sccache:  cause: Invalid checksum
2019-11-25T09:26:17.5576835Z make[2]: *** [lib/DebugInfo/PDB/CMakeFiles/LLVMDebugInfoPDB.dir/Native/NativeEnumGlobals.cpp.o] Error 254
2019-11-25T09:26:17.5583695Z make[1]: *** [lib/DebugInfo/PDB/CMakeFiles/LLVMDebugInfoPDB.dir/all] Error 2
2019-11-25T09:26:17.5583794Z make[1]: *** Waiting for unfinished jobs....
2019-11-25T09:26:17.6271606Z [ 19%] Building CXX object lib/XRay/CMakeFiles/LLVMXRay.dir/LogBuilderConsumer.cpp.o
2019-11-25T09:26:17.8650232Z [ 19%] Building CXX object lib/XRay/CMakeFiles/LLVMXRay.dir/Profile.cpp.o
2019-11-25T09:26:17.9322241Z [ 19%] Building CXX object lib/XRay/CMakeFiles/LLVMXRay.dir/RecordInitializer.cpp.o
2019-11-25T09:26:18.1373495Z [ 19%] Building CXX object lib/XRay/CMakeFiles/LLVMXRay.dir/RecordPrinter.cpp.o
2019-11-25T09:26:18.1373495Z [ 19%] Building CXX object lib/XRay/CMakeFiles/LLVMXRay.dir/RecordPrinter.cpp.o
2019-11-25T09:26:18.2052854Z sccache: encountered fatal error
2019-11-25T09:26:18.2053025Z sccache: error : Invalid checksum
2019-11-25T09:26:18.2053151Z sccache:  cause: Invalid checksum
2019-11-25T09:26:18.2066034Z make[2]: *** [lib/XRay/CMakeFiles/LLVMXRay.dir/Profile.cpp.o] Error 254
2019-11-25T09:26:18.2066398Z make[2]: *** Waiting for unfinished jobs....
2019-11-25T09:26:18.3380471Z make[1]: *** [lib/XRay/CMakeFiles/LLVMXRay.dir/all] Error 2
2019-11-25T09:26:18.3380631Z make: *** [all] Error 2
2019-11-25T09:26:18.3397268Z command did not execute successfully, got: exit code: 2
2019-11-25T09:26:18.3397319Z 
2019-11-25T09:26:18.3397319Z 
2019-11-25T09:26:18.3397693Z build script failed, must exit now', /cargo/registry/src/git.luolix.top-1ecc6299db9ec823/cmake-0.1.38/src/lib.rs:813:5
2019-11-25T09:26:18.3403603Z  finished in 69.235
2019-11-25T09:26:18.3424378Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap dist --host arm-unknown-linux-gnueabi --target arm-unknown-linux-gnueabi
2019-11-25T09:26:18.3424602Z Build completed unsuccessfully in 0:20:57
2019-11-25T09:26:18.3480883Z == clock drift check ==
2019-11-25T09:26:18.3480883Z == clock drift check ==
2019-11-25T09:26:18.3496536Z   local time: Mon Nov 25 09:26:18 UTC 2019
2019-11-25T09:26:18.3794675Z   network time: Mon, 25 Nov 2019 09:26:18 GMT
2019-11-25T09:26:18.3796578Z == end clock drift check ==
2019-11-25T09:26:19.4229842Z 
2019-11-25T09:26:19.4250542Z ##[error]Bash exited with code '1'.
2019-11-25T09:26:19.4278144Z ##[section]Starting: Checkout
2019-11-25T09:26:19.4280656Z ==============================================================================
2019-11-25T09:26:19.4280964Z Task         : Get sources
2019-11-25T09:26:19.4281069Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@bors
Copy link
Contributor

bors commented Nov 25, 2019

💔 Test failed - checks-azure

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 25, 2019
@pietroalbini
Copy link
Member Author

Wut.

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 25, 2019
@bors
Copy link
Contributor

bors commented Nov 25, 2019

⌛ Testing commit 083b373 with merge 104770791e7059a1db8ca8b475b76e3d6f2218bf...

@rust-highfive
Copy link
Collaborator

The job mingw-check of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-11-25T12:49:48.2733974Z     Checking rustc_errors v0.0.0 (/checkout/src/librustc_errors)
2019-11-25T12:49:48.4584962Z error[E0405]: cannot find trait `HashStableContext` in module `crate`
2019-11-25T12:49:48.4585637Z     --> src/librustc_errors/lib.rs:1000:62
2019-11-25T12:49:48.4586063Z      |
2019-11-25T12:49:48.4586432Z 1000 |   #[derive(Clone, Copy, Debug, RustcEncodable, RustcDecodable, HashStable_Generic)]
2019-11-25T12:49:48.4587340Z      |                                                                |
2019-11-25T12:49:48.4587763Z      |                                                                not found in `crate`
2019-11-25T12:49:48.4588128Z      |                                                                in this macro invocation
2019-11-25T12:49:48.4588357Z      |
---
2019-11-25T12:49:51.2701233Z   local time: Mon Nov 25 12:49:51 UTC 2019
2019-11-25T12:49:51.4209914Z   network time: Mon, 25 Nov 2019 12:49:51 GMT
2019-11-25T12:49:51.4220111Z == end clock drift check ==
2019-11-25T12:49:52.7816662Z 
2019-11-25T12:49:52.7930039Z ##[error]Bash exited with code '1'.
2019-11-25T12:49:52.7963550Z ##[section]Starting: Checkout
2019-11-25T12:49:52.7965540Z ==============================================================================
2019-11-25T12:49:52.7966000Z Task         : Get sources
2019-11-25T12:49:52.7966269Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@bors
Copy link
Contributor

bors commented Nov 25, 2019

💔 Test failed - checks-azure

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 25, 2019
@bors
Copy link
Contributor

bors commented Nov 26, 2019

☔ The latest upstream changes (presumably #66776) made this pull request unmergeable. Please resolve the merge conflicts.

@pietroalbini pietroalbini deleted the rollup-cu314tz branch November 27, 2019 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rollup A PR which is a rollup S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants