-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Miri: do not consider memory allocated by caller_location leaked #66844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Nov 28, 2019
RalfJung
changed the title
do not consider memory allocated by caller_location leaked
Miri: do not consider memory allocated by caller_location leaked
Nov 28, 2019
This was referenced Nov 28, 2019
@bors r+ |
📌 Commit 3048d7e has been approved by |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Nov 28, 2019
RalfJung
added a commit
to RalfJung/rust
that referenced
this pull request
Nov 29, 2019
…i-obk Miri: do not consider memory allocated by caller_location leaked Fixes rust-lang/miri#1071 r? @oli-obk I am not sure if this is the best approach, but it certainly is the easiest.
RalfJung
added a commit
to RalfJung/rust
that referenced
this pull request
Nov 29, 2019
…i-obk Miri: do not consider memory allocated by caller_location leaked Fixes rust-lang/miri#1071 r? @oli-obk I am not sure if this is the best approach, but it certainly is the easiest.
bors
added a commit
that referenced
this pull request
Nov 29, 2019
Rollup of 11 pull requests Successful merges: - #66379 (Rephrase docs in for ptr) - #66589 (Draw vertical lines correctly in compiler error messages) - #66613 (Allow customising ty::TraitRef's printing behavior) - #66766 (Panic machinery comments and tweaks) - #66791 (Handle GlobalCtxt directly from librustc_interface query system) - #66793 (Record temporary static references in generator witnesses) - #66808 (Cleanup error code) - #66826 (Clarifies how to tag users for assigning PRs) - #66837 (Clarify `{f32,f64}::EPSILON` docs) - #66844 (Miri: do not consider memory allocated by caller_location leaked) - #66872 (Minor documentation fix) Failed merges: r? @ghost
bors
added a commit
to rust-lang/miri
that referenced
this pull request
Dec 1, 2019
test more panics Add some tests for #1071. Blocked on rust-lang/rust#66844.
bors
added a commit
to rust-lang/miri
that referenced
this pull request
Dec 1, 2019
test more panics Add some tests for #1071. Blocked on rust-lang/rust#66844.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes rust-lang/miri#1071
r? @oli-obk
I am not sure if this is the best approach, but it certainly is the easiest.