core: Fail with a better error message when list_dir gets an empty path #6687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What does this do for listing |
|
Hmm, really? Ok, I'll add a test for the root directory (to make sure the contents are non-empty, at least). |
(Yes, this did happen in real life...)
...and don't treat Path("/") like Path("").
bors
added a commit
that referenced
this pull request
May 26, 2013
r? @brson (Yes, this did happen in real life...)
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Feb 11, 2021
Stabilize workspace wrapper. This fixes it so that `cargo clippy` doesn't share the same cache artifacts as `cargo check`. The Cargo side was stabilized a while ago (rust-lang/cargo#8976), so this should be ready to go. I'm not aware of any blockers or concerns. Closes rust-lang#4612 --- changelog: `cargo clippy` no longer shares the same build cache as `cargo check`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @brson (Yes, this did happen in real life...)