Standard library support for riscv64gc-unknown-linux-gnu #66899

msizanoen1 · 2019-11-30T12:18:13Z

Add std support for RISC-V 64-bit GNU/Linux and update libc for RISC-V support.

rust-highfive · 2019-11-30T12:22:46Z

The job x86_64-gnu-llvm-6.0 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2019-11-30T12:18:55.3728773Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-11-30T12:18:56.1855873Z ##[command]git config gc.auto 0
2019-11-30T12:18:56.1858187Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-11-30T12:18:56.1859719Z ##[command]git config --get-all http.proxy
2019-11-30T12:18:56.1863131Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/66899/merge:refs/remotes/pull/66899/merge
---
2019-11-30T12:22:01.7358905Z 
2019-11-30T12:22:01.7359137Z ######################################################################## 100.0%
2019-11-30T12:22:02.0774549Z extracting /checkout/obj/build/cache/2019-11-06/cargo-beta-x86_64-unknown-linux-gnu.tar.gz
2019-11-30T12:22:02.1467530Z     Updating crates.io index
2019-11-30T12:22:09.1715736Z error: the lock file /checkout/Cargo.lock needs to be updated but --locked was passed to prevent this
2019-11-30T12:22:09.1743593Z failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
2019-11-30T12:22:09.1789754Z make: *** [prepare] Error 1
2019-11-30T12:22:09.1790539Z Makefile:67: recipe for target 'prepare' failed
2019-11-30T12:22:10.1809697Z Command failed. Attempt 2/5:
2019-11-30T12:22:10.1809697Z Command failed. Attempt 2/5:
2019-11-30T12:22:10.3665068Z error: the lock file /checkout/Cargo.lock needs to be updated but --locked was passed to prevent this
2019-11-30T12:22:10.3681239Z failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
2019-11-30T12:22:10.3721755Z Makefile:67: recipe for target 'prepare' failed
2019-11-30T12:22:10.3721821Z make: *** [prepare] Error 1
2019-11-30T12:22:12.3736968Z Command failed. Attempt 3/5:
2019-11-30T12:22:12.3736968Z Command failed. Attempt 3/5:
2019-11-30T12:22:12.5543169Z error: the lock file /checkout/Cargo.lock needs to be updated but --locked was passed to prevent this
2019-11-30T12:22:12.5556228Z failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
2019-11-30T12:22:12.5593612Z make: *** [prepare] Error 1
2019-11-30T12:22:12.5594238Z Makefile:67: recipe for target 'prepare' failed
2019-11-30T12:22:15.5616289Z Command failed. Attempt 4/5:
2019-11-30T12:22:15.5616289Z Command failed. Attempt 4/5:
2019-11-30T12:22:15.7440508Z error: the lock file /checkout/Cargo.lock needs to be updated but --locked was passed to prevent this
2019-11-30T12:22:15.7446619Z failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
2019-11-30T12:22:15.7489682Z Makefile:67: recipe for target 'prepare' failed
2019-11-30T12:22:15.7490094Z make: *** [prepare] Error 1
2019-11-30T12:22:19.7504716Z Command failed. Attempt 5/5:
2019-11-30T12:22:19.7504716Z Command failed. Attempt 5/5:
2019-11-30T12:22:19.9394611Z error: the lock file /checkout/Cargo.lock needs to be updated but --locked was passed to prevent this
2019-11-30T12:22:19.9404811Z failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
2019-11-30T12:22:19.9450529Z Makefile:67: recipe for target 'prepare' failed
2019-11-30T12:22:19.9450897Z make: *** [prepare] Error 1
2019-11-30T12:22:19.9453152Z The command has failed after 5 attempts.
2019-11-30T12:22:19.9455524Z == clock drift check ==
2019-11-30T12:22:19.9455524Z == clock drift check ==
2019-11-30T12:22:19.9463662Z   local time: Sat Nov 30 12:22:19 UTC 2019
2019-11-30T12:22:20.0079656Z   network time: Sat, 30 Nov 2019 12:22:20 GMT
2019-11-30T12:22:20.0082403Z == end clock drift check ==
2019-11-30T12:22:32.2303698Z 
2019-11-30T12:22:32.2406350Z ##[error]Bash exited with code '1'.
2019-11-30T12:22:32.2432338Z ##[section]Starting: Checkout
2019-11-30T12:22:32.2434627Z ==============================================================================
2019-11-30T12:22:32.2434919Z Task         : Get sources
2019-11-30T12:22:32.2434964Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

bors · 2019-11-30T15:56:54Z

☔ The latest upstream changes (presumably #66887) made this pull request unmergeable. Please resolve the merge conflicts.

alexcrichton · 2019-12-02T16:04:23Z

@bors: r+ rollup

👍

bors · 2019-12-02T16:04:24Z

📌 Commit 930a0a2 has been approved by alexcrichton

@alexcrichton

Standard library support for riscv64gc-unknown-linux-gnu Add std support for RISC-V 64-bit GNU/Linux and update libc for RISC-V support. r? @alexcrichton

msizanoen1 · 2019-12-03T05:23:13Z

After this would be builds on CI: master...msizanoen1:riscv-ci
It is put on a separate builder so we can easily add it as a rustc host later.

msizanoen1 · 2019-12-19T04:00:12Z

This is the result of running the x86_64-gnu container on this PR: https://dev.azure.com/rust-lang/rust/_build/results?buildId=16159&view=results (I copy pasted the x86_64-gnu Dockerfile into x86_64-gnu-llvm-7 and removed the commit after it finishes running).
The test succeed with 0 cache misses.
It's probably not cache problem.

msizanoen1 · 2019-12-19T04:03:57Z

Centril's comment says that this PR causes multiple rollups to fail and it is the same test failure (pgo-branch-weights). However it seems that there should not be any reason for the test to fail.

msizanoen1 · 2019-12-28T04:12:19Z

Updating libc is already done in #67594 so this is only porting and updating LLVM to include rust-lang/llvm-project#29 and possibly also rust-lang/cc-rs#461 (comment)

msizanoen1 · 2019-12-28T04:15:26Z

@alexcrichton Can you retry merging?

msizanoen1 · 2020-01-01T02:45:58Z

r? @Zoxc due to inactivity

mati865 · 2020-01-03T11:23:35Z

Previous CI error was spurious: #67746

msizanoen1 · 2020-01-06T15:48:09Z

@alexcrichton Can you try merging it?

alexcrichton · 2020-01-06T17:59:03Z

@bors: r+

bors · 2020-01-06T17:59:05Z

📌 Commit d61e193 has been approved by alexcrichton

bors · 2020-01-06T19:07:49Z

⌛ Testing commit d61e193 with merge ef92009...

@alexcrichton

Standard library support for riscv64gc-unknown-linux-gnu Add std support for RISC-V 64-bit GNU/Linux and update libc for RISC-V support. r? @alexcrichton

bors · 2020-01-06T22:22:00Z

☀️ Test successful - checks-azure
Approved by: alexcrichton
Pushing ef92009 to master...

Version 1.42.0 (2020-03-12) ========================== Language -------- - [You can now use the slice pattern syntax with subslices.][67712] e.g. ```rust fn foo(words: &[&str]) { match words { ["Hello", "World", "!", ..] => println!("Hello World!"), ["Foo", "Bar", ..] => println!("Baz"), rest => println!("{:?}", rest), } } ``` - [You can now use `#[repr(transparent)]` on univariant `enum`s.][68122] Meaning that you can create an enum that has the exact layout and ABI of the type it contains. - [There are some *syntax-only* changes:][67131] - `default` is syntactically allowed before items in `trait` definitions. - Items in `impl`s (i.e. `const`s, `type`s, and `fn`s) may syntactically leave out their bodies in favor of `;`. - Bounds on associated types in `impl`s are now syntactically allowed (e.g. `type Foo: Ord;`). - `...` (the C-variadic type) may occur syntactically directly as the type of any function parameter. These are still rejected *semantically*, so you will likely receive an error but these changes can be seen and parsed by procedural macros and conditional compilation. Compiler -------- - [Added tier 2* support for `armv7a-none-eabi`.][68253] - [Added tier 2 support for `riscv64gc-unknown-linux-gnu`.][68339] - [`Option::{expect,unwrap}` and `Result::{expect, expect_err, unwrap, unwrap_err}` now produce panic messages pointing to the location where they were called, rather than `core`'s internals. ][67887] * Refer to Rust's [platform support page][forge-platform-support] for more information on Rust's tiered platform support. Libraries --------- - [`iter::Empty<T>` now implements `Send` and `Sync` for any `T`.][68348] - [`Pin::{map_unchecked, map_unchecked_mut}` no longer require the return type to implement `Sized`.][67935] - [`io::Cursor` now derives `PartialEq` and `Eq`.][67233] - [`Layout::new` is now `const`.][66254] - [Added Standard Library support for `riscv64gc-unknown-linux-gnu`.][66899] Stabilized APIs --------------- - [`CondVar::wait_while`] - [`CondVar::wait_timeout_while`] - [`DebugMap::key`] - [`DebugMap::value`] - [`ManuallyDrop::take`] - [`matches!`] - [`ptr::slice_from_raw_parts_mut`] - [`ptr::slice_from_raw_parts`] Cargo ----- - [You no longer need to include `extern crate proc_macro;` to be able to `use proc_macro;` in the `2018` edition.][cargo/7700] Compatibility Notes ------------------- - [`Error::description` has been deprecated, and its use will now produce a warning.][66919] It's recommended to use `Display`/`to_string` instead. - [`use $crate;` inside macros is now a hard error.][37390] The compiler emitted forward compatibility warnings since Rust 1.14.0. - [As previously announced, this release reduces the level of support for 32-bit Apple targets to tier 3.][apple-32bit-drop]. This means that the source code is still available to build, but the targets are no longer tested and no release binary is distributed by the Rust project. Please refer to the linked blog post for more information. [37390]: rust-lang/rust#37390 [68253]: rust-lang/rust#68253 [68348]: rust-lang/rust#68348 [67935]: rust-lang/rust#67935 [68339]: rust-lang/rust#68339 [68122]: rust-lang/rust#68122 [67712]: rust-lang/rust#67712 [67887]: rust-lang/rust#67887 [67131]: rust-lang/rust#67131 [67233]: rust-lang/rust#67233 [66899]: rust-lang/rust#66899 [66919]: rust-lang/rust#66919 [66254]: rust-lang/rust#66254 [cargo/7700]: rust-lang/cargo#7700 [`DebugMap::key`]: https://doc.rust-lang.org/stable/std/fmt/struct.DebugMap.html#method.key [`DebugMap::value`]: https://doc.rust-lang.org/stable/std/fmt/struct.DebugMap.html#method.value [`ManuallyDrop::take`]: https://doc.rust-lang.org/stable/std/mem/struct.ManuallyDrop.html#method.take [`matches!`]: https://doc.rust-lang.org/stable/std/macro.matches.html [`ptr::slice_from_raw_parts_mut`]: https://doc.rust-lang.org/stable/std/ptr/fn.slice_from_raw_parts_mut.html [`ptr::slice_from_raw_parts`]: https://doc.rust-lang.org/stable/std/ptr/fn.slice_from_raw_parts.html [`CondVar::wait_while`]: https://doc.rust-lang.org/stable/std/sync/struct.Condvar.html#method.wait_while [`CondVar::wait_timeout_while`]: https://doc.rust-lang.org/stable/std/sync/struct.Condvar.html#method.wait_timeout_while

rust-highfive assigned alexcrichton Nov 30, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 30, 2019

msizanoen1 changed the title ~~Standard library port for riscv64gc-unknown-linux-gnu~~ Standard library support for riscv64gc-unknown-linux-gnu Nov 30, 2019

msizanoen1 mentioned this pull request Nov 30, 2019

Support riscv64gc-unknown-linux-gnu target #62117

Closed

msizanoen1 force-pushed the riscv-std branch from a428934 to bdde2a5 Compare November 30, 2019 12:27

msizanoen1 force-pushed the riscv-std branch from bdde2a5 to 930a0a2 Compare December 1, 2019 00:31