Cleanup warnings #6690
Closed
Cleanup warnings #6690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for doing cleanup! |
bors
added a commit
that referenced
this pull request
May 24, 2013
Simple patch series to fix up all the warnings a rustc compile is giving at the moment. It also fixes a NOTE in `to_bytes.rs` to remove the `to_bytes::iter_bytes_<N>` functions.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Feb 11, 2021
Downgrade trivial_regex to nursery See rust-lang#6690. I think there is still value in a trivial_regex lint, but only if clippy can tell that the regex is only ever constructed and applied to a single input. ```rust let regex = Regex::new("trivial_regex")?; println!("{}", regex.is_match(s)); // `regex` never used again ``` --- changelog: remove `trivial_regex` from default set of enabled lints
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple patch series to fix up all the warnings a rustc compile is giving at the moment. It also fixes a NOTE in
to_bytes.rsto remove theto_bytes::iter_bytes_<N>functions.