Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

submodules: update clippy from 7b8e8293 to 45196cee #66947

Merged
merged 1 commit into from
Dec 3, 2019

Conversation

matthiaskrgr
Copy link
Member

Changes:

account for external macro in MISSING_INLINE_IN_PUBLIC_ITEMS lint
build(tests/fmt): use shared target dir
chore: fix and split some ui tests on 32bit system
build: set up build job for i686 targets
remove needless my_lint ui test
git quiet
deploy: cd to out/ before adding files to git
Less needless_doctest_main false positives
fmt
Feed the dog
Use rustc_env instead of exec_env for test
Make triggering this lint less likely :paperclip:
Use exec_env to set backtrace level and normalize output
Update custom ICE function with latest rustc
Use Clippy version in ICE message
Add custom ICE message that points to Clippy repo
Fix master deployment
Run update_lints
Add projections check to EUV for escape analysis
Use infer_ctxt
Move use_self to nursery
Use `println!` on success instead of `eprintln!`
Revert "Disable chalk integration test. Output too large"
Remove the old integration-tests.sh script
Use rust implementation for integration tests in CI
Rust implementation of integration test
Don't error on clippy.toml of dependencies
Fix categorizations
Fix arguments on ExprUseVisitor::new
euv moved from middle to typeck
cmt_ -> Place
build: check if RTIM is not installed
make use of Result::map_or
trigger string_lit_as_bytes when literal has escapes
Remove negative float literal checks.
Enable deny-warnings feature everywhere in CI
Remove unused debugging feature
implemented `as_conversions` lint
fixing a typo
[comparison_chain] #4827 Check `core::cmp::Ord` is implemented
add a good example for the approx_const lint
Add suggested good cases in docs for lifetimes lint

Fixes #66840

@rust-highfive
Copy link
Collaborator

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 2, 2019
@matthiaskrgr
Copy link
Member Author

r? @Manishearth @oli-obk

@Manishearth
Copy link
Member

@bors r+ P=2

@bors
Copy link
Contributor

bors commented Dec 2, 2019

📌 Commit ef15d60e4fef53729337704a5d89ad67cf8431ff has been approved by Manishearth

@bors
Copy link
Contributor

bors commented Dec 2, 2019

🌲 The tree is currently closed for pull requests below priority 1000, this pull request will be tested once the tree is reopened

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 2, 2019
@Manishearth
Copy link
Member

@bors p=2

@Centril
Copy link
Contributor

Centril commented Dec 2, 2019

@bors treeclosed-

@bors
Copy link
Contributor

bors commented Dec 2, 2019

⌛ Testing commit ef15d60e4fef53729337704a5d89ad67cf8431ff with merge e93d3dc8599734486280c39e4d49580140b5bbd9...

@matthiaskrgr
Copy link
Member Author

@Centril can you chancel this? Looks like the latest rollup broke clippy again.. :/

@Centril
Copy link
Contributor

Centril commented Dec 2, 2019

@bors r- retry

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 2, 2019
@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-tools of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-12-02T05:55:58.5668438Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-12-02T05:55:58.5684816Z ##[command]git config gc.auto 0
2019-12-02T05:55:58.5690766Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-12-02T05:55:58.5692760Z ##[command]git config --get-all http.proxy
2019-12-02T05:55:59.7854087Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/66947/merge:refs/remotes/pull/66947/merge
---
2019-12-02T07:36:04.9737490Z    Compiling reqwest v0.9.22
2019-12-02T07:36:48.5665121Z    Compiling mdbook-linkcheck v0.5.0
2019-12-02T07:36:59.9884434Z    Compiling rustbook v0.1.0 (/checkout/src/tools/rustbook)
2019-12-02T07:37:04.8589669Z     Finished release [optimized] target(s) in 11m 16s
2019-12-02T07:38:43.0300402Z error: The server responded with 404 Not Found for "https://forge.rust-lang.org/rustc-bug-fix-procedure.html"
2019-12-02T07:38:43.0301983Z     ┌── compiler-team.md:40:3 ───
2019-12-02T07:38:43.0302472Z     │
2019-12-02T07:38:43.0302472Z     │
2019-12-02T07:38:43.0303037Z  40 │   [aim to give warnings first][procedure]).
2019-12-02T07:38:43.0304724Z     │
2019-12-02T07:38:43.0305128Z 
2019-12-02T07:38:43.0305670Z error: The server responded with 404 Not Found for "https://forge.rust-lang.org/platform-support.html"
2019-12-02T07:38:43.0305916Z 
2019-12-02T07:38:43.0305916Z 
2019-12-02T07:38:43.0306584Z      ┌── tests/intro.md:116:8 ───
2019-12-02T07:38:43.0307053Z      │
2019-12-02T07:38:43.0308515Z  116 │ Rust's [platform tiers]).
2019-12-02T07:38:43.0309713Z      │
2019-12-02T07:38:43.0309995Z 
2019-12-02T07:38:43.0310584Z error: The server responded with 404 Not Found for "https://doc.rust-lang.org/nightly/nightly-rustc/rustc/middle/expr_use_visitor/struct.ExprUseVisitor.html"
2019-12-02T07:38:43.0310881Z 
---
2019-12-02T07:38:43.0326099Z error: The server responded with 404 Not Found for "https://forge.rust-lang.org/stabilization-guide.html"
2019-12-02T07:38:43.0326242Z 
2019-12-02T07:38:43.0326743Z     ┌── important-links.md:11:1 ───
2019-12-02T07:38:43.0327258Z     │
2019-12-02T07:38:43.0328461Z  11 │ [link](https://forge.rust-lang.org/stabilization-guide.html#updating-documentation)
2019-12-02T07:38:43.0329414Z     │
2019-12-02T07:38:43.0329582Z 
2019-12-02T07:38:43.0330010Z error: The server responded with 404 Not Found for "https://forge.rust-lang.org/stabilization-guide.html"
2019-12-02T07:38:43.0330424Z 
2019-12-02T07:38:43.0330424Z 
2019-12-02T07:38:43.0330826Z     ┌── important-links.md:12:1 ───
2019-12-02T07:38:43.0331186Z     │
2019-12-02T07:38:43.0331806Z  12 │ [link](https://forge.rust-lang.org/stabilization-guide.html#documentation-prs)
2019-12-02T07:38:43.0332725Z     │
2019-12-02T07:38:43.0332882Z 
2019-12-02T07:38:43.0333000Z Error: One or more incorrect links
2019-12-02T07:38:43.0356055Z 
---
2019-12-02T07:51:57.8562662Z error: internal compiler error: unexpected panic
2019-12-02T07:51:57.8562686Z 
2019-12-02T07:51:57.8563106Z note: the compiler unexpectedly panicked. this is a bug.
2019-12-02T07:51:57.8563132Z 
2019-12-02T07:51:57.8563546Z note: we would appreciate a bug report: ***-clippy/issues/new
2019-12-02T07:51:57.8563630Z note: Clippy version: foo
2019-12-02T07:51:57.8563653Z 
2019-12-02T07:51:57.8567194Z 
2019-12-02T07:51:57.8567263Z 
2019-12-02T07:51:57.8567263Z 
2019-12-02T07:51:57.8570876Z expected stderr:
2019-12-02T07:51:57.8576440Z thread 'rustc' panicked at 'Testing the ICE message', clippy_lints/src/utils/internal_lints.rs
2019-12-02T07:51:57.8576593Z 
2019-12-02T07:51:57.8576638Z error: internal compiler error: unexpected panic
2019-12-02T07:51:57.8576668Z 
2019-12-02T07:51:57.8576713Z note: the compiler unexpectedly panicked. this is a bug.
2019-12-02T07:51:57.8576713Z note: the compiler unexpectedly panicked. this is a bug.
2019-12-02T07:51:57.8576939Z 
2019-12-02T07:51:57.8577368Z note: we would appreciate a bug report: ***-clippy/issues/new
2019-12-02T07:51:57.8577516Z note: Clippy version: foo
2019-12-02T07:51:57.8577548Z 
2019-12-02T07:51:57.8581884Z 
2019-12-02T07:51:57.8582008Z 
2019-12-02T07:51:57.8582008Z 
2019-12-02T07:51:57.8586054Z diff of stderr:
2019-12-02T07:51:57.8586128Z 
2019-12-02T07:51:57.8590385Z -thread 'rustc' panicked at 'Testing the ICE message', clippy_lints/src/utils/internal_lints.rs
2019-12-02T07:51:57.8611862Z +thread 'rustc' panicked at 'Testing the ICE message', src/tools/clippy/clippy_lints/src/utils/internal_lints.rs
2019-12-02T07:51:57.8612145Z  
2019-12-02T07:51:57.8612201Z  error: internal compiler error: unexpected panic
2019-12-02T07:51:57.8612241Z  
2019-12-02T07:51:57.8612279Z  note: the compiler unexpectedly panicked. this is a bug.
2019-12-02T07:51:57.8612279Z  note: the compiler unexpectedly panicked. this is a bug.
2019-12-02T07:51:57.8612317Z  
2019-12-02T07:51:57.8612667Z  note: we would appreciate a bug report: ***-clippy/issues/new
2019-12-02T07:51:57.8612750Z  note: Clippy version: foo
2019-12-02T07:51:57.8612810Z  
2019-12-02T07:51:57.8612843Z  
2019-12-02T07:51:57.8612868Z 
2019-12-02T07:51:57.8612868Z 
2019-12-02T07:51:57.8612926Z The actual stderr differed from the expected stderr.
2019-12-02T07:51:57.8613299Z Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/build/clippy-317c1b266af760ab/out/test_build_base/custom_ice_message.stderr
2019-12-02T07:51:57.8613359Z To update references, run this command from build directory:
2019-12-02T07:51:57.8613737Z tests/ui/update-references.sh '/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/build/clippy-317c1b266af760ab/out/test_build_base' 'custom_ice_message.rs'
2019-12-02T07:51:57.8613814Z error: 1 errors occurred comparing output.
2019-12-02T07:51:57.8613869Z status: exit code: 101
2019-12-02T07:51:57.8613869Z status: exit code: 101
2019-12-02T07:51:57.8616451Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools-bin/clippy-driver" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools-bin/clippy-driver" "tests/ui/custom_ice_message.rs" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/build/clippy-317c1b266af760ab/out/test_build_base" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/build/clippy-317c1b266af760ab/out/test_build_base/custom_ice_message.stage-id" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/release" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/release/deps" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps" "-Dwarnings" "-Zui-testing" "--extern" "serde=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libserde-4cf2006b2fb0099f.rlib" "--extern" "regex=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libregex-70d9308013a308bf.rlib" "--extern" "clippy_lints=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libclippy_lints-93610b460d310c52.rlib" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/build/clippy-317c1b266af760ab/out/test_build_base/custom_ice_message.stage-id.aux" "-A" "unused"
2019-12-02T07:51:57.8617210Z ------------------------------------------
2019-12-02T07:51:57.8617247Z 
2019-12-02T07:51:57.8617501Z ------------------------------------------
2019-12-02T07:51:57.8617549Z stderr:
---
2019-12-02T07:51:57.8618358Z error: internal compiler error: unexpected panic
2019-12-02T07:51:57.8618407Z 
2019-12-02T07:51:57.8618694Z note: the compiler unexpectedly panicked. this is a bug.
2019-12-02T07:51:57.8618729Z 
2019-12-02T07:51:57.8619141Z note: we would appreciate a bug report: ***-clippy/issues/new
2019-12-02T07:51:57.8619180Z 
2019-12-02T07:51:57.8619648Z note: Clippy version: clippy 0.0.212 (45196ce 2019-12-01)
2019-12-02T07:51:57.8619694Z 
2019-12-02T07:51:57.8620053Z ------------------------------------------
2019-12-02T07:51:57.8620076Z 
2019-12-02T07:51:57.8620108Z test [ui] ui/custom_ice_message.rs ... FAILED
---
2019-12-02T08:17:59.6219302Z Verifying status of rustfmt...
2019-12-02T08:17:59.6233201Z Verifying status of clippy-driver...
2019-12-02T08:17:59.6247605Z This PR updated 'src/tools/clippy', verifying if status is 'test-pass'...
2019-12-02T08:17:59.6261616Z 
2019-12-02T08:17:59.6262681Z ⚠️ We detected that this PR updated 'clippy-driver', but its tests failed.
2019-12-02T08:17:59.6263852Z 
2019-12-02T08:17:59.6264498Z If you do intend to update 'clippy-driver', please check the error messages above and
2019-12-02T08:17:59.6264719Z commit another update.
2019-12-02T08:17:59.6264865Z 
2019-12-02T08:17:59.6265311Z If you do NOT intend to update 'clippy-driver', please ensure you did not accidentally
2019-12-02T08:17:59.6266208Z change the submodule at 'src/tools/clippy'. You may ask your reviewer for the
2019-12-02T08:17:59.6267754Z proper steps.
2019-12-02T08:17:59.6285083Z   local time: Mon Dec  2 08:17:59 UTC 2019
2019-12-02T08:17:59.9192620Z   network time: Mon, 02 Dec 2019 08:17:59 GMT
2019-12-02T08:17:59.9197488Z == end clock drift check ==
2019-12-02T08:18:01.1564512Z 
2019-12-02T08:18:01.1564512Z 
2019-12-02T08:18:01.1668065Z ##[error]Bash exited with code '3'.
2019-12-02T08:18:01.1706354Z ##[section]Starting: Checkout
2019-12-02T08:18:01.1708456Z ==============================================================================
2019-12-02T08:18:01.1708511Z Task         : Get sources
2019-12-02T08:18:01.1708576Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

Changes:
````
Normalize custom ICE test
Rustup to rust-lang#64736
Use assert_crate_local for a more explicit error
Rustup to rust-lang#66789
account for external macro in MISSING_INLINE_IN_PUBLIC_ITEMS lint
build(tests/fmt): use shared target dir
chore: fix and split some ui tests on 32bit system
build: set up build job for i686 targets
remove needless my_lint ui test
git quiet
deploy: cd to out/ before adding files to git
Less needless_doctest_main false positives
fmt
Feed the dog
Use rustc_env instead of exec_env for test
Make triggering this lint less likely 📎
Use exec_env to set backtrace level and normalize output
Update custom ICE function with latest rustc
Use Clippy version in ICE message
Add custom ICE message that points to Clippy repo
Fix master deployment
Run update_lints
Add projections check to EUV for escape analysis
Use infer_ctxt
Move use_self to nursery
Use `println!` on success instead of `eprintln!`
Revert "Disable chalk integration test. Output too large"
Remove the old integration-tests.sh script
Use rust implementation for integration tests in CI
Rust implementation of integration test
Don't error on clippy.toml of dependencies
Fix categorizations
Fix arguments on ExprUseVisitor::new
euv moved from middle to typeck
cmt_ -> Place
build: check if RTIM is not installed
make use of Result::map_or
trigger string_lit_as_bytes when literal has escapes
Remove negative float literal checks.
Enable deny-warnings feature everywhere in CI
Remove unused debugging feature
implemented `as_conversions` lint
fixing a typo
[comparison_chain] rust-lang#4827 Check `core::cmp::Ord` is implemented
add a good example for the approx_const lint
Add suggested good cases in docs for lifetimes lint
````
@matthiaskrgr
Copy link
Member Author

updated to latest clippy state

@oli-obk
Copy link
Contributor

oli-obk commented Dec 3, 2019

@bors r+ p=1

@bors
Copy link
Contributor

bors commented Dec 3, 2019

📌 Commit f77104b has been approved by oli-obk

@oli-obk
Copy link
Contributor

oli-obk commented Dec 3, 2019

@bors p=2

@bors
Copy link
Contributor

bors commented Dec 3, 2019

⌛ Testing commit f77104b with merge 7d80865...

bors added a commit that referenced this pull request Dec 3, 2019
submodules: update clippy from 7b8e829 to 45196ce

Changes:
````
account for external macro in MISSING_INLINE_IN_PUBLIC_ITEMS lint
build(tests/fmt): use shared target dir
chore: fix and split some ui tests on 32bit system
build: set up build job for i686 targets
remove needless my_lint ui test
git quiet
deploy: cd to out/ before adding files to git
Less needless_doctest_main false positives
fmt
Feed the dog
Use rustc_env instead of exec_env for test
Make triggering this lint less likely 📎
Use exec_env to set backtrace level and normalize output
Update custom ICE function with latest rustc
Use Clippy version in ICE message
Add custom ICE message that points to Clippy repo
Fix master deployment
Run update_lints
Add projections check to EUV for escape analysis
Use infer_ctxt
Move use_self to nursery
Use `println!` on success instead of `eprintln!`
Revert "Disable chalk integration test. Output too large"
Remove the old integration-tests.sh script
Use rust implementation for integration tests in CI
Rust implementation of integration test
Don't error on clippy.toml of dependencies
Fix categorizations
Fix arguments on ExprUseVisitor::new
euv moved from middle to typeck
cmt_ -> Place
build: check if RTIM is not installed
make use of Result::map_or
trigger string_lit_as_bytes when literal has escapes
Remove negative float literal checks.
Enable deny-warnings feature everywhere in CI
Remove unused debugging feature
implemented `as_conversions` lint
fixing a typo
[comparison_chain] #4827 Check `core::cmp::Ord` is implemented
add a good example for the approx_const lint
Add suggested good cases in docs for lifetimes lint
````
Fixes #66840
@bors
Copy link
Contributor

bors commented Dec 3, 2019

☀️ Test successful - checks-azure
Approved by: oli-obk
Pushing 7d80865 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 3, 2019
@bors bors merged commit f77104b into rust-lang:master Dec 3, 2019
@rust-highfive
Copy link
Collaborator

📣 Toolstate changed by #66947!

Tested on commit 7d80865.
Direct link to PR: #66947

🎉 clippy-driver on windows: build-fail → test-pass (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq, @rust-lang/infra).
🎉 clippy-driver on linux: build-fail → test-pass (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq, @rust-lang/infra).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Dec 3, 2019
Tested on commit rust-lang/rust@7d80865.
Direct link to PR: <rust-lang/rust#66947>

🎉 clippy-driver on windows: build-fail → test-pass (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq, @rust-lang/infra).
🎉 clippy-driver on linux: build-fail → test-pass (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq, @rust-lang/infra).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

clippy-driver no longer builds after rust-lang/rust#66246
7 participants