Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use deref target in Pin trait implementations #67039

Merged
merged 4 commits into from
Dec 10, 2019

Commits on Dec 5, 2019

  1. Use deref target in Pin trait implementations

    Using deref target instead of pointer itself avoids providing access to
    `&Rc<T>` for malicious implementations, which would allow calling
    `Rc::get_mut`.
    
    This is a breaking change necessary due to unsoundness, however
    the impact of it should be minimal.
    
    This only fixes the issue with malicious `PartialEq` implementations,
    other `Pin` soundness issues are still here.
    
    See <https://internals.rust-lang.org/t/unsoundness-in-pin/11311/73>
    for more details.
    KamilaBorowska committed Dec 5, 2019
    Configuration menu
    Copy the full SHA
    1cf0db1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    dfcf764 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6996ae1 View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2019

  1. Configuration menu
    Copy the full SHA
    61d9c00 View commit details
    Browse the repository at this point in the history