Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge TraitItem & ImplItem into AssocItem` #67131

Merged
merged 26 commits into from
Dec 20, 2019
Merged

Merge TraitItem & ImplItem into AssocItem` #67131

merged 26 commits into from
Dec 20, 2019

Commits on Dec 12, 2019

  1. Alias TraitItem & ImplItem. 

    Allow defaultness on trait items syntactically.
    @Centril
    Centril committed Dec 12, 2019
    Configuration menu
    Copy the full SHA
    c4bbe9c View commit details
    Browse the repository at this point in the history

  2. Use Option in ImplItemKind::Const.

    @Centril
    Centril committed Dec 12, 2019
    Configuration menu
    Copy the full SHA
    73557fa View commit details
    Browse the repository at this point in the history

  3. Use Option in ImplItemKind::Method.

    @Centril
    Centril committed Dec 12, 2019
    Configuration menu
    Copy the full SHA
    f6403c6 View commit details
    Browse the repository at this point in the history

  4. TraitItemKind::Type -> TraitItemKind::TyAlias.

    @Centril
    Centril committed Dec 12, 2019
    Configuration menu
    Copy the full SHA
    c02fd31 View commit details
    Browse the repository at this point in the history

  5. Unify {Trait,Impl}ItemKind::TyAlias structures.

    @Centril
    Centril committed Dec 12, 2019
    Configuration menu
    Copy the full SHA
    3907376 View commit details
    Browse the repository at this point in the history

  6. Unify {Impl,Trait}Item as AssocItem.

    @Centril
    Centril committed Dec 12, 2019
    Configuration menu
    Copy the full SHA
    92a372b View commit details
    Browse the repository at this point in the history

  7. Fuse associated constant parsing.

    @Centril
    Centril committed Dec 12, 2019
    Configuration menu
    Copy the full SHA
    2d92aa5 View commit details
    Browse the repository at this point in the history

  8. Fuse associated type parsing.

    @Centril
    Centril committed Dec 12, 2019
    Configuration menu
    Copy the full SHA
    10270bc View commit details
    Browse the repository at this point in the history

  9. Unify associated function parsing.

    @Centril
    Centril committed Dec 12, 2019
    Configuration menu
    Copy the full SHA
    7672bff View commit details
    Browse the repository at this point in the history

  10. Unify associated item parsing. 

    An exception is `fn` params.
    @Centril
    Centril committed Dec 12, 2019
    Configuration menu
    Copy the full SHA
    63a9030 View commit details
    Browse the repository at this point in the history

  11. Relocate is_const_item.

    @Centril
    Centril committed Dec 12, 2019
    Configuration menu
    Copy the full SHA
    fa828d7 View commit details
    Browse the repository at this point in the history

  12. Leave a FIXME re. allow_plus.

    @Centril
    Centril committed Dec 12, 2019
    Configuration menu
    Copy the full SHA
    404013e View commit details
    Browse the repository at this point in the history

  13. parse: refactor fun ret ty & param ty

    @Centril
    Centril committed Dec 12, 2019
    Configuration menu
    Copy the full SHA
    34d9170 View commit details
    Browse the repository at this point in the history

  14. Unify associated item pretty printing.

    @Centril
    Centril committed Dec 12, 2019
    Configuration menu
    Copy the full SHA
    9193d7a View commit details
    Browse the repository at this point in the history

  15. Unify associated item mut visitors.

    @Centril
    Centril committed Dec 12, 2019
    Configuration menu
    Copy the full SHA
    76576d4 View commit details
    Browse the repository at this point in the history

  16. Simplify nt_to_tokenstream.

    @Centril
    Centril committed Dec 12, 2019
    Configuration menu
    Copy the full SHA
    c6c17e3 View commit details
    Browse the repository at this point in the history

  17. Unify associated item visitor.

    @Centril
    Centril committed Dec 12, 2019
    Configuration menu
    Copy the full SHA
    0d8a9d7 View commit details
    Browse the repository at this point in the history

  18. Unify associated item parsing more.

    @Centril
    Centril committed Dec 12, 2019
    Configuration menu
    Copy the full SHA
    51ccdeb View commit details
    Browse the repository at this point in the history

  19. Unify assoc item visitors more.

    @Centril
    Centril committed Dec 12, 2019
    Configuration menu
    Copy the full SHA
    b499a88 View commit details
    Browse the repository at this point in the history

  20. Move allow_c_varadic logic to ast_validation.

    @Centril
    Centril committed Dec 12, 2019
    Configuration menu
    Copy the full SHA
    0d41d0f View commit details
    Browse the repository at this point in the history

  21. ast_validation: move trait item logic to proper place.

    @Centril
    Centril committed Dec 12, 2019
    Configuration menu
    Copy the full SHA
    3a57a2c View commit details
    Browse the repository at this point in the history

  22. More c-variadic errors as semantic restrictions.

    @Centril
    Centril committed Dec 12, 2019
    Configuration menu
    Copy the full SHA
    35e9e09 View commit details
    Browse the repository at this point in the history

  23. Remove ast::{Impl,Trait}{Item,ItemKind}.

    @Centril
    Centril committed Dec 12, 2019
    Configuration menu
    Copy the full SHA
    abf2e7a View commit details
    Browse the repository at this point in the history

  24. AssocImplKind::{Method -> Fn}.

    @Centril
    Centril committed Dec 12, 2019
    Configuration menu
    Copy the full SHA
    e52f902 View commit details
    Browse the repository at this point in the history

  25. De-fatalize ... parsing. 

    Also fix error the code description.
    @Centril
    Centril committed Dec 12, 2019
    Configuration menu
    Copy the full SHA
    74d4fbc View commit details
    Browse the repository at this point in the history

  26. make visitor uses more robust

    @Centril
    Centril committed Dec 12, 2019
    Configuration menu
    Copy the full SHA
    054458b View commit details
    Browse the repository at this point in the history