Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warnings for missing documentations. #6715

Merged
merged 2 commits into from
May 27, 2013
Merged

Conversation

Xazax-hun
Copy link
Contributor

Preliminary implementation for: #6275

This is my first (non hello world) rust code, so it may not be idiomatic.

@thestinger
Copy link
Contributor

This is a nice idea :). I think it should only be triggered on public functions/methods/fields though.

@Xazax-hun
Copy link
Contributor Author

I was thinking about the same :)

@steveklabnik
Copy link
Member

I like this idea, but right now, it'd throw so many warnings as to obscure everything else.

I do think that right now, it'd be good to have this available as some sort of report.

@Xazax-hun
Copy link
Contributor Author

Maybe add a feature to lint to be able to redirect certain kind of warnings to a file?

The amount of warnings is the reason why it is turned off by default.

@steveklabnik
Copy link
Member

That seems really complex, though I'd like for someone from Mozilla to weigh in here.

@thestinger
Copy link
Contributor

@steveklabnik: we can enable this module-by-module

@graydon
Copy link
Contributor

graydon commented May 27, 2013

Yeah, I'm ok with this. We accepted it as a part of arriving at the "well covered" milestone (i.e. "having enough machinery around to measure production-readiness"). We don't have to have it turned on by default. It's a tool.

Thanks!

bors added a commit that referenced this pull request May 27, 2013
Preliminary implementation for: #6275

This is my first (non hello world) rust code, so it may not be idiomatic.
@bors bors closed this May 27, 2013
@bors bors merged commit 3d61931 into rust-lang:incoming May 27, 2013
flip1995 pushed a commit to flip1995/rust that referenced this pull request Mar 11, 2021
…r=camsteffen

added new lint `owned_to_owned`

Adding new lint `owned_to_owned`

Creating draft PR to have this looked over.
I think this takes all advice I received into account.

I did have to update the `redundant_clone` test to ignore this lint -- I felt that was the safest action.

closes: rust-lang#6715
changelog: added new lint `implicit_clone`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants