-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the DelimSpan
from NamedMatch::MatchedSeq
.
#67250
Remove the DelimSpan
from NamedMatch::MatchedSeq
.
#67250
Conversation
Because it's unused. This then allows the removal of `MatcherPos::sp_open`. It's a tiny perf win, reducing instruction counts by 0.1% - 0.2% on a few benchmarks.
I found this by profiling For a Here is one of the DHAT records. There were two other very similar ones.
|
@bors r+ |
📌 Commit ffd2142 has been approved by |
…Match-MatchedSeq, r=Centril Remove the `DelimSpan` from `NamedMatch::MatchedSeq`. Because it's unused. This then allows the removal of `MatcherPos::sp_open`. It's a tiny perf win, reducing instruction counts by 0.1% - 0.2% on a few benchmarks. r? @Centril
…Match-MatchedSeq, r=Centril Remove the `DelimSpan` from `NamedMatch::MatchedSeq`. Because it's unused. This then allows the removal of `MatcherPos::sp_open`. It's a tiny perf win, reducing instruction counts by 0.1% - 0.2% on a few benchmarks. r? @Centril
Rollup of 6 pull requests Successful merges: - #66341 (Match `VecDeque::extend` to `Vec::extend_desugared`) - #67243 (LinkedList: drop remaining items when drop panics) - #67247 (Don't suggest wrong snippet in closure) - #67250 (Remove the `DelimSpan` from `NamedMatch::MatchedSeq`.) - #67251 (Require `allow_internal_unstable` for stable min_const_fn using unsta…) - #67269 (parser: recover on `&'lifetime mut? $pat`.) Failed merges: r? @ghost
Because it's unused. This then allows the removal of
MatcherPos::sp_open
. It's a tiny perf win, reducing instruction countsby 0.1% - 0.2% on a few benchmarks.
r? @Centril