Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove i686-unknown-dragonfly target #67255

Merged
merged 1 commit into from
Dec 15, 2019

Conversation

tuxillo
Copy link
Contributor

@tuxillo tuxillo commented Dec 12, 2019

DragonFly BSD removed support for i386 a while ago. It only supports x86_64 right now.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 12, 2019
@tuxillo
Copy link
Contributor Author

tuxillo commented Dec 12, 2019

In reference to rust-lang/rust-forge#287
Not sure if I've missed anything, let me know and I'll refresh the PR.

@rust-highfive
Copy link
Collaborator

The job mingw-check of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-12-12T15:26:47.6346571Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-12-12T15:26:47.6565442Z ##[command]git config gc.auto 0
2019-12-12T15:26:47.6577191Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-12-12T15:26:47.6631335Z ##[command]git config --get-all http.proxy
2019-12-12T15:26:47.6757337Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/67255/merge:refs/remotes/pull/67255/merge
---
2019-12-12T15:33:23.1877964Z     Checking rustc_feature v0.0.0 (/checkout/src/librustc_feature)
2019-12-12T15:33:23.1886448Z error[E0583]: file not found for module `i686_unknown_dragonfly`
2019-12-12T15:33:23.1887057Z    --> src/librustc_target/spec/mod.rs:401:32
2019-12-12T15:33:23.1887272Z     |
2019-12-12T15:33:23.1887571Z 401 |     ("i686-unknown-dragonfly", i686_unknown_dragonfly),
2019-12-12T15:33:23.1888089Z     |
2019-12-12T15:33:23.1888089Z     |
2019-12-12T15:33:23.1888429Z     = help: name the file either i686_unknown_dragonfly.rs or i686_unknown_dragonfly/mod.rs inside the directory "src/librustc_target/spec"
2019-12-12T15:33:23.1888731Z error: aborting due to previous error
2019-12-12T15:33:23.1888764Z 
2019-12-12T15:33:23.1889017Z For more information about this error, try `rustc --explain E0583`.
2019-12-12T15:33:23.1889264Z error: could not compile `rustc_target`.
---
2019-12-12T15:33:23.4814283Z   local time: Thu Dec 12 15:33:23 UTC 2019
2019-12-12T15:33:23.6325753Z   network time: Thu, 12 Dec 2019 15:33:23 GMT
2019-12-12T15:33:23.6332000Z == end clock drift check ==
2019-12-12T15:33:25.6883563Z 
2019-12-12T15:33:25.6940217Z ##[error]Bash exited with code '1'.
2019-12-12T15:33:25.6968577Z ##[section]Starting: Checkout
2019-12-12T15:33:25.6970096Z ==============================================================================
2019-12-12T15:33:25.6970146Z Task         : Get sources
2019-12-12T15:33:25.6970208Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@tuxillo tuxillo force-pushed the remove-i686-unknown-dragonfly branch from d74b01b to 0f47327 Compare December 12, 2019 16:27
@Centril Centril added relnotes Marks issues that should be documented in the release notes of the next release. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 12, 2019
@Centril Centril added this to the 1.41 milestone Dec 12, 2019
@alexcrichton
Copy link
Member

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented Dec 12, 2019

📌 Commit 0f47327 has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 12, 2019
Centril added a commit to Centril/rust that referenced this pull request Dec 12, 2019
…ly, r=alexcrichton

Remove i686-unknown-dragonfly target

DragonFly BSD removed support for i386 a while ago. It only supports x86_64 right now.
Centril added a commit to Centril/rust that referenced this pull request Dec 13, 2019
…ly, r=alexcrichton

Remove i686-unknown-dragonfly target

DragonFly BSD removed support for i386 a while ago. It only supports x86_64 right now.
Centril added a commit to Centril/rust that referenced this pull request Dec 14, 2019
…ly, r=alexcrichton

Remove i686-unknown-dragonfly target

DragonFly BSD removed support for i386 a while ago. It only supports x86_64 right now.
bors added a commit that referenced this pull request Dec 14, 2019
Rollup of 5 pull requests

Successful merges:

 - #67151 (doc comments: Less attribute mimicking)
 - #67216 (Enable `loop` and `while` in constants behind a feature flag)
 - #67255 (Remove i686-unknown-dragonfly target)
 - #67267 (Fix signature of `__wasilibc_find_relpath`)
 - #67282 (Fix example code of OpenOptions::open)

Failed merges:

r? @ghost
Centril added a commit to Centril/rust that referenced this pull request Dec 15, 2019
…ly, r=alexcrichton

Remove i686-unknown-dragonfly target

DragonFly BSD removed support for i386 a while ago. It only supports x86_64 right now.
bors added a commit that referenced this pull request Dec 15, 2019
Rollup of 6 pull requests

Successful merges:

 - #67255 (Remove i686-unknown-dragonfly target)
 - #67267 (Fix signature of `__wasilibc_find_relpath`)
 - #67282 (Fix example code of OpenOptions::open)
 - #67289 (Do not ICE on unnamed future)
 - #67300 (Restore original implementation of Vec::retain)
 - #67305 (Doc typo)

Failed merges:

r? @ghost
@bors bors merged commit 0f47327 into rust-lang:master Dec 15, 2019
@tuxillo tuxillo deleted the remove-i686-unknown-dragonfly branch December 15, 2019 12:20
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Feb 17, 2020
Version 1.41.0 (2020-01-30)
===========================

Language
--------

- [You can now pass type parameters to foreign items when implementing
  traits.][65879] E.g. You can now write `impl<T> From<Foo> for Vec<T> {}`.
- [You can now arbitrarily nest receiver types in the `self` position.][64325] E.g. you can
  now write `fn foo(self: Box<Box<Self>>) {}`. Previously only `Self`, `&Self`,
  `&mut Self`, `Arc<Self>`, `Rc<Self>`, and `Box<Self>` were allowed.
- [You can now use any valid identifier in a `format_args` macro.][66847]
  Previously identifiers starting with an underscore were not allowed.
- [Visibility modifiers (e.g. `pub`) are now syntactically allowed on trait items and
  enum variants.][66183] These are still rejected semantically, but
  can be seen and parsed by procedural macros and conditional compilation.

Compiler
--------

- [Rustc will now warn if you have unused loop `'label`s.][66325]
- [Removed support for the `i686-unknown-dragonfly` target.][67255]
- [Added tier 3 support\* for the `riscv64gc-unknown-linux-gnu` target.][66661]
- [You can now pass an arguments file passing the `@path` syntax
  to rustc.][66172] Note that the format differs somewhat from what is
  found in other tooling; please see [the documentation][argfile-docs] for
  more information.
- [You can now provide `--extern` flag without a path, indicating that it is
  available from the search path or specified with an `-L` flag.][64882]

\* Refer to Rust's [platform support page][forge-platform-support] for more
information on Rust's tiered platform support.

[argfile-docs]: https://doc.rust-lang.org/nightly/rustc/command-line-arguments.html#path-load-command-line-flags-from-a-path

Libraries
---------

- [The `core::panic` module is now stable.][66771] It was already stable
  through `std`.
- [`NonZero*` numerics now implement `From<NonZero*>` if it's a smaller integer
  width.][66277] E.g. `NonZeroU16` now implements `From<NonZeroU8>`.
- [`MaybeUninit<T>` now implements `fmt::Debug`.][65013]

Stabilized APIs
---------------

- [`Result::map_or`]
- [`Result::map_or_else`]
- [`std::rc::Weak::weak_count`]
- [`std::rc::Weak::strong_count`]
- [`std::sync::Weak::weak_count`]
- [`std::sync::Weak::strong_count`]

Cargo
-----

- [Cargo will now document all the private items for binary crates
  by default.][cargo/7593]
- [`cargo-install` will now reinstall the package if it detects that it is out
  of date.][cargo/7560]
- [Cargo.lock now uses a more git friendly format that should help to reduce
  merge conflicts.][cargo/7579]
- [You can now override specific dependencies's build settings][cargo/7591] E.g.
  `[profile.dev.overrides.image] opt-level = 2` sets the `image` crate's
  optimisation level to `2` for debug builds. You can also use
  `[profile.<profile>.build_overrides]` to override build scripts and
  their dependencies.

Misc
----

- [You can now specify `edition` in documentation code blocks to compile the block
  for that edition.][66238] E.g. `edition2018` tells rustdoc that the code sample
  should be compiled the 2018 edition of Rust.
- [You can now provide custom themes to rustdoc with `--theme`, and check the
  current theme with `--check-theme`.][54733]
- [You can use `#[cfg(doc)]` to compile an item when building documentation.][61351]

Compatibility Notes
-------------------

- [As previously announced 1.41.0 will be the last tier 1 release for 32-bit
  Apple targets.][apple-32bit-drop] This means that the source code is still
  available to build, but the targets are no longer being tested and release
  binaries for those platforms will no longer be distributed by the Rust project.
  Please refer to the linked blog post for more information.

[54733]: rust-lang/rust#54733
[61351]: rust-lang/rust#61351
[67255]: rust-lang/rust#67255
[66661]: rust-lang/rust#66661
[66771]: rust-lang/rust#66771
[66847]: rust-lang/rust#66847
[66238]: rust-lang/rust#66238
[66277]: rust-lang/rust#66277
[66325]: rust-lang/rust#66325
[66172]: rust-lang/rust#66172
[66183]: rust-lang/rust#66183
[65879]: rust-lang/rust#65879
[65013]: rust-lang/rust#65013
[64882]: rust-lang/rust#64882
[64325]: rust-lang/rust#64325
[cargo/7560]: rust-lang/cargo#7560
[cargo/7579]: rust-lang/cargo#7579
[cargo/7591]: rust-lang/cargo#7591
[cargo/7593]: rust-lang/cargo#7593
[`Result::map_or_else`]: https://doc.rust-lang.org/std/result/enum.Result.html#method.map_or_else
[`Result::map_or`]: https://doc.rust-lang.org/std/result/enum.Result.html#method.map_or
[`std::rc::Weak::weak_count`]: https://doc.rust-lang.org/std/rc/struct.Weak.html#method.weak_count
[`std::rc::Weak::strong_count`]: https://doc.rust-lang.org/std/rc/struct.Weak.html#method.strong_count
[`std::sync::Weak::weak_count`]: https://doc.rust-lang.org/std/sync/struct.Weak.html#method.weak_count
[`std::sync::Weak::strong_count`]: https://doc.rust-lang.org/std/sync/struct.Weak.html#method.strong_count
[apple-32bit-drop]: https://blog.rust-lang.org/2020/01/03/reducing-support-for-32-bit-apple-targets.html
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants