Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix src/libcore/str/mod.rs doc comments #67478

Merged
merged 1 commit into from
Dec 21, 2019
Merged

Fix src/libcore/str/mod.rs doc comments #67478

merged 1 commit into from
Dec 21, 2019

Conversation

brunobell
Copy link
Contributor

@brunobell brunobell commented Dec 21, 2019 •
edited
Loading

Fix grammar in src/libcore/str/mod.rs doc comments. r? @steveklabnik

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @kennytm (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 21, 2019
@kennytm kennytm assigned steveklabnik and unassigned kennytm Dec 21, 2019
@kennytm kennytm closed this Dec 21, 2019
@kennytm kennytm reopened this Dec 21, 2019
@Centril
Copy link
Contributor

Centril commented Dec 21, 2019

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Dec 21, 2019

📌 Commit 16b7fd2 has been approved by Centril

@bors
Copy link
Contributor

bors commented Dec 21, 2019

🌲 The tree is currently closed for pull requests below priority 100, this pull request will be tested once the tree is reopened

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 21, 2019
Centril added a commit to Centril/rust that referenced this pull request Dec 21, 2019
@Centril
Rollup merge of rust-lang#67478 - brunobell:master, r=Centril
466fdea 
Fix src/libcore/str/mod.rs doc comments

Fix grammar in src/libcore/str/mod.rs doc comments. r? @steveklabnik
@Centril Centril mentioned this pull request Dec 21, 2019
Merged
bors added a commit that referenced this pull request Dec 21, 2019
@bors
Auto merge of #67485 - Centril:rollup-gt0opvr, r=Centril
0a440b1 
Rollup of 7 pull requests

Successful merges:

 - #67059 (Fix too restrictive checks on Drop impls)
 - #67355 (Merge `ast::Mutability` and `mir::Mutability`)
 - #67393 (Enable opting out of specific default LLVM arguments.)
 - #67422 (Cleanup err codes)
 - #67462 (Make ptr::slice_from_raw_parts a const fn available under a feature flag)
 - #67467 (Test slice patterns more)
 - #67478 (Fix src/libcore/str/mod.rs doc comments)

Failed merges:

r? @ghost
@bors bors merged commit 16b7fd2 into rust-lang:master Dec 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@steveklabnik steveklabnik

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@brunobell @rust-highfive @Centril @bors @steveklabnik @kennytm