Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Clippy and cargo #67528

Closed
wants to merge 3 commits into from
Closed

Update Clippy and cargo #67528

wants to merge 3 commits into from

Conversation

flip1995
Copy link
Member

@flip1995 flip1995 commented Dec 22, 2019

No issue was opened for this breakage.

Fixes #67541

r? @Manishearth

@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 22, 2019
@Manishearth
Copy link
Member

@bors r+ p=2

@bors
Copy link
Contributor

bors commented Dec 22, 2019

📌 Commit 30f727ccdc42ebd9ac7d22c94b44280acc59d1b7 has been approved by Manishearth

@bors
Copy link
Contributor

bors commented Dec 22, 2019

🌲 The tree is currently closed for pull requests below priority 100, this pull request will be tested once the tree is reopened

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 22, 2019
@JohnTitor
Copy link
Member

@flip1995 Could you include rust-lang/rust-clippy@2a76cd8?

@flip1995
Copy link
Member Author

flip1995 commented Dec 23, 2019

Done. Updating to the current clippy master is blocked on rust-lang/cargo#7706 and a simultaneous update of cargo and clippy.

I can do this in this PR, once rust-lang/cargo#7706 is merged or in a separate PR.

@flip1995 flip1995 changed the title Update Clippy Update Clippy and cargo Dec 23, 2019
@JohnTitor
Copy link
Member

@flip1995 Sorry to ping again, but could you include latest rustup of Clippy? Then this is r+ed again so that we can fix the toolstate.

@flip1995
Copy link
Member Author

Sorry I was away for Christmas. Thanks for taking over!

Closing in favor of #67661

@flip1995 flip1995 closed this Dec 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

clippy-driver no longer builds after rust-lang/rust#67532
5 participants