Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some keyword documentation. #67622

Merged
merged 1 commit into from
Dec 30, 2019
Merged

Some keyword documentation. #67622

merged 1 commit into from
Dec 30, 2019

Conversation

gilescope
Copy link
Contributor

I thought about going into detail, but I'd much rather route them to the async book asap.

@rust-highfive
Copy link
Collaborator

r? @sfackler

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 25, 2019
Centril
Centril reviewed Dec 26, 2019
View reviewed changes
src/libstd/keyword_docs.rs Outdated Show resolved Hide resolved
src/libstd/keyword_docs.rs Outdated Show resolved Hide resolved
src/libstd/keyword_docs.rs Outdated Show resolved Hide resolved
@Centril
Copy link
Contributor

Centril commented Dec 26, 2019

r? @Centril

@rust-highfive rust-highfive assigned Centril and unassigned sfackler Dec 26, 2019
@gilescope
Copy link
Contributor Author

Have added a line on edition and stable version.

@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
2019-12-26T08:33:20.2513309Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-12-26T08:33:20.2715961Z ##[command]git config gc.auto 0
2019-12-26T08:33:21.1923120Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-12-26T08:33:21.1925713Z ##[command]git config --get-all http.proxy
2019-12-26T08:33:21.1928409Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/67622/merge:refs/remotes/pull/67622/merge

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@gilescope
Copy link
Contributor Author

( Fixes #66909 )

@Centril Centril closed this Dec 29, 2019
@Centril Centril reopened this Dec 29, 2019
@Centril
Copy link
Contributor

Centril commented Dec 29, 2019

PR builder seems unhappy?

@Centril
Copy link
Contributor

Centril commented Dec 29, 2019

r=me rollup when it is happy.

@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
2019-12-29T00:17:21.0001552Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-12-29T00:17:21.0184891Z ##[command]git config gc.auto 0
2019-12-29T00:17:21.0250653Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-12-29T00:17:21.0304286Z ##[command]git config --get-all http.proxy
2019-12-29T00:17:21.0443004Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/67622/merge:refs/remotes/pull/67622/merge

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@Centril
Copy link
Contributor

Centril commented Dec 29, 2019

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Dec 29, 2019

📌 Commit bc1b2d5 has been approved by Centril

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 29, 2019
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Dec 30, 2019
@JohnTitor
Rollup merge of rust-lang#67622 - gilescope:async-keyword-doc, r=Centril
0eb19dc 
Some keyword documentation.

I thought about going into detail, but I'd much rather route them to the async book asap.
@JohnTitor JohnTitor mentioned this pull request Dec 30, 2019
Merged
bors added a commit that referenced this pull request Dec 30, 2019
@bors
Auto merge of #67721 - JohnTitor:rollup-o8zm4r9, r=JohnTitor
d297b19 
Rollup of 10 pull requests

Successful merges:

 - #64273 (Stabilize attribute macros on inline modules)
 - #67287 (typeck: note other end-point when checking range pats)
 - #67564 (docs: Iterator adapters have unspecified results after a panic)
 - #67622 (Some keyword documentation.)
 - #67657 (Clean up const-hack PRs now that const if / match exist.)
 - #67677 (resolve: Minor cleanup of duplicate macro reexports)
 - #67687 (Do not ICE on lifetime error involving closures)
 - #67698 (Move reachable_set and diagnostic_items to librustc_passes.)
 - #67701 (tidy: Enforce formatting rather than just check it if `--bless` is specified)
 - #67715 (Typo fix)

Failed merges:

r? @ghost
@bors bors merged commit bc1b2d5 into rust-lang:master Dec 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Centril Centril Centril left review comments

Assignees

@Centril Centril

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gilescope @rust-highfive @Centril @bors @sfackler