Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make use of pointer::is_null #67666

Merged
merged 1 commit into from
Jan 11, 2020
Merged

make use of pointer::is_null #67666

merged 1 commit into from
Jan 11, 2020

Conversation

tesuji
Copy link
Contributor

@tesuji tesuji commented Dec 27, 2019

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 27, 2019
@rust-highfive
Copy link
Collaborator

The job mingw-check of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-12-27T17:59:28.2907689Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-12-27T17:59:28.3105633Z ##[command]git config gc.auto 0
2019-12-27T17:59:28.3190420Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-12-27T17:59:28.3239923Z ##[command]git config --get-all http.proxy
2019-12-27T17:59:28.3384464Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/67666/merge:refs/remotes/pull/67666/merge
---
2019-12-27T18:05:10.7779295Z     Checking panic_unwind v0.0.0 (/checkout/src/libpanic_unwind)
2019-12-27T18:05:14.0589541Z error[E0614]: type `bool` cannot be dereferenced
2019-12-27T18:05:14.0590884Z    --> src/libstd/sys/unix/os.rs:483:38
2019-12-27T18:05:14.0591511Z     |
2019-12-27T18:05:14.0592172Z 483 |         while !environ.is_null() && !*environ.is_null() {
2019-12-27T18:05:14.0593172Z 
2019-12-27T18:05:14.1918123Z error: aborting due to previous error
2019-12-27T18:05:14.1919042Z 
2019-12-27T18:05:14.1919713Z For more information about this error, try `rustc --explain E0614`.
---
2019-12-27T18:05:14.2169836Z   local time: Fri Dec 27 18:05:14 UTC 2019
2019-12-27T18:05:14.5116008Z   network time: Fri, 27 Dec 2019 18:05:14 GMT
2019-12-27T18:05:14.5121499Z == end clock drift check ==
2019-12-27T18:05:22.6826003Z 
2019-12-27T18:05:22.6950794Z ##[error]Bash exited with code '1'.
2019-12-27T18:05:22.6983995Z ##[section]Starting: Checkout
2019-12-27T18:05:22.6986033Z ==============================================================================
2019-12-27T18:05:22.6986123Z Task         : Get sources
2019-12-27T18:05:22.6986176Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@tesuji tesuji force-pushed the ptr-null-cmp branch 3 times, most recently from e0fc567 to ef74bc2 Compare December 31, 2019 14:09
@tesuji
Copy link
Contributor Author

tesuji commented Jan 2, 2020

r? @Centril

@Centril
Copy link
Contributor

Centril commented Jan 9, 2020

r? @rkruppe

@rust-highfive rust-highfive assigned hanna-kruppe and unassigned Centril Jan 9, 2020
Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This is great.

@dtolnay
Copy link
Member

dtolnay commented Jan 10, 2020

r? dtolnay
@bors r+

@bors
Copy link
Contributor

bors commented Jan 10, 2020

📌 Commit ef74bc2 has been approved by dtolnay

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 10, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Jan 10, 2020
Centril added a commit to Centril/rust that referenced this pull request Jan 10, 2020
Centril added a commit to Centril/rust that referenced this pull request Jan 10, 2020
@tesuji
Copy link
Contributor Author

tesuji commented Jan 10, 2020

Removed unused ptr imports in hermit, vxworks and wasi.

@Dylan-DPC-zz
Copy link

@bors r-
(failed in rollup #68087)

@bors bors removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 10, 2020
@bors bors added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jan 10, 2020
@tesuji
Copy link
Contributor Author

tesuji commented Jan 10, 2020

I pushed the new changes. Could be re-reviewed?

@dtolnay dtolnay assigned dtolnay and unassigned hanna-kruppe Jan 10, 2020
@dtolnay
Copy link
Member

dtolnay commented Jan 10, 2020

@bors r+

@bors
Copy link
Contributor

bors commented Jan 10, 2020

📌 Commit cd9a73d has been approved by dtolnay

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 10, 2020
Centril added a commit to Centril/rust that referenced this pull request Jan 11, 2020
bors added a commit that referenced this pull request Jan 11, 2020
Rollup of 8 pull requests

Successful merges:

 - #67666 (make use of pointer::is_null)
 - #67806 (Extract `rustc_ast_passes`, move gating, & refactor linting)
 - #68043 (Add some missing timers)
 - #68074 (Add `llvm-skip-rebuild` flag to `x.py`)
 - #68079 (Clarify suggestion for E0013)
 - #68084 (Do not ICE on unicode next point)
 - #68102 (Inline some conversion methods around OsStr)
 - #68106 (Fix issue with using `self` module via indirection)

Failed merges:

r? @ghost
@bors
Copy link
Contributor

bors commented Jan 11, 2020

☔ The latest upstream changes (presumably #68115) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 11, 2020
@bors bors merged commit cd9a73d into rust-lang:master Jan 11, 2020
@tesuji tesuji deleted the ptr-null-cmp branch January 11, 2020 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants