Remove appendix from Apache license #67734
Conversation
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
XAMPPRocky
changed the title
|
r? @skade would you be ok taking a look at this? |
|
Not sure why I can't assign to @skade, they should be somewhere in the Rust org I feel. I've pinged them on Discord. |
|
This is unproblematic and makes sense. The license itself states:
Of which the Appendix is not a part. It makes sense to remove it. It may also confuse people, as we don't apply the license the way it is proposed in there. |
|
@Mark-Simulacrum Looking at |
|
@bors r=skade |
|
📌 Commit 2ccf65c has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 2ccf65c with merge 658e0817734367860daca4f8e9f8310f14861399... |
|
Your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem. Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
💔 Test failed - checks-azure |
bors
added
S-waiting-on-review
|
@bors retry install of msys2 was NOT successful |
bors
added
S-waiting-on-bors
|
@bors rollup=always |
Remove appendix from Apache license Looking at the codebase I noticed an oddity, in that the appendix of how use the Apache licence is still contained in the licence file. We don't put licence headers at the top of all of our files so I don't think we need to keep this. Alternatively we could delete everything above line 191 to have a shorter licence file.
Rollup of 8 pull requests Successful merges: - #67734 (Remove appendix from Apache license) - #67795 (Cleanup formatting code) - #68290 (Fix some tests failing in `--pass check` mode) - #68297 ( Filter and test predicates using `normalize_and_test_predicates` for const-prop) - #68302 (Fix #[track_caller] and function pointers) - #68339 (Add `riscv64gc-unknown-linux-gnu` into target list in build-manifest) - #68381 (Added minor clarification to specification of GlobalAlloc::realloc.) - #68397 (rustdoc: Correct order of `async` and `unsafe` in `async unsafe fn`s) Failed merges: r? @ghost
This change is to be consistent with rust-lang/rust. Their change was made in January 2020. The PR over there: [Remove appendix from LICENCE-APACHE](rust-lang/rust#67734)
Removed Apache License appendix Related issues: #2660; rust-lang/rust#67734
Removed Apache License appendix Related issues: #2660; rust-lang/rust#67734
This change is to be consistent with rust-lang/rust. Their change was made in January 2020. The PR over there: [Remove appendix from LICENCE-APACHE](rust-lang/rust#67734)
internal: Drop Apache license appendices Closes #14586 Similar to rust-lang/rust#67734
internal: Drop Apache license appendices Closes rust-lang#14586 Similar to rust-lang#67734
Looking at the codebase I noticed an oddity, in that the appendix of how use the Apache licence is still contained in the licence file. We don't put licence headers at the top of all of our files so I don't think we need to keep this. Alternatively we could delete everything above line 191 to have a shorter licence file.