Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use drop instead of the toilet closure |_| () #67807

Merged
merged 1 commit into from
Jan 3, 2020

Conversation

tesuji
Copy link
Contributor

@tesuji tesuji commented Jan 2, 2020

No description provided.

@rust-highfive
Copy link
Collaborator

r? @sfackler

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 2, 2020
@Centril
Copy link
Contributor

Centril commented Jan 2, 2020

Looks like we're flushing the closures down the 🚽.

r? @Centril @bors r+ rollup

@bors
Copy link
Contributor

bors commented Jan 2, 2020

📌 Commit dd8f072 has been approved by Centril

@rust-highfive rust-highfive assigned Centril and unassigned sfackler Jan 2, 2020
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 2, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Jan 2, 2020
Use drop instead of the toilet closure `|_| ()`
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Jan 2, 2020
Use drop instead of the toilet closure `|_| ()`
bors added a commit that referenced this pull request Jan 2, 2020
Rollup of 5 pull requests

Successful merges:

 - #67636 (allow rustfmt key in [build] section)
 - #67736 (Less-than is asymmetric, not antisymmetric)
 - #67762 (Add missing links for insecure_time)
 - #67777 (Use self profile infrastructure for -Z time and -Z time-passes)
 - #67807 (Use drop instead of the toilet closure `|_| ()`)

Failed merges:

r? @ghost
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Jan 3, 2020
Use drop instead of the toilet closure `|_| ()`
bors added a commit that referenced this pull request Jan 3, 2020
Rollup of 10 pull requests

Successful merges:

 - #67450 (Allow for setting a ThinLTO import limit during bootstrap)
 - #67595 (Suggest adding a lifetime constraint for opaque type)
 - #67636 (allow rustfmt key in [build] section)
 - #67736 (Less-than is asymmetric, not antisymmetric)
 - #67762 (Add missing links for insecure_time)
 - #67783 (Warn for bindings named same as variants when matching against a borrow)
 - #67796 (Ensure that we process projections during MIR inlining)
 - #67807 (Use drop instead of the toilet closure `|_| ()`)
 - #67816 (Clean up err codes)
 - #67825 (Minor: change take() docs grammar to match other docs)

Failed merges:

r? @ghost
@bors bors merged commit dd8f072 into rust-lang:master Jan 3, 2020
@tesuji tesuji deleted the toilet-closure branch January 3, 2020 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants