Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve some Drop-related error messages #67823

Merged
merged 2 commits into from
Jan 4, 2020
Merged

improve some Drop-related error messages #67823

merged 2 commits into from
Jan 4, 2020

Conversation

euclio
Copy link
Contributor

@euclio euclio commented Jan 3, 2020

No description provided.

@rust-highfive
Copy link
Collaborator

r? @petrochenkov

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 3, 2020
petrochenkov
petrochenkov reviewed Jan 3, 2020
View reviewed changes
src/librustc_typeck/check/dropck.rs Outdated Show resolved Hide resolved
src/librustc_typeck/check/dropck.rs Outdated Show resolved Hide resolved
@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 3, 2020
euclio added 2 commits January 3, 2020 17:57
@euclio
improve generic Drop error messages
e589358 
- Use the span of the predicate
- Use the def's description instead of "struct/enum" (notably incorrect
  for unions)
- Align formatting with other error messages
@euclio
clarify that Drop can be implemented for enums and unions too
e9990bc
@euclio euclio force-pushed the drop-improvements branch from 38ac816 to e9990bc Compare January 4, 2020 00:20
@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Jan 4, 2020

📌 Commit e9990bc has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 4, 2020
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jan 4, 2020
@GuillaumeGomez
Rollup merge of rust-lang#67823 - euclio:drop-improvements, r=petroch…
1140cee 
…enkov

improve some `Drop`-related error messages
@GuillaumeGomez GuillaumeGomez mentioned this pull request Jan 4, 2020
Merged
bors added a commit that referenced this pull request Jan 4, 2020
@bors
Auto merge of #67866 - GuillaumeGomez:rollup-32vsg5b, r=GuillaumeGomez
cd8377d 
Rollup of 4 pull requests

Successful merges:

 - #67822 (Revert `const_err` lint checking of casts)
 - #67823 (improve some `Drop`-related error messages)
 - #67837 (Clean up err codes)
 - #67848 (Remove unused `#[link_name = "m"]` attributes)

Failed merges:

r? @ghost
@bors bors merged commit e9990bc into rust-lang:master Jan 4, 2020
@euclio euclio deleted the drop-improvements branch January 4, 2020 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petrochenkov petrochenkov petrochenkov left review comments

Assignees

@petrochenkov petrochenkov

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@euclio @rust-highfive @petrochenkov @bors