mark glue functions with unnamed_addr #6787
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| pub fn SetLinkage(Global: ValueRef, Link: Linkage) { | ||
| unsafe { | ||
| llvm::LLVMSetLinkage(Global, Link as c_uint); | ||
| } | ||
| } | ||
|
|
||
| pub fn set_unnamed_addr(global: ValueRef, value: bool) { |
There was a problem hiding this comment.
Shouldn't this follow the same convention as all the other bindings? That is SetUnnamedAddr
There was a problem hiding this comment.
Well, that seems like a legacy wart since we're using that convention for types now. I'm open to changing it though if we really want to be using that convention.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Mar 11, 2021
tests: add test that roughly ensures that our lint messages conform with the diagnostics convention of the rustc dev guide lint message should not start with uppercase letters lint messages should not have punctuation at the end of the last line https://rustc-dev-guide.rust-lang.org/diagnostics.html#diagnostic-structure The test reads through all the .stderr files in the testsuit and checks lint messages that start with "help: ", "error: " etc. There is also an exception list for special messages that are deemed acceptable. changelog: make sure lint messages conform with the rustc dev guide and add test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't do anything with our current LLVM passes, but it's easy to do, and with
-mergefuncenabled it no longer has to output stubs to maintain addresses for each glue function.