Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing module std in example. #67943

Merged
merged 2 commits into from
Jan 7, 2020
Merged

Missing module std in example. #67943

merged 2 commits into from
Jan 7, 2020

Conversation

Stromberg90
Copy link
Contributor

No description provided.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @dtolnay (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 6, 2020
@jonas-schievink
Copy link
Contributor

The # use std::io; is now unnecessary, so you can remove that. Otherwise this looks good. Thanks!

@jonas-schievink
Copy link
Contributor

r? @jonas-schievink @bors r+ rollup

@bors
Copy link
Contributor

bors commented Jan 6, 2020

📌 Commit a852941 has been approved by jonas-schievink

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 6, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Jan 6, 2020
@Dylan-DPC
Rollup merge of rust-lang#67943 - Stromberg90:patch-1, r=jonas-schievink
f725e9f 
Missing module std in example.
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Jan 6, 2020
Closed
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Jan 7, 2020
@JohnTitor
Rollup merge of rust-lang#67943 - Stromberg90:patch-1, r=jonas-schievink
05797b1 
Missing module std in example.
@JohnTitor JohnTitor mentioned this pull request Jan 7, 2020
Merged
bors added a commit that referenced this pull request Jan 7, 2020
@bors
Auto merge of #67964 - JohnTitor:rollup-pu5kosl, r=JohnTitor
4f074de 
Rollup of 13 pull requests

Successful merges:

 - #67566 (Add an unstable conversion from thread ID to u64)
 - #67671 (Account for `type X = impl Trait;` in lifetime suggestion)
 - #67727 (Stabilise vec::remove_item)
 - #67877 (Omit underscore constants from rustdoc)
 - #67880 (Handle multiple error fix suggestions carefuly)
 - #67898 (Improve hygiene of `newtype_index`)
 - #67908 (rustdoc: HTML escape const values)
 - #67909 (Fix ICE in const pretty printing and resolve FIXME)
 - #67929 (Formatting an example for method Vec.retain)
 - #67934 (Clean up E0178 explanation)
 - #67936 (fire "non_camel_case_types" for associated types)
 - #67943 (Missing module std in example.)
 - #67962 (Update books)

Failed merges:

r? @ghost
@bors bors merged commit a852941 into rust-lang:master Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jonas-schievink jonas-schievink

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Stromberg90 @rust-highfive @jonas-schievink @bors @dtolnay