-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rustdoc: Don't allow #![feature(...)]
on stable or beta
#67989
Conversation
Thanks! Any way to add a test for this? |
That's a good question but I couldn't think of a good way to add a test. I couldn't find any similar tests for rustc either. I did make a beta build locally to test this though. |
This is a bit suboptimal. :-/ In the worst case, isn't possible to add a test running only on given kind of release? Maybe @Mark-Simulacrum would have an idea? |
I don't think so, at least not with today's compiler. We could make |
📌 Commit 4057199 has been approved by |
…meGomez rustdoc: Don't allow `#![feature(...)]` on stable or beta Fixes rust-lang#67647 r? @GuillaumeGomez
…meGomez rustdoc: Don't allow `#![feature(...)]` on stable or beta Fixes rust-lang#67647 r? @GuillaumeGomez
Rollup of 10 pull requests Successful merges: - #67854 (Use `report_in_external_macro` for internal lints) - #67989 (rustdoc: Don't allow `#![feature(...)]` on stable or beta) - #68036 (libterm: parse extended terminfo format) - #68127 (Clarify the relationship between `extended` and `tools` in `config.toml`) - #68143 (Forbid elided lifetimes within const generic parameter types) - #68150 (Document behavior of set_nonblocking on UnixListener) - #68166 (rustdoc: HTML escape arrows on help popup) - #68176 (Clean up err codes) - #68179 (Remove unneeded scope) - #68188 (Tweak assertion note in format check) Failed merges: r? @ghost
Beta backports - expect `fn` after `const unsafe` / `const extern` #68073 - Do not ICE on unicode next point #68084 - rustdoc: Don't allow `#![feature(...)]` on stable or beta #67989 r? @Mark-Simulacrum
Fix doc_target test which no longer works on stable/beta. rust-lang/rust#67989 changed it so that `#![feature]` requires nightly.
Fixes #67647
r? @GuillaumeGomez