perf: Only search potentially changed constraints in lexical_region_resolve #68001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @davidtwco (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
@bors try @rust-timer queue |
|
Awaiting bors try build completion |
bors
added a commit
that referenced
this pull request
Jan 8, 2020
perf: Only search potentially changed constraints in lexical_region_resolve Gives a big performance increase to the unicode_normalization benchmark in my testing.
|
☀️ Try build successful - checks-azure |
|
Queued fe4e15c with parent f48e576, future comparison URL. |
|
Finished benchmarking try commit fe4e15c, comparison URL. |
nikomatsakis
approved these changes
Jan 8, 2020
|
@bors r+ |
|
📌 Commit d9f3888 has been approved by |
bors
added
S-waiting-on-bors
|
@bors rollup=never |
|
☔ The latest upstream changes (presumably #68034) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
S-waiting-on-author
Should reduce the number of elements as well as branches in the extremely hot loop and process_constraint in benchmarks such as unicode_normalization
Marwes
force-pushed
the
lexical_region_resolve
branch
from
d9f3888
to
917eb18
Compare
|
Rebased to fix conflicts |
|
@bors r+ |
|
📌 Commit 917eb18 has been approved by |
bors
removed
the
S-waiting-on-author
bors
added
the
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Jan 18, 2020
perf: Only search potentially changed constraints in lexical_region_resolve Gives a big performance increase to the unicode_normalization benchmark in my testing.
|
☀️ Test successful - checks-azure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gives a big performance increase to the unicode_normalization benchmark in my testing.