Address inconsistency in using "is" with "declared here" #68080

varkor · 2020-01-10T02:16:11Z

"is" was generally used for NLL diagnostics, but not other diagnostics. Using "is" makes the diagnostics sound more natural and readable, so it seems sensible to commit to them throughout.

r? @Centril

Centril · 2020-01-10T02:19:17Z

Seems like you didn't get all of them, e.g. in check_match. Make sure you actually grep in src/lib* for "defined here".

varkor · 2020-01-10T13:10:13Z

Fixed.

Centril · 2020-01-10T21:47:35Z

@bors r+

bors · 2020-01-10T21:47:37Z

📌 Commit 1b5ad88726127be01d6f0dab013091862e4d337d has been approved by Centril

bors · 2020-01-10T23:42:35Z

☔ The latest upstream changes (presumably #68101) made this pull request unmergeable. Please resolve the merge conflicts.

varkor · 2020-01-11T00:20:14Z

@bors r=Centril

bors · 2020-01-11T00:20:15Z

📌 Commit 41d0fee2453fbdbe85ed41c10be7981a0381bcf4 has been approved by Centril

petrochenkov · 2020-01-11T00:42:18Z

I assumed the nominal sentences in labels are by design.
Labels are supposed to be very compact because they are attached to specific points in the source, so they use this straight to the point style that is often used in technical notifications ("Shutdown imminent!") or newspaper titles.

I used them multiple times and @estebank used this style many times as well, if I remember correctly. (None of us is a native English speaker though.)
@bors r- cc @rust-lang/wg-diagnostics

(I agree that in primary error messages or notes full sentences seem more appropriate.)

Centril · 2020-01-11T00:46:37Z

Labels are supposed to be very compact because they are attached to specific points in the source, so they use this straight to the point style that is often used in technical notifications ("Shutdown imminent!") or newspaper titles.

I agree with this rationale but I don't care strongly. Mostly I think it is important to be consistent, in some direction.

(None of us is a native English speaker though.)

(My neither, although @varkor is.)

varkor · 2020-01-25T15:06:50Z

Let's just wait until the branch off.

petrochenkov · 2020-01-30T20:48:36Z

@bors r+

bors · 2020-01-30T20:48:37Z

💡 This pull request was already approved, no need to approve it again.

This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.
There's another pull request that is currently being tested, blocking this pull request: Optimize catch_unwind to match C++ try/catch #67502

bors · 2020-01-30T20:48:39Z

📌 Commit 4583283 has been approved by petrochenkov

bors · 2020-01-31T09:49:16Z

⌛ Testing commit 4583283 with merge 3b63bd5...

@Centril

Address inconsistency in using "is" with "declared here" "is" was generally used for NLL diagnostics, but not other diagnostics. Using "is" makes the diagnostics sound more natural and readable, so it seems sensible to commit to them throughout. r? @Centril

rust-highfive · 2020-01-31T11:48:36Z

The job x86_64-gnu-aux of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2020-01-31T11:47:04.1260296Z    Compiling dlib v0.4.1
2020-01-31T11:47:12.7384849Z error: failed to run custom build command for `servo-fontconfig-sys v4.0.4`
2020-01-31T11:47:12.7403137Z 
2020-01-31T11:47:12.7403535Z Caused by:
2020-01-31T11:47:12.7404449Z   process didn't exit successfully: `/checkout/obj/build/ct/webrender/target/debug/build/servo-fontconfig-sys-8ec85100a685a0e8/build-script-build` (exit code: 101)
2020-01-31T11:47:12.7404891Z --- stdout
2020-01-31T11:47:12.7405763Z make[1]: Entering directory '/cargo/registry/src/git.luolix.top-1ecc6299db9ec823/servo-fontconfig-sys-4.0.4'
2020-01-31T11:47:12.7406103Z cd /checkout/obj/build/ct/webrender/target/debug/build/servo-fontconfig-sys-046199d0dd7012de/out && \
2020-01-31T11:47:12.7406209Z  CC="gcc" \
2020-01-31T11:47:12.7406287Z  AR="ar" \
2020-01-31T11:47:12.7406343Z  FREETYPE_CFLAGS="" \
2020-01-31T11:47:12.7406423Z  FREETYPE_LIBS="" \
2020-01-31T11:47:12.7406625Z  CFLAGS=""" -fPIC" \
2020-01-31T11:47:12.7406913Z  /cargo/registry/src/git.luolix.top-1ecc6299db9ec823/servo-fontconfig-sys-4.0.4/configure \
2020-01-31T11:47:12.7407127Z  --disable-docs \
2020-01-31T11:47:12.7407338Z  --disable-shared \
2020-01-31T11:47:12.7407573Z   \
2020-01-31T11:47:12.7407893Z  --host=x86_64-unknown-linux-gnu --sysconfdir=/etc --localstatedir=/var
2020-01-31T11:47:12.7408248Z checking whether build environment is sane... yes
2020-01-31T11:47:12.7408488Z checking for x86_64-unknown-linux-gnu-strip... no
2020-01-31T11:47:12.7408576Z checking for strip... strip
2020-01-31T11:47:12.7408968Z checking for a thread-safe mkdir -p... /bin/mkdir -p
2020-01-31T11:47:12.7408968Z checking for a thread-safe mkdir -p... /bin/mkdir -p
2020-01-31T11:47:12.7409039Z checking for gawk... no
2020-01-31T11:47:12.7409115Z checking for mawk... mawk
2020-01-31T11:47:12.7409262Z checking whether make supports nested variables... yes
2020-01-31T11:47:12.7409337Z checking whether make supports nested variables... (cached) yes
2020-01-31T11:47:12.7409623Z checking whether to enable maintainer-specific portions of Makefiles... no
2020-01-31T11:47:12.7409876Z checking for x86_64-unknown-linux-gnu-gcc... gcc
---
2020-01-31T11:47:12.7413668Z checking whether make sets $(MAKE)... (cached) yes
2020-01-31T11:47:12.7413948Z checking for x86_64-unknown-linux-gnu-pkg-config... no
2020-01-31T11:47:12.7414236Z checking for pkg-config... /usr/bin/pkg-config
2020-01-31T11:47:12.7414536Z checking pkg-config is at least version 0.9.0... yes
2020-01-31T11:47:12.7414786Z checking for RM macro... rm -f
2020-01-31T11:47:12.7415509Z checking host system type... x86_64-unknown-linux-gnu
2020-01-31T11:47:12.7415761Z checking how to print strings... printf
2020-01-31T11:47:12.7415831Z checking for a sed that does not truncate output... /bin/sed
2020-01-31T11:47:12.7416068Z checking for fgrep... /bin/grep -F
2020-01-31T11:47:12.7416068Z checking for fgrep... /bin/grep -F
2020-01-31T11:47:12.7416212Z checking for ld used by gcc... /usr/bin/ld
2020-01-31T11:47:12.7416305Z checking if the linker (/usr/bin/ld) is GNU ld... yes
2020-01-31T11:47:12.7416916Z checking for BSD- or MS-compatible name lister (nm)... /usr/bin/nm -B
2020-01-31T11:47:12.7417201Z checking the name lister (/usr/bin/nm -B) interface... BSD nm
2020-01-31T11:47:12.7417301Z checking the maximum length of command line arguments... 1572864
2020-01-31T11:47:12.7417379Z checking whether the shell understands some XSI constructs... yes
2020-01-31T11:47:12.7417570Z checking whether the shell understands "+="... yes
2020-01-31T11:47:12.7417915Z checking how to convert x86_64-unknown-linux-gnu file names to x86_64-unknown-linux-gnu format... func_convert_file_noop
2020-01-31T11:47:12.7418253Z checking how to convert x86_64-unknown-linux-gnu file names to toolchain format... func_convert_file_noop
2020-01-31T11:47:12.7418518Z checking for /usr/bin/ld option to reload object files... -r
2020-01-31T11:47:12.7418777Z checking for x86_64-unknown-linux-gnu-objdump... no
2020-01-31T11:47:12.7418942Z checking how to recognize dependent libraries... pass_all
2020-01-31T11:47:12.7419199Z checking for x86_64-unknown-linux-gnu-dlltool... no
2020-01-31T11:47:12.7419269Z checking for dlltool... no
2020-01-31T11:47:12.7419362Z checking how to associate runtime and link libraries... printf %s\n
2020-01-31T11:47:12.7419362Z checking how to associate runtime and link libraries... printf %s\n
2020-01-31T11:47:12.7419601Z checking for x86_64-unknown-linux-gnu-ar... ar
2020-01-31T11:47:12.7419695Z checking for archiver @FILE support... @
2020-01-31T11:47:12.7419931Z checking for x86_64-unknown-linux-gnu-strip... strip
2020-01-31T11:47:12.7420187Z checking for x86_64-unknown-linux-gnu-ranlib... no
2020-01-31T11:47:12.7420256Z checking for ranlib... ranlib
2020-01-31T11:47:12.7420523Z checking command to parse /usr/bin/nm -B output from gcc object... ok
2020-01-31T11:47:12.7420613Z checking for sysroot... no
2020-01-31T11:47:12.7420842Z checking for x86_64-unknown-linux-gnu-mt... no
2020-01-31T11:47:12.7420933Z checking for mt... no
2020-01-31T11:47:12.7420994Z checking if : is a manifest tool... no
2020-01-31T11:47:12.7421072Z checking for dlfcn.h... yes
2020-01-31T11:47:12.7421132Z checking for objdir... .libs
2020-01-31T11:47:12.7421393Z checking if gcc supports -fno-rtti -fno-exceptions... no
2020-01-31T11:47:12.7421634Z checking for gcc option to produce PIC... -fPIC -DPIC
2020-01-31T11:47:12.7421886Z checking if gcc PIC flag -fPIC -DPIC works... yes
2020-01-31T11:47:12.7422130Z checking if gcc static flag -static works... yes
2020-01-31T11:47:12.7422820Z checking if gcc supports -c -o file.o... yes
2020-01-31T11:47:12.7423112Z checking if gcc supports -c -o file.o... (cached) yes
2020-01-31T11:47:12.7423441Z checking whether the gcc linker (/usr/bin/ld -m elf_x86_64) supports shared libraries... yes
2020-01-31T11:47:12.7423563Z checking dynamic linker characteristics... GNU/Linux ld.so
2020-01-31T11:47:12.7423651Z checking how to hardcode library paths into programs... immediate
2020-01-31T11:47:12.7423767Z checking whether stripping libraries is possible... yes
2020-01-31T11:47:12.7423850Z checking if libtool supports shared libraries... yes
2020-01-31T11:47:12.7423950Z checking whether to build shared libraries... no
2020-01-31T11:47:12.7424124Z checking for dirent.h that defines DIR... yes
2020-01-31T11:47:12.7424219Z checking for library containing opendir... none required
2020-01-31T11:47:12.7424308Z checking for ANSI C header files... (cached) yes
2020-01-31T11:47:12.7424397Z checking fcntl.h usability... yes
---
2020-01-31T11:47:12.7426615Z checking for sys/param.h... yes
2020-01-31T11:47:12.7426689Z checking sys/mount.h usability... yes
2020-01-31T11:47:12.7426766Z checking sys/mount.h presence... yes
2020-01-31T11:47:12.7426832Z checking for sys/mount.h... yes
2020-01-31T11:47:12.7426912Z checking for stdint types... stdint.h (shortcircuit)
2020-01-31T11:47:12.7426985Z make use of stdint.h in src/fcstdint.h (assuming C99 compatible system)
2020-01-31T11:47:12.7427343Z checking for inline... inline
2020-01-31T11:47:12.7427420Z checking for flexible array members... yes
2020-01-31T11:47:12.7427482Z checking for pid_t... yes
2020-01-31T11:47:12.7427562Z checking for vprintf... yes
---
2020-01-31T11:47:12.7427940Z checking for getpagesize... yes
2020-01-31T11:47:12.7427999Z checking for working mmap... yes
2020-01-31T11:47:12.7428074Z checking for link... yes
2020-01-31T11:47:12.7428132Z checking for mkstemp... yes
2020-01-31T11:47:12.7428212Z checking for mkostemp... yes
2020-01-31T11:47:12.7428270Z checking for _mktemp_s... no
2020-01-31T11:47:12.7428401Z checking for getopt... yes
2020-01-31T11:47:12.7428473Z checking for getopt_long... yes
2020-01-31T11:47:12.7428531Z checking for getprogname... no
2020-01-31T11:47:12.7428602Z checking for getexecname... no
---
2020-01-31T11:47:12.7429486Z checking for fstatfs... yes
2020-01-31T11:47:12.7429558Z checking for lstat... yes
2020-01-31T11:47:12.7429620Z checking for posix_fadvise in fcntl.h... fcntl.h
2020-01-31T11:47:12.7429697Z checking for scandir... yes
2020-01-31T11:47:12.7429757Z checking for struct statvfs.f_basetype... no
2020-01-31T11:47:12.7429836Z checking for struct statvfs.f_fstypename... no
2020-01-31T11:47:12.7429915Z checking for struct statfs.f_flags... yes
2020-01-31T11:47:12.7429984Z checking for struct statfs.f_fstypename... no
2020-01-31T11:47:12.7430060Z checking for struct dirent.d_type... yes
2020-01-31T11:47:12.7430121Z checking for FREETYPE... yes
2020-01-31T11:47:12.7430195Z checking for FT_Get_Next_Char... yes
2020-01-31T11:47:12.7430254Z checking for FT_Get_BDF_Property... yes
2020-01-31T11:47:12.7430328Z checking for FT_Get_PS_Font_Info... yes
2020-01-31T11:47:12.7430388Z checking for FT_Has_PS_Glyph_Names... yes
2020-01-31T11:47:12.7430465Z checking for FT_Get_X11_Font_Format... yes
2020-01-31T11:47:12.7430600Z checking for FT_Select_Size... yes
2020-01-31T11:47:12.7430687Z checking for FT_Bitmap_Size.y_ppem... yes
2020-01-31T11:47:12.7430819Z checking expat.h usability... yes
2020-01-31T11:47:12.7430893Z checking expat.h presence... yes
2020-01-31T11:47:12.7430951Z checking for expat.h... yes
2020-01-31T11:47:12.7430951Z checking for expat.h... yes
2020-01-31T11:47:12.7431028Z checking for XML_SetDoctypeDeclHandler... yes
2020-01-31T11:47:12.7431226Z checking for Intel atomic primitives... true
2020-01-31T11:47:12.7431292Z checking for Solaris atomic operations... false
2020-01-31T11:47:12.7431601Z checking if compiler needs -Werror to reject unknown flags... no
2020-01-31T11:47:12.7432014Z checking for the pthreads library -lpthreads... no
2020-01-31T11:47:12.7432109Z checking whether pthreads work without any flags... no
2020-01-31T11:47:12.7432764Z checking whether pthreads work with -Kthread... no
2020-01-31T11:47:12.7433054Z checking whether pthreads work with -kthread... no
2020-01-31T11:47:12.7433334Z checking for the pthreads library -llthread... no
2020-01-31T11:47:12.7433629Z checking whether pthreads work with -pthread... yes
2020-01-31T11:47:12.7433719Z checking for joinable pthread attribute... PTHREAD_CREATE_JOINABLE
2020-01-31T11:47:12.7433825Z checking if more special flags are required for pthreads... no
2020-01-31T11:47:12.7433921Z checking for PTHREAD_PRIO_INHERIT... yes
2020-01-31T11:47:12.7433994Z checking for docbook2html... no
2020-01-31T11:47:12.7434094Z checking whether byte ordering is bigendian... no
2020-01-31T11:47:12.7434169Z checking size of void *... 8
2020-01-31T11:47:12.7434254Z checking alignment of double... 8
2020-01-31T11:47:12.7434332Z checking that generated files are newer than configure... done
2020-01-31T11:47:12.7434498Z config.status: creating Makefile
2020-01-31T11:47:12.7434586Z config.status: creating fontconfig/Makefile
2020-01-31T11:47:12.7434854Z config.status: creating fc-lang/Makefile
2020-01-31T11:47:12.7434854Z config.status: creating fc-lang/Makefile
2020-01-31T11:47:12.7435299Z config.status: creating fc-glyphname/Makefile
2020-01-31T11:47:12.7435566Z config.status: creating fc-case/Makefile
2020-01-31T11:47:12.7435812Z config.status: creating src/Makefile
2020-01-31T11:47:12.7435890Z config.status: creating conf.d/Makefile
2020-01-31T11:47:12.7436110Z config.status: creating fc-cache/Makefile
2020-01-31T11:47:12.7436347Z config.status: creating fc-cat/Makefile
2020-01-31T11:47:12.7436567Z config.status: creating fc-list/Makefile
2020-01-31T11:47:12.7436816Z config.status: creating fc-match/Makefile
2020-01-31T11:47:12.7437042Z config.status: creating fc-pattern/Makefile
2020-01-31T11:47:12.7437281Z config.status: creating fc-query/Makefile
2020-01-31T11:47:12.7437501Z config.status: creating fc-scan/Makefile
2020-01-31T11:47:12.7437742Z config.status: creating fc-validate/Makefile
2020-01-31T11:47:12.7437888Z config.status: creating doc/version.sgml
2020-01-31T11:47:12.7437975Z config.status: creating test/Makefile
2020-01-31T11:47:12.7438037Z config.status: creating fontconfig.spec
2020-01-31T11:47:12.7438115Z config.status: creating fontconfig.pc
2020-01-31T11:47:12.7438115Z config.status: creating fontconfig.pc
2020-01-31T11:47:12.7438336Z config.status: creating fontconfig-zip
2020-01-31T11:47:12.7438420Z config.status: creating config.h
2020-01-31T11:47:12.7438483Z config.status: executing depfiles commands
2020-01-31T11:47:12.7438563Z config.status: executing libtool commands
2020-01-31T11:47:12.7438638Z config.status: executing src/fcstdint.h commands
2020-01-31T11:47:12.7438842Z config.status: creating src/fcstdint.h : _FONTCONFIG_SRC_FCSTDINT_H
2020-01-31T11:47:12.7439172Z cd /checkout/obj/build/ct/webrender/target/debug/build/servo-fontconfig-sys-046199d0dd7012de/out && make -j2
2020-01-31T11:47:12.7439511Z make[2]: Entering directory '/checkout/obj/build/ct/webrender/target/debug/build/servo-fontconfig-sys-046199d0dd7012de/out'
2020-01-31T11:47:12.7440145Z make[3]: Entering directory '/checkout/obj/build/ct/webrender/target/debug/build/servo-fontconfig-sys-046199d0dd7012de/out'
2020-01-31T11:47:12.7440264Z Making all in fontconfig
2020-01-31T11:47:12.7440619Z make[4]: Entering directory '/checkout/obj/build/ct/webrender/target/debug/build/servo-fontconfig-sys-046199d0dd7012de/out/fontconfig'
2020-01-31T11:47:12.7440889Z make[4]: Nothing to be done for 'all'.
2020-01-31T11:47:12.7440889Z make[4]: Nothing to be done for 'all'.
2020-01-31T11:47:12.7441242Z make[4]: Leaving directory '/checkout/obj/build/ct/webrender/target/debug/build/servo-fontconfig-sys-046199d0dd7012de/out/fontconfig'
2020-01-31T11:47:12.7441580Z Making all in fc-case
2020-01-31T11:47:12.7441977Z make[4]: Entering directory '/checkout/obj/build/ct/webrender/target/debug/build/servo-fontconfig-sys-046199d0dd7012de/out/fc-case'
2020-01-31T11:47:12.7442071Z   GEN      fcalias.h
2020-01-31T11:47:12.7442220Z   GEN      fcaliastail.h
2020-01-31T11:47:12.7442996Z make[5]: Entering directory '/checkout/obj/build/ct/webrender/target/debug/build/servo-fontconfig-sys-046199d0dd7012de/out/fc-case'
2020-01-31T11:47:12.7443458Z make[5]: Nothing to be done for 'all-am'.
2020-01-31T11:47:12.7443821Z make[5]: Leaving directory '/checkout/obj/build/ct/webrender/target/debug/build/servo-fontconfig-sys-046199d0dd7012de/out/fc-case'
2020-01-31T11:47:12.7444228Z make[4]: Leaving directory '/checkout/obj/build/ct/webrender/target/debug/build/servo-fontconfig-sys-046199d0dd7012de/out/fc-case'
2020-01-31T11:47:12.7444228Z make[4]: Leaving directory '/checkout/obj/build/ct/webrender/target/debug/build/servo-fontconfig-sys-046199d0dd7012de/out/fc-case'
2020-01-31T11:47:12.7444483Z Making all in fc-lang
2020-01-31T11:47:12.7444865Z make[4]: Entering directory '/checkout/obj/build/ct/webrender/target/debug/build/servo-fontconfig-sys-046199d0dd7012de/out/fc-lang'
2020-01-31T11:47:12.7444968Z   GEN      fcalias.h
2020-01-31T11:47:12.7445052Z   GEN      fcaliastail.h
2020-01-31T11:47:12.7445266Z make  all-am
2020-01-31T11:47:12.7445785Z make[5]: Entering directory '/checkout/obj/build/ct/webrender/target/debug/build/servo-fontconfig-sys-046199d0dd7012de/out/fc-lang'
2020-01-31T11:47:12.7445893Z   GEN      fclang.h
2020-01-31T11:47:12.7446217Z make[6]: Entering directory '/checkout/obj/build/ct/webrender/target/debug/build/servo-fontconfig-sys-046199d0dd7012de/out/fc-lang'
2020-01-31T11:47:12.7446650Z   GEN      fc-lang
2020-01-31T11:47:12.7447342Z make[6]: Leaving directory '/checkout/obj/build/ct/webrender/target/debug/build/servo-fontconfig-sys-046199d0dd7012de/out/fc-lang'
2020-01-31T11:47:12.7447783Z make[5]: Leaving directory '/checkout/obj/build/ct/webrender/target/debug/build/servo-fontconfig-sys-046199d0dd7012de/out/fc-lang'
2020-01-31T11:47:12.7448168Z make[4]: Leaving directory '/checkout/obj/build/ct/webrender/target/debug/build/servo-fontconfig-sys-046199d0dd7012de/out/fc-lang'
2020-01-31T11:47:12.7448406Z Making all in fc-glyphname
2020-01-31T11:47:12.7448754Z make[4]: Entering directory '/checkout/obj/build/ct/webrender/target/debug/build/servo-fontconfig-sys-046199d0dd7012de/out/fc-glyphname'
2020-01-31T11:47:12.7448848Z   GEN      fcalias.h
2020-01-31T11:47:12.7448925Z   GEN      fcaliastail.h
2020-01-31T11:47:12.7449117Z make  all-am
2020-01-31T11:47:12.7449466Z make[5]: Entering directory '/checkout/obj/build/ct/webrender/target/debug/build/servo-fontconfig-sys-046199d0dd7012de/out/fc-glyphname'
2020-01-31T11:47:12.7449721Z make[5]: Nothing to be done for 'all-am'.
2020-01-31T11:47:12.7450068Z make[5]: Leaving directory '/checkout/obj/build/ct/webrender/target/debug/build/servo-fontconfig-sys-046199d0dd7012de/out/fc-glyphname'
2020-01-31T11:47:12.7450440Z make[4]: Leaving directory '/checkout/obj/build/ct/webrender/target/debug/build/servo-fontconfig-sys-046199d0dd7012de/out/fc-glyphname'
2020-01-31T11:47:12.7450871Z make[4]: Entering directory '/checkout/obj/build/ct/webrender/target/debug/build/servo-fontconfig-sys-046199d0dd7012de/out/src'
2020-01-31T11:47:12.7450871Z make[4]: Entering directory '/checkout/obj/build/ct/webrender/target/debug/build/servo-fontconfig-sys-046199d0dd7012de/out/src'
2020-01-31T11:47:12.7450972Z   GEN      fcftalias.h
2020-01-31T11:47:12.7451049Z   GEN      fcalias.h
2020-01-31T11:47:12.7451252Z   GEN      stamp-fcstdint
2020-01-31T11:47:12.7451339Z config.status: executing src/fcstdint.h commands
2020-01-31T11:47:12.7451535Z config.status: creating src/fcstdint.h : _FONTCONFIG_SRC_FCSTDINT_H
2020-01-31T11:47:12.7451617Z config.status: src/fcstdint.h is unchanged
2020-01-31T11:47:12.7451695Z   GEN      fcobjshash.gperf
2020-01-31T11:47:12.7451755Z   GEN      fcobjshash.h
2020-01-31T11:47:12.7452103Z Makefile:882: recipe for target 'fcobjshash.h' failed
2020-01-31T11:47:12.7452622Z make[4]: Leaving directory '/checkout/obj/build/ct/webrender/target/debug/build/servo-fontconfig-sys-046199d0dd7012de/out/src'
2020-01-31T11:47:12.7453030Z Makefile:562: recipe for target 'all-recursive' failed
2020-01-31T11:47:12.7453371Z make[3]: Leaving directory '/checkout/obj/build/ct/webrender/target/debug/build/servo-fontconfig-sys-046199d0dd7012de/out'
2020-01-31T11:47:12.7453661Z Makefile:445: recipe for target 'all' failed
2020-01-31T11:47:12.7454061Z make[2]: Leaving directory '/checkout/obj/build/ct/webrender/target/debug/build/servo-fontconfig-sys-046199d0dd7012de/out'
2020-01-31T11:47:12.7454505Z makefile.cargo:61: recipe for target '/checkout/obj/build/ct/webrender/target/debug/build/servo-fontconfig-sys-046199d0dd7012de/out/libfontconfig.a' failed
2020-01-31T11:47:12.7455052Z make[1]: Leaving directory '/cargo/registry/src/git.luolix.top-1ecc6299db9ec823/servo-fontconfig-sys-4.0.4'
2020-01-31T11:47:12.7455503Z --- stderr
2020-01-31T11:47:12.7455749Z make[2]: warning: -jN forced in submake: disabling jobserver mode.
2020-01-31T11:47:12.7455749Z make[2]: warning: -jN forced in submake: disabling jobserver mode.
2020-01-31T11:47:12.7456086Z /cargo/registry/src/git.luolix.top-1ecc6299db9ec823/servo-fontconfig-sys-4.0.4/missing: line 81: gperf: command not found
2020-01-31T11:47:12.7456347Z WARNING: 'gperf' is missing on your system.
2020-01-31T11:47:12.7473791Z          You might have modified some files without having the proper
2020-01-31T11:47:12.7474419Z          tools for further handling them.  Check the 'README' file, it
2020-01-31T11:47:12.7474545Z          often tells you about the needed prerequisites for installing
2020-01-31T11:47:12.7474669Z          this package.  You may also peek at any GNU archive site, in
2020-01-31T11:47:12.7474972Z          case some other package contains this missing 'gperf' program.
2020-01-31T11:47:12.7475226Z make[4]: *** [fcobjshash.h] Error 1
2020-01-31T11:47:12.7475297Z make[4]: *** Waiting for unfinished jobs....
2020-01-31T11:47:12.7475728Z make[3]: *** [all-recursive] Error 1
2020-01-31T11:47:12.7475795Z make[2]: *** [all] Error 2
2020-01-31T11:47:12.7476142Z make[1]: *** [/checkout/obj/build/ct/webrender/target/debug/build/servo-fontconfig-sys-046199d0dd7012de/out/libfontconfig.a] Error 2
2020-01-31T11:47:12.7476455Z thread 'main' panicked at 'assertion failed: Command::new("make").env("MAKEFLAGS",
2020-01-31T11:47:12.7476763Z                          env::var("CARGO_MAKEFLAGS").unwrap_or_default()).args(&["-R",
2020-01-31T11:47:12.7477061Z                                                                                  "-f",
2020-01-31T11:47:12.7477510Z                                                                                  "makefile.cargo"]).status().unwrap().success()', /cargo/registry/src/git.luolix.top-1ecc6299db9ec823/servo-fontconfig-sys-4.0.4/build.rs:17:5
2020-01-31T11:47:12.7477720Z 
2020-01-31T11:47:12.7477806Z warning: build failed, waiting for other jobs to finish...
2020-01-31T11:47:12.8535405Z error: build failed
2020-01-31T11:47:12.8553416Z thread 'main' panicked at 'tests failed for https://github.com/servo/webrender', src/tools/cargotest/main.rs:88:9
---
2020-01-31T11:47:12.8560310Z 
2020-01-31T11:47:12.8560342Z 
2020-01-31T11:47:12.8576289Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/test/run-fail/pretty src/test/run-pass-valgrind/pretty src/tools/cargo src/tools/cargotest
2020-01-31T11:47:12.8576618Z Build completed unsuccessfully in 1:52:54
2020-01-31T11:47:12.8626972Z Makefile:50: recipe for target 'check-aux' failed
2020-01-31T11:47:12.8627546Z make: *** [check-aux] Error 1
2020-01-31T11:47:12.8645840Z   local time: Fri Jan 31 11:47:12 UTC 2020
2020-01-31T11:47:13.1422502Z   network time: Fri, 31 Jan 2020 11:47:13 GMT
2020-01-31T11:47:13.1426637Z == end clock drift check ==
2020-01-31T11:47:16.5758066Z 
2020-01-31T11:47:16.5758066Z 
2020-01-31T11:47:16.5863395Z ##[error]Bash exited with code '2'.
2020-01-31T11:47:16.5911711Z ##[section]Starting: Checkout rust-lang/rust@auto to s
2020-01-31T11:47:16.5914158Z ==============================================================================
2020-01-31T11:47:16.5914273Z Task         : Get sources
2020-01-31T11:47:16.5914377Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

bors · 2020-01-31T11:48:50Z

💔 Test failed - checks-azure

varkor · 2020-01-31T13:41:37Z

Looks spurious to me?

@bors retry

bors · 2020-01-31T15:13:57Z

⌛ Testing commit 4583283 with merge 5371ddf...

@Centril

Address inconsistency in using "is" with "declared here" "is" was generally used for NLL diagnostics, but not other diagnostics. Using "is" makes the diagnostics sound more natural and readable, so it seems sensible to commit to them throughout. r? @Centril

bors · 2020-01-31T18:35:09Z

☀️ Test successful - checks-azure
Approved by: petrochenkov
Pushing 5371ddf to master...

rust-highfive · 2020-01-31T18:36:22Z

📣 Toolstate changed by #68080!

Tested on commit 5371ddf.
Direct link to PR: #68080

💔 clippy-driver on windows: test-pass → test-fail (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq, @rust-lang/infra).
💔 clippy-driver on linux: test-pass → test-fail (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq, @rust-lang/infra).

@mcarton

Tested on commit rust-lang/rust@5371ddf. Direct link to PR: <rust-lang/rust#68080> 💔 clippy-driver on windows: test-pass → test-fail (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq, @rust-lang/infra). 💔 clippy-driver on linux: test-pass → test-fail (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq, @rust-lang/infra).

rust-highfive assigned Centril Jan 10, 2020

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 10, 2020

Centril added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 10, 2020

varkor force-pushed the declared-here branch from f485e10 to f1cb076 Compare January 10, 2020 13:10

This comment has been minimized.

Sign in to view

varkor force-pushed the declared-here branch from 6b74974 to abb5409 Compare January 10, 2020 18:03

This comment has been minimized.

Sign in to view

varkor force-pushed the declared-here branch from abb5409 to 1b5ad88 Compare January 10, 2020 19:15

varkor added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 10, 2020

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 10, 2020

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 10, 2020

varkor force-pushed the declared-here branch from 1b5ad88 to 41d0fee Compare January 11, 2020 00:09

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 11, 2020

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 11, 2020

petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 25, 2020

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 30, 2020

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 31, 2020

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 31, 2020

bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 31, 2020

bors merged commit 4583283 into rust-lang:master Jan 31, 2020

This was referenced Jan 31, 2020

Minimum lint levels for C-future-compatibility issues: take two #68501

Closed

Split lang_items to crates rustc_hir and rustc_passes. #68554

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Address inconsistency in using "is" with "declared here" #68080

Address inconsistency in using "is" with "declared here" #68080

varkor commented Jan 10, 2020

Centril commented Jan 10, 2020

varkor commented Jan 10, 2020

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Centril commented Jan 10, 2020

bors commented Jan 10, 2020

bors commented Jan 10, 2020

varkor commented Jan 11, 2020

bors commented Jan 11, 2020

petrochenkov commented Jan 11, 2020

Centril commented Jan 11, 2020

varkor commented Jan 25, 2020

petrochenkov commented Jan 30, 2020

bors commented Jan 30, 2020

bors commented Jan 30, 2020

bors commented Jan 31, 2020

rust-highfive commented Jan 31, 2020

bors commented Jan 31, 2020

varkor commented Jan 31, 2020

bors commented Jan 31, 2020

bors commented Jan 31, 2020

rust-highfive commented Jan 31, 2020

Address inconsistency in using "is" with "declared here" #68080

Address inconsistency in using "is" with "declared here" #68080

Conversation

varkor commented Jan 10, 2020

Centril commented Jan 10, 2020

varkor commented Jan 10, 2020

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Centril commented Jan 10, 2020

bors commented Jan 10, 2020

bors commented Jan 10, 2020

varkor commented Jan 11, 2020

bors commented Jan 11, 2020

petrochenkov commented Jan 11, 2020

Centril commented Jan 11, 2020

varkor commented Jan 25, 2020

petrochenkov commented Jan 30, 2020

bors commented Jan 30, 2020

bors commented Jan 30, 2020

bors commented Jan 31, 2020

rust-highfive commented Jan 31, 2020

bors commented Jan 31, 2020

varkor commented Jan 31, 2020

bors commented Jan 31, 2020

bors commented Jan 31, 2020

rust-highfive commented Jan 31, 2020