Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 6 pull requests #68144

Closed
wants to merge 23 commits into from
Closed

Commits on Dec 15, 2019

  1. Configuration menu
    Copy the full SHA
    9158e17 View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2019

  1. Address review comments

    oli-obk committed Dec 20, 2019
    Configuration menu
    Copy the full SHA
    5f08df1 View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2020

  1. Don't run const propagation on items with inconsistent bounds

    Using `#![feature(trivial_bounds)]`, it's possible to write functions
    with unsatisfiable 'where' clauses, making them uncallable. However, the
    user can act as if these 'where' clauses are true inside the body of the
    function, leading to code that would normally be impossible to write.
    
    Since const propgation can run even without any user-written calls to a
    function, we need to explcitly check for these uncallable functions.
    Aaron1011 committed Jan 6, 2020
    Configuration menu
    Copy the full SHA
    89308bb View commit details
    Browse the repository at this point in the history

Commits on Jan 7, 2020

  1. Configuration menu
    Copy the full SHA
    4a84027 View commit details
    Browse the repository at this point in the history
  2. Fix typo

    Aaron1011 authored Jan 7, 2020
    Configuration menu
    Copy the full SHA
    9951450 View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2020

  1. Configuration menu
    Copy the full SHA
    1ffb9cf View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ae3a53f View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2020

  1. Configuration menu
    Copy the full SHA
    74823fc View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    84c8849 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    7876fa6 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    7d2c75d View commit details
    Browse the repository at this point in the history
  5. Appease tidy

    varkor committed Jan 11, 2020
    Configuration menu
    Copy the full SHA
    a6924c7 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    6ea4dba View commit details
    Browse the repository at this point in the history
  7. Convert test to check-pass

    Aaron1011 committed Jan 11, 2020
    Configuration menu
    Copy the full SHA
    7f26d32 View commit details
    Browse the repository at this point in the history
  8. Add "--emit=link"

    This avoids a strange linker error that we get with only "--emit=mir"
    and "check-pass"
    Aaron1011 committed Jan 11, 2020
    Configuration menu
    Copy the full SHA
    b4125f0 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    ed039e8 View commit details
    Browse the repository at this point in the history
  10. parse extended terminfo format

    euclio committed Jan 11, 2020
    Configuration menu
    Copy the full SHA
    f9a5746 View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2020

  1. Rollup merge of rust-lang#67313 - oli-obk:document_all_the_t̶h̶i̶n̶g̶…

    …s̶dataflow, r=ecstatic-morse
    
    Document more use cases of dataflow
    
    r? @ecstatic-morse
    Centril authored Jan 12, 2020
    Configuration menu
    Copy the full SHA
    eec0cbd View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#67914 - Aaron1011:fix/const-prop-impossible…

    …, r=matthewjasper
    
    Don't run const propagation on items with inconsistent bounds
    
    Fixes rust-lang#67696
    
    Using `#![feature(trivial_bounds)]`, it's possible to write functions
    with unsatisfiable 'where' clauses, making them uncallable. However, the
    user can act as if these 'where' clauses are true inside the body of the
    function, leading to code that would normally be impossible to write.
    
    Since const propgation can run even without any user-written calls to a
    function, we need to explcitly check for these uncallable functions.
    Centril authored Jan 12, 2020
    Configuration menu
    Copy the full SHA
    c40b394 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a3cbaae View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#68036 - euclio:libterm-ncurses6-fix, r=KodrAus

    libterm: parse extended terminfo format
    
    Fixes rust-lang#45728.
    
    Modifies libterm to parse the extended terminfo format introduced in ncurses 6.1. This fixes the lack of color in test output for users with newer ncurses versions.
    
    The ideal fix for this would be to migrate libtest to use `termcolor` (rust-lang#60349), but that's blocked for the foreseeable future.
    Centril authored Jan 12, 2020
    Configuration menu
    Copy the full SHA
    1abb7e9 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#68096 - varkor:diagnostic-cleanup, r=Centril

    Clean up some diagnostics by making them more consistent
    
    In general:
    
    - Diagnostic should start with a lowercase letter.
    - Diagnostics should not end with a full stop.
    - Ellipses contain three dots.
    - Backticks should encode Rust code.
    
    I also reworded a couple of messages to make them read more clearly.
    
    It might be sensible to create a style guide for diagnostics, so these informal conventions are written down somewhere, after which we could audit the existing diagnostics.
    
    r? @Centril
    Centril authored Jan 12, 2020
    Configuration menu
    Copy the full SHA
    098f48c View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#68135 - calebcartwright:rustc-parse-visibil…

    …ities, r=Centril
    
    restore some rustc_parse visibilities for rustfmt
    
    In rust-lang@c189565 some visibilities were reduced on the parse mod (which now resides in the rustc_parse crate) as part of some refactoring and splitting up of libsyntax. However, rustfmt needs access to a few of those items that are no longer visible.
    
    This restores the visibility on those items rustfmt depends on.
    
    rust-lang/rustfmt#3903 (comment)
    rust-lang/rustfmt#4009
    
    cc @topecongiro
    Centril authored Jan 12, 2020
    Configuration menu
    Copy the full SHA
    92ed032 View commit details
    Browse the repository at this point in the history