Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Account for common impl Trait/dyn Trait return type errors #68195

Merged
merged 15 commits into from
Jan 17, 2020
Merged

Account for common impl Trait/dyn Trait return type errors #68195

merged 15 commits into from
Jan 17, 2020

Commits on Jan 16, 2020

  1. Specific error for unsized dyn Trait return type 

    Suggest `impl Trait` when possible, and `Box<dyn Trait>` otherwise.
    @estebank
    estebank committed Jan 16, 2020
    Configuration menu
    Copy the full SHA
    6fd5641 View commit details
    Browse the repository at this point in the history

  2. Account for diverging types in return impl Trait

    @estebank
    estebank committed Jan 16, 2020
    Configuration menu
    Copy the full SHA
    75eabb1 View commit details
    Browse the repository at this point in the history

  3. Elide E0308 errors in favor of E0746 

    When a type error involves a `dyn Trait` as the return type, do not emit
the type error, as the "return type is not `Sized`" error will provide
enough information to the user.
    @estebank
    estebank committed Jan 16, 2020
    Configuration menu
    Copy the full SHA
    ea7e885 View commit details
    Browse the repository at this point in the history

  4. Make impl Trait suggestion in E0746 MachineApplicable

    @estebank
    estebank committed Jan 16, 2020
    Configuration menu
    Copy the full SHA
    b4bbe78 View commit details
    Browse the repository at this point in the history

  5. When trait bounds are missing for return values, point at them

    @estebank
    estebank committed Jan 16, 2020
    Configuration menu
    Copy the full SHA
    e1dd8a9 View commit details
    Browse the repository at this point in the history

  6. fmt

    @estebank
    estebank committed Jan 16, 2020
    Configuration menu
    Copy the full SHA
    93293c5 View commit details
    Browse the repository at this point in the history

  7. Add E0746 explanation to the index

    @estebank
    estebank committed Jan 16, 2020
    Configuration menu
    Copy the full SHA
    4c13d25 View commit details
    Browse the repository at this point in the history

  8. Split librustc/traits/error_reporting.rs

    @estebank
    estebank committed Jan 16, 2020
    Configuration menu
    Copy the full SHA
    00c8272 View commit details
    Browse the repository at this point in the history

  9. fix error code index comment

    @estebank
    estebank committed Jan 16, 2020
    Configuration menu
    Copy the full SHA
    4a75ef9 View commit details
    Browse the repository at this point in the history

  10. review comments

    @estebank
    estebank committed Jan 16, 2020
    Configuration menu
    Copy the full SHA
    5b36c18 View commit details
    Browse the repository at this point in the history

  11. review comments

    @estebank
    estebank committed Jan 16, 2020
    Configuration menu
    Copy the full SHA
    509cb33 View commit details
    Browse the repository at this point in the history

  12. Fix error index test

    @estebank
    estebank committed Jan 16, 2020
    Configuration menu
    Copy the full SHA
    c305ac3 View commit details
    Browse the repository at this point in the history

  13. review comments

    @estebank
    estebank committed Jan 16, 2020
    Configuration menu
    Copy the full SHA
    d7a6212 View commit details
    Browse the repository at this point in the history

  14. Account for object safety when suggesting Box<dyn Trait>

    @estebank
    estebank committed Jan 16, 2020
    Configuration menu
    Copy the full SHA
    00e2626 View commit details
    Browse the repository at this point in the history

  15. review comments

    @estebank
    estebank committed Jan 16, 2020
    Configuration menu
    Copy the full SHA
    029a9c6 View commit details
    Browse the repository at this point in the history