Make extra::bigint sane #6822
Closed
Make extra::bigint sane #6822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice find! 🌸 I wonder how much more we could get from removing other inline attributes. |
bors
added a commit
that referenced
this pull request
May 30, 2013
This removes all the `#[inline(always)]` attributes from the bigint module, all 112 of them... This was responsible for increasing the code size of the module by almost 100x and accounts for roughly 95% of the previous build time of libextra.
|
@Aatch I agree with this change, but this doesn't leave a single |
|
@bstrie there has been talk of removing the module altogether. The motivation being that this has very few, if any, users. There are some functions that should probably be marked with |
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Mar 11, 2021
Rustfmt version "Two" changelog: none This enables some ~bug fixes~ changes from rustfmt. This is more consistent with rustc's config, and should be more forward-compatible. Also, the changes look good IMO. 😃
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes all the
#[inline(always)]attributes from the bigint module, all 112 of them... This was responsible for increasing the code size of the module by almost 100x and accounts for roughly 95% of the previous build time of libextra.