-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
extra::term overhaul #6826
Merged
Merged
extra::term overhaul #6826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
return Ok(Terminal {out: out, ti: inf, color_supported: cs}); | ||
} | ||
fn fg(&self, color: u8) { | ||
self.out.write(expand(*self.ti.strings.find(&~"setaf").unwrap(), [Number(color as int)], [], [])); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will be more efficient (avoids allocation) with find_equiv
.
r? @thestinger |
bors
added a commit
that referenced
this pull request
May 31, 2013
This will let *everyone* (non-windows, at least) who can see colors see the glorious colors rustc produces.
bors
added a commit
that referenced
this pull request
Jun 3, 2013
This will let *everyone* (non-windows, at least) who can see colors see the glorious colors rustc produces.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Mar 12, 2021
Refactor: arrange lints in `methods` module This PR arranges methods lints so that they can be accessed more easily. Basically, I refactored them following the instruction described in rust-lang#6680. changelog: Move lints in methods module into their own modules.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will let everyone (non-windows, at least) who can see colors see the glorious colors rustc produces.