Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 7 pull requests #68635

Merged
merged 14 commits into from
Jan 29, 2020
Merged

Rollup of 7 pull requests #68635

merged 14 commits into from
Jan 29, 2020

Commits on Jan 28, 2020

  1. Configuration menu
    Copy the full SHA
    979f5b4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9150b8e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    efb1acf View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    79d8c9b View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    0754461 View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2020

  1. Document that write_all will not call write if given an empty buffer

    Some types of Write instances have a semantic meaning associated with
    writing an empty buffer, such as sending an empty packet. This works
    when calling `write` directly, and supplying an empty buffer. However,
    calling `write_all` on an empty buffer will simply never call `write`,
    because `write_all` assumes it has no work to do.
    
    Document this behavior, to help prospective users of
    datagram-packet-style Write instances.
    joshtriplett committed Jan 29, 2020
    Configuration menu
    Copy the full SHA
    9bb2a50 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f722964 View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#67722 - petertodd:2019-improve-any-comment,…

    … r=Mark-Simulacrum
    
    Minor: note how Any is an unsafe trait in SAFETY comments
    
    Motivation: helpful to people like myself reading the standard library source to better understand how to use Any, especially if we do go ahead with rust-lang#67562 and make it an unsafe trait.
    JohnTitor committed Jan 29, 2020
    Configuration menu
    Copy the full SHA
    36fd7b9 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#68586 - Centril:repr-deny, r=pnkfelix

    Make conflicting_repr_hints a deny-by-default c-future-compat lint
    
    Closes rust-lang#68428.
    cc rust-lang#68585.
    
    r? @petrochenkov @pnkfelix
    JohnTitor committed Jan 29, 2020
    Configuration menu
    Copy the full SHA
    8f1857a View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#68598 - GuillaumeGomez:fix-null-synthetic_i…

    …mplementors, r=ollie27
    
    Fix null synthetic_implementors error
    
    Fixes rust-lang#68584.
    
    r? @ollie27
    
    cc @kinnison
    JohnTitor committed Jan 29, 2020
    Configuration menu
    Copy the full SHA
    ed351e2 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#68603 - kornelski:patch-1, r=pietroalbini

    Changelog: Demonstrate final build-override syntax
    JohnTitor committed Jan 29, 2020
    Configuration menu
    Copy the full SHA
    95e7342 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#68609 - Zoxc:lld-msvc, r=alexcrichton

    Set lld flavor for MSVC to link.exe
    
    This enables linking with LLD on Windows with just `-C linker=rust-lld` instead of needing `-C linker=rust-lld -C linker-flavor=lld-link`.
    JohnTitor committed Jan 29, 2020
    Configuration menu
    Copy the full SHA
    288cabd View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#68611 - MichaelBurge:master, r=estebank

    Correct ICE caused by macros generating invalid spans.
    
    Closes rust-lang#68605
    JohnTitor committed Jan 29, 2020
    Configuration menu
    Copy the full SHA
    0e36558 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#68627 - joshtriplett:write-all-none, r=Dyla…

    …n-DPC
    
    Document that write_all will not call write if given an empty buffer
    
    Some types of Write instances have a semantic meaning associated with
    writing an empty buffer, such as sending an empty packet. This works
    when calling `write` directly, and supplying an empty buffer. However,
    calling `write_all` on an empty buffer will simply never call `write`,
    because `write_all` assumes it has no work to do.
    
    Document this behavior, to help prospective users of
    datagram-packet-style Write instances.
    JohnTitor committed Jan 29, 2020
    Configuration menu
    Copy the full SHA
    50df788 View commit details
    Browse the repository at this point in the history