Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation to compiler intrinsics #68682

Merged
merged 8 commits into from
Mar 2, 2020

Conversation

LeSeulArtichaut
Copy link
Contributor

This adds documentation to the compiler intrinsics having stable standard implementations.

Relates to #34338 (cc @bstrie)

r? @steveklabnik (for reassignment?)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 30, 2020
@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2020-01-30T23:17:12.1279295Z ========================== Starting Command Output ===========================
2020-01-30T23:17:12.1280521Z [command]/bin/bash --noprofile --norc /home/vsts/work/_temp/d7634c95-b756-4a3a-bab3-b16808a6109c.sh
2020-01-30T23:17:12.1280547Z 
2020-01-30T23:17:12.1282832Z ##[section]Finishing: Disable git automatic line ending conversion
2020-01-30T23:17:12.1287573Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/68682/merge to s
2020-01-30T23:17:12.1288991Z Task         : Get sources
2020-01-30T23:17:12.1289020Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-01-30T23:17:12.1289047Z Version      : 1.0.0
2020-01-30T23:17:12.1289075Z Author       : Microsoft
---
2020-01-30T23:17:12.8999073Z ##[command]git remote add origin https://github.com/rust-lang/rust
2020-01-30T23:17:12.9076816Z ##[command]git config gc.auto 0
2020-01-30T23:17:12.9136811Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2020-01-30T23:17:12.9291651Z ##[command]git config --get-all http.proxy
2020-01-30T23:17:12.9351952Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/68682/merge:refs/remotes/pull/68682/merge
---
2020-01-31T00:03:32.2490248Z .................................................................................................... 1700/9558
2020-01-31T00:03:36.8288548Z .................................................................................................... 1800/9558
2020-01-31T00:03:48.6365257Z .........................i.......................................................................... 1900/9558
2020-01-31T00:03:55.2914899Z .................................................................................................... 2000/9558
2020-01-31T00:04:08.8579161Z ...............iiiii................................................................................ 2100/9558
2020-01-31T00:04:18.2009309Z .................................................................................................... 2300/9558
2020-01-31T00:04:20.4415839Z .................................................................................................... 2400/9558
2020-01-31T00:04:25.3234305Z .................................................................................................... 2500/9558
2020-01-31T00:04:43.8087989Z .................................................................................................... 2600/9558
---
2020-01-31T00:07:03.1317436Z .................................................................................................... 4800/9558
2020-01-31T00:07:07.6934454Z ..........................................................i...............i......................... 4900/9558
2020-01-31T00:07:14.8514360Z .................................................................................................... 5000/9558
2020-01-31T00:07:21.9132067Z .................................................................................................... 5100/9558
2020-01-31T00:07:26.2688585Z .i.................................................................................................. 5200/9558
2020-01-31T00:07:35.8769829Z ..........................................................................ii.ii........i...i........ 5300/9558
2020-01-31T00:07:43.5034769Z ............i....................................................................................... 5500/9558
2020-01-31T00:07:52.3243605Z .................................................................................................... 5600/9558
2020-01-31T00:07:58.0013277Z .............................................................i...................................... 5700/9558
2020-01-31T00:08:04.4462309Z .................................................................................................... 5800/9558
2020-01-31T00:08:04.4462309Z .................................................................................................... 5800/9558
2020-01-31T00:08:11.6246459Z .................................................................................................... 5900/9558
2020-01-31T00:08:19.3784824Z ....................................................ii...i..ii...........i.......................... 6000/9558
2020-01-31T00:08:39.2967539Z .................................................................................................... 6200/9558
2020-01-31T00:08:43.6582877Z .................................................................................................... 6300/9558
2020-01-31T00:08:43.6582877Z .................................................................................................... 6300/9558
2020-01-31T00:08:47.6938870Z ................................................................................i..ii............... 6400/9558
2020-01-31T00:09:11.1500722Z .................................................................................................... 6600/9558
2020-01-31T00:09:16.5221315Z ........................................................i........................................... 6700/9558
2020-01-31T00:09:18.4811912Z .................................................................................................... 6800/9558
2020-01-31T00:09:20.5037192Z .......................................................i............................................ 6900/9558
---
2020-01-31T00:10:49.4983458Z .................................................................................................... 7600/9558
2020-01-31T00:10:54.3741735Z .................................................................................................... 7700/9558
2020-01-31T00:11:00.3415559Z .................................................................................................... 7800/9558
2020-01-31T00:11:10.1632242Z .................................................................................................... 7900/9558
2020-01-31T00:11:15.5053687Z ...........iiiiiii.i................................................................................ 8000/9558
2020-01-31T00:11:28.5157468Z .................................................................................................... 8200/9558
2020-01-31T00:11:38.3160095Z .................................................................................................... 8300/9558
2020-01-31T00:11:50.5943609Z .................................................................................................... 8400/9558
2020-01-31T00:11:56.7564886Z .................................................................................................... 8500/9558
---
2020-01-31T00:14:03.0265984Z  finished in 6.742
2020-01-31T00:14:03.0454293Z Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-01-31T00:14:03.2247476Z 
2020-01-31T00:14:03.2247737Z running 169 tests
2020-01-31T00:14:06.0320060Z iiii......i........ii..iiii...i....i...........i............i..i..................i....i............ 100/169
2020-01-31T00:14:07.9698108Z i.i.i...iii..iiiiiiiiii.......................iii............ii......
2020-01-31T00:14:07.9702415Z 
2020-01-31T00:14:07.9708109Z  finished in 4.925
2020-01-31T00:14:07.9900165Z Check compiletest suite=codegen-units mode=codegen-units (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-01-31T00:14:08.1477611Z 
---
2020-01-31T00:14:09.9090608Z  finished in 1.919
2020-01-31T00:14:09.9273251Z Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-01-31T00:14:10.0643746Z 
2020-01-31T00:14:10.0644041Z running 9 tests
2020-01-31T00:14:10.0644733Z iiiiiiiii
2020-01-31T00:14:10.0645061Z 
2020-01-31T00:14:10.0645102Z  finished in 0.136
2020-01-31T00:14:10.0814408Z Check compiletest suite=incremental mode=incremental (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-01-31T00:14:10.2513933Z 
---
2020-01-31T00:14:27.6899205Z  finished in 17.608
2020-01-31T00:14:27.7111987Z Check compiletest suite=debuginfo mode=debuginfo (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-01-31T00:14:27.8815641Z 
2020-01-31T00:14:27.8815864Z running 116 tests
2020-01-31T00:14:39.7761622Z iiiii..i.....i..i...i..i.i.i..i..i..ii....i.i....ii..........iiii..........i.....i..i.......ii.i.ii. 100/116
2020-01-31T00:14:41.4424399Z ....iiii.....ii.
2020-01-31T00:14:41.4425088Z 
2020-01-31T00:14:41.4427187Z  finished in 13.731
2020-01-31T00:14:41.4433891Z Uplifting stage1 rustc (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-01-31T00:14:41.4434232Z Copying stage2 rustc from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
---
2020-01-31T00:25:50.6396851Z 
2020-01-31T00:25:50.6397736Z    Doc-tests core
2020-01-31T00:25:54.5970392Z 
2020-01-31T00:25:54.5971142Z running 2467 tests
2020-01-31T00:26:02.4450549Z ......iiiii......................................................................................... 100/2467
2020-01-31T00:26:09.9504829Z ..................................................................................ii................ 200/2467
2020-01-31T00:26:26.9768397Z .................i.................................................................................. 400/2467
2020-01-31T00:26:26.9768397Z .................i.................................................................................. 400/2467
2020-01-31T00:26:34.8032142Z ..................................................................i..i..................iiii........ 500/2467
2020-01-31T00:26:48.3323405Z .................................................................................................... 700/2467
2020-01-31T00:26:55.4811274Z .................................................................................................... 800/2467
2020-01-31T00:27:02.5777456Z .................................................................................................... 900/2467
2020-01-31T00:27:09.7646797Z .................................................................................................... 1000/2467
---
2020-01-31T00:29:51.5448676Z .................................................thread '<unnamed>' panicked at 'explicit panic', src/libstd/io/stdio.rs:871:13
2020-01-31T00:29:51.5454577Z ... 300/760
2020-01-31T00:29:51.6076386Z .................................................................................................... 400/760
2020-01-31T00:29:53.6894258Z .................................................................................................... 500/760
2020-01-31T00:29:53.7224123Z .................thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libstd/sync/mpsc/mod.rs:2741:22
2020-01-31T00:29:53.7236069Z ....thread 'thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: "SendError(..)"', src/libstd/sync/mpsc/mod.rs:2766:17
2020-01-31T00:29:53.7241515Z <unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libstd/sync/mpsc/mod.rs.:2778:21
2020-01-31T00:29:53.7252621Z ......thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libstd/sync/mpsc/mod.rs:2645:13
2020-01-31T00:29:53.9367774Z ..........................................thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libstd/sync/mpsc/mod.rs:1997:22
2020-01-31T00:29:53.9428603Z ....thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError.', src/libstd/sync/mpsc/mod.rs:2034:thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libstd/sync/mpsc/mod.rs:1916:......13
2020-01-31T00:29:53.9654815Z ................... 600/760
2020-01-31T00:29:55.9953276Z ....................thread '<unnamed>' panicked at 'explicit panic', src/libstd/sync/mutex.rs:633:13
2020-01-31T00:29:55.9961409Z ...thread '<unnamed>' panicked at 'test panic in inner thread to poison mutex', src/libstd/sync/mutex.rs:587:13
2020-01-31T00:29:55.9963470Z .thread '<unnamed>' panicked at 'test panic in inner thread to poison mutex', src/libstd/sync/mutex.rs:563:13
---
2020-01-31T00:30:04.8397103Z 
2020-01-31T00:30:04.8397407Z running 1007 tests
2020-01-31T00:30:18.6556225Z i................................................................................................... 100/1007
2020-01-31T00:30:26.5928763Z .................................................................................................... 200/1007
2020-01-31T00:30:32.1808454Z ...................iii.....i......i...i......i...................................................... 300/1007
2020-01-31T00:30:36.0938473Z .................................................................................................... 400/1007
2020-01-31T00:30:41.4236218Z ..........................................i..i.....................................ii............... 500/1007
2020-01-31T00:30:51.3819664Z .................................................................................................... 700/1007
2020-01-31T00:30:51.3819664Z .................................................................................................... 700/1007
2020-01-31T00:30:56.4569025Z .................................iiii............................................................... 800/1007
2020-01-31T00:31:07.6026242Z .................................................................................................... 900/1007
2020-01-31T00:31:12.8324372Z .......................................................iiii......................................... 1000/1007
2020-01-31T00:31:13.0840155Z test result: ok. 987 passed; 0 failed; 20 ignored; 0 measured; 0 filtered out
2020-01-31T00:31:13.0842037Z 
2020-01-31T00:31:13.0943646Z  finished in 132.277
2020-01-31T00:31:13.0953683Z Testing term stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
---
2020-01-31T00:44:55.0703423Z Rustbook (x86_64-unknown-linux-gnu) - edition-guide
2020-01-31T00:44:55.8930465Z Building stage0 tool linkchecker (x86_64-unknown-linux-gnu)
2020-01-31T00:44:55.8988125Z    Compiling linkchecker v0.1.0 (/checkout/src/tools/linkchecker)
2020-01-31T00:44:56.6605482Z     Finished release [optimized] target(s) in 1.24s
2020-01-31T00:44:57.7019964Z core/intrinsics/fn.ctlz.html:5: broken link fragment `#method.leading_zeroes` pointing to `std/primitive.u32.html`
2020-01-31T00:44:57.7170046Z core/intrinsics/index.html:609: broken link fragment `#method.leading_zeroes` pointing to `std/primitive.u32.html`
2020-01-31T00:44:59.5280307Z std/intrinsics/fn.ctlz.html:5: broken link fragment `#method.leading_zeroes` pointing to `std/primitive.u32.html`
2020-01-31T00:44:59.5421439Z std/intrinsics/index.html:609: broken link fragment `#method.leading_zeroes` pointing to `std/primitive.u32.html`
2020-01-31T00:45:03.2207371Z thread 'main' panicked at 'found some broken links', src/tools/linkchecker/main.rs:43:9
2020-01-31T00:45:03.2242632Z 
2020-01-31T00:45:03.2242945Z 
2020-01-31T00:45:03.2244161Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/linkchecker" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/linkchecker" "/checkout/obj/build/x86_64-unknown-linux-gnu/doc"
2020-01-31T00:45:03.2244415Z expected success, got: exit code: 101
---
2020-01-31T00:45:03.2325554Z   local time: Fri Jan 31 00:45:03 UTC 2020
2020-01-31T00:45:03.7775426Z   network time: Fri, 31 Jan 2020 00:45:03 GMT
2020-01-31T00:45:03.7778084Z == end clock drift check ==
2020-01-31T00:45:06.5374517Z 
2020-01-31T00:45:06.5431372Z ##[error]Bash exited with code '1'.
2020-01-31T00:45:06.5440168Z ##[section]Finishing: Run build
2020-01-31T00:45:06.5465327Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/68682/merge to s
2020-01-31T00:45:06.5466979Z Task         : Get sources
2020-01-31T00:45:06.5467021Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-01-31T00:45:06.5467078Z Version      : 1.0.0
2020-01-31T00:45:06.5467115Z Author       : Microsoft
2020-01-31T00:45:06.5467115Z Author       : Microsoft
2020-01-31T00:45:06.5467155Z Help         : [More Information](https://go.microsoft.com/fwlink/?LinkId=798199)
2020-01-31T00:45:06.5467216Z ==============================================================================
2020-01-31T00:45:06.9058147Z Cleaning any cached credential from repository: rust-lang/rust (GitHub)
2020-01-31T00:45:06.9086249Z ##[section]Finishing: Checkout rust-lang/rust@refs/pull/68682/merge to s
2020-01-31T00:45:06.9198666Z Cleaning up task key
2020-01-31T00:45:06.9200606Z Start cleaning up orphan processes.
2020-01-31T00:45:06.9307900Z Terminate orphan process: pid (4823) (python)
2020-01-31T00:45:06.9521491Z ##[section]Finishing: Finalize Job

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

src/libcore/intrinsics.rs Outdated Show resolved Hide resolved
src/libcore/intrinsics.rs Show resolved Hide resolved
src/libcore/intrinsics.rs Show resolved Hide resolved
src/libcore/intrinsics.rs Outdated Show resolved Hide resolved
src/libcore/intrinsics.rs Outdated Show resolved Hide resolved
@LeSeulArtichaut
Copy link
Contributor Author

@rustbot modify labels: +T-doc

@rustbot rustbot added the A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools label Feb 2, 2020
@bors
Copy link
Contributor

bors commented Feb 6, 2020

☔ The latest upstream changes (presumably #68861) made this pull request unmergeable. Please resolve the merge conflicts.

@LeSeulArtichaut LeSeulArtichaut force-pushed the stable-intrinsics branch 2 times, most recently from e02bbd7 to c9ac80c Compare February 11, 2020 21:23
@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2020-02-11T21:35:11.5898389Z ========================== Starting Command Output ===========================
2020-02-11T21:35:11.5899930Z [command]/bin/bash --noprofile --norc /home/vsts/work/_temp/abe5f013-ffa5-459a-84fc-f28313f39746.sh
2020-02-11T21:35:11.5899964Z 
2020-02-11T21:35:11.5902841Z ##[section]Finishing: Disable git automatic line ending conversion
2020-02-11T21:35:11.5907645Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/68682/merge to s
2020-02-11T21:35:11.5909337Z Task         : Get sources
2020-02-11T21:35:11.5909366Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-02-11T21:35:11.5909395Z Version      : 1.0.0
2020-02-11T21:35:11.5909597Z Author       : Microsoft
---
2020-02-11T21:35:12.4962817Z ##[command]git remote add origin https://github.com/rust-lang/rust
2020-02-11T21:35:12.5044668Z ##[command]git config gc.auto 0
2020-02-11T21:35:12.5119474Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2020-02-11T21:35:12.5193345Z ##[command]git config --get-all http.proxy
2020-02-11T21:35:12.5389681Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/68682/merge:refs/remotes/pull/68682/merge
---
2020-02-11T21:41:24.4594219Z Found 0 error codes with no tests
2020-02-11T21:41:24.4594285Z Done!
2020-02-11T21:41:24.4594311Z 
2020-02-11T21:41:24.4594367Z 
2020-02-11T21:41:24.4595160Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor"
2020-02-11T21:41:24.4595294Z 
2020-02-11T21:41:24.4595318Z 
2020-02-11T21:41:24.4595382Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
2020-02-11T21:41:24.4595442Z Build completed unsuccessfully in 0:01:40
2020-02-11T21:41:24.4595442Z Build completed unsuccessfully in 0:01:40
2020-02-11T21:41:24.4641379Z == clock drift check ==
2020-02-11T21:41:24.4693402Z   local time: Tue Feb 11 21:41:24 UTC 2020
2020-02-11T21:41:24.6242038Z   network time: Tue, 11 Feb 2020 21:41:24 GMT
2020-02-11T21:41:24.6244039Z == end clock drift check ==
2020-02-11T21:41:25.3461686Z 
2020-02-11T21:41:25.3554429Z ##[error]Bash exited with code '1'.
2020-02-11T21:41:25.3565863Z ##[section]Finishing: Run build
2020-02-11T21:41:25.3580319Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/68682/merge to s
2020-02-11T21:41:25.3582308Z Task         : Get sources
2020-02-11T21:41:25.3582367Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-02-11T21:41:25.3582557Z Version      : 1.0.0
2020-02-11T21:41:25.3582593Z Author       : Microsoft
2020-02-11T21:41:25.3582593Z Author       : Microsoft
2020-02-11T21:41:25.3582633Z Help         : [More Information](https://go.microsoft.com/fwlink/?LinkId=798199)
2020-02-11T21:41:25.3582694Z ==============================================================================
2020-02-11T21:41:25.7497371Z Cleaning any cached credential from repository: rust-lang/rust (GitHub)
2020-02-11T21:41:25.7542531Z ##[section]Finishing: Checkout rust-lang/rust@refs/pull/68682/merge to s
2020-02-11T21:41:25.7655174Z Cleaning up task key
2020-02-11T21:41:25.7656113Z Start cleaning up orphan processes.
2020-02-11T21:41:25.7765902Z Terminate orphan process: pid (3575) (python)
2020-02-11T21:41:25.7941226Z ##[section]Finishing: Finalize Job

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@JohnCSimon JohnCSimon added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 16, 2020
@JohnCSimon
Copy link
Member

Ping from triage: @LeSeulArtichaut - if you've addressed the changes from steveklabnik, can you please mark it as completed so it can be reviewed?

@LeSeulArtichaut
Copy link
Contributor Author

@JohnCSimon I thought I already marked it as resolved... I can't find a way to mark the entire review as completed, have I missed something?

@Dylan-DPC-zz
Copy link

@bors r=steveklabnik rollup

@bors
Copy link
Contributor

bors commented Mar 2, 2020

📌 Commit b22d370 has been approved by steveklabnik

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 2, 2020
bors added a commit that referenced this pull request Mar 2, 2020
Rollup of 6 pull requests

Successful merges:

 - #68682 (Add documentation to compiler intrinsics)
 - #69544 (Unrevert "Remove `checked_add` in `Layout::repeat`")
 - #69617 (constify mem::forget)
 - #69622 (Rename `syntax` in librustc_ast/README.md)
 - #69623 (stash API: remove panic to fix ICE.)
 - #69624 (Toolstate: Don't block beta week on already broken tools.)

Failed merges:

 - #69626 (Toolstate: don't duplicate nightly tool list.)

r? @ghost
@bors bors merged commit ffb6d75 into rust-lang:master Mar 2, 2020
@LeSeulArtichaut LeSeulArtichaut deleted the stable-intrinsics branch April 29, 2020 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants