Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 9 pull requests #68893

Merged
merged 21 commits into from
Feb 6, 2020
Merged

Rollup of 9 pull requests #68893

merged 21 commits into from
Feb 6, 2020

Commits on Feb 4, 2020

  1. use def_path_str for missing_debug_impls message

    The lint message will now use the full, correct path to the `Debug`
    trait, even in `no_std`.
    euclio committed Feb 4, 2020
    Configuration menu
    Copy the full SHA
    c0a110f View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2020

  1. Configuration menu
    Copy the full SHA
    c0b7b41 View commit details
    Browse the repository at this point in the history
  2. parser: merge fn grammars wrt. bodies & headers

    also refactor `FnKind` and `visit_assoc_item` visitors
    Centril committed Feb 5, 2020
    Configuration menu
    Copy the full SHA
    b2c6eeb View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4fc4b95 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    67c29ed View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    ce6cd67 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    9ac68e1 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    9a4eac3 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    c182461 View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2020

  1. Remove RefCell usage from ObligationForest.

    It's not needed.
    nnethercote committed Feb 6, 2020
    Configuration menu
    Copy the full SHA
    6ad725e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d8cf950 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    bf26933 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#68691 - nnethercote:rm-RefCell-from-Obligat…

    …ionForest, r=nikomatsakis
    
    Remove `RefCell` usage from `ObligationForest`.
    
    It's not needed.
    
    This doesn't affect performance, it just simplifies the code a little.
    
    r? @nikomatsakis
    Dylan-DPC authored Feb 6, 2020
    Configuration menu
    Copy the full SHA
    a1478b7 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#68751 - Tyg13:unused_parens_const_static, r…

    …=Centril
    
    Implement `unused_parens` for `const` and `static` items
    
    Fixes rust-lang#67942
    Dylan-DPC authored Feb 6, 2020
    Configuration menu
    Copy the full SHA
    bf13861 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#68788 - Centril:unified-fn-bodies, r=petroc…

    …henkov
    
    Towards unified `fn` grammar
    
    Part of rust-lang#68728.
    
    - Syntactically, `fn` items in `extern { ... }` blocks can now have bodies (`fn foo() { ... }` as opposed to `fn foo();`). As above, we use semantic restrictions instead.
    
    - Syntactically, `fn` items in free contexts (directly in a file or a module) can now be without bodies (`fn foo();` as opposed to `fn foo() { ... }`. As above, we use semantic restrictions instead, including for non-ident parameter patterns.
    
    - We move towards unifying the `fn` front matter; this is fully realized in rust-lang#68728.
    
    r? @petrochenkov
    Dylan-DPC authored Feb 6, 2020
    Configuration menu
    Copy the full SHA
    424304a View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#68837 - jonas-schievink:assoc-item-lookup-2…

    …, r=estebank
    
    Make associated item collection a query
    
    Before this change, every time associated items were iterated over (which rustc does *a lot* – this can probably be further optimized), there would be N+1 queries to fetch all assoc. items. Now there's just one after they've been computed once.
    Dylan-DPC authored Feb 6, 2020
    Configuration menu
    Copy the full SHA
    f6bfdf4 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#68842 - Centril:issue-68785, r=estebank

    or_patterns: add regression test for rust-lang#68785
    
    Fixes rust-lang#68785.
    
    (Fixed by rust-lang#67668.)
    
    cc rust-lang#54883
    r? @estebank
    Dylan-DPC authored Feb 6, 2020
    Configuration menu
    Copy the full SHA
    226a8e2 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#68844 - euclio:debug-impl-def-path, r=petro…

    …chenkov
    
    use def_path_str for missing_debug_impls message
    
    The lint message will now use the full, correct path to the `Debug`
    trait, even in `no_std`.
    Dylan-DPC authored Feb 6, 2020
    Configuration menu
    Copy the full SHA
    16e4e8f View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#68845 - dwrensha:fix-68783, r=estebank

    stop using BytePos for computing spans in librustc_parse/parser/mod.rs
    
    Computing spans using logic such as `self.token.span.lo() + BytePos(1)` can cause internal compiler errors like rust-lang#68730 when non-ascii characters are given as input.
    
    rust-lang#68735 partially addressed this problem, but only for one case. Moreover, its usage of `next_point()` does not actually align with what `bump_with()` expects. For example, given the token `>>=`, we should pass the span consisting of the final two characters `>=`, but `next_point()` advances the span beyond the end of the `=`.
    
    This pull request instead computes the start of the new span by doing `start_point(self.token.span).hi()`. This matches `self.token.span.lo() + BytePos(1)` in the common case where the characters are ascii, and it gracefully handles multibyte characters.
    
    Fixes rust-lang#68783.
    Dylan-DPC authored Feb 6, 2020
    Configuration menu
    Copy the full SHA
    ec24833 View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#68869 - GuillaumeGomez:err-explanation-e027…

    …1, r=Dylan-DPC
    
    clean up E0271 explanation
    
    r? @Dylan-DPC
    Dylan-DPC authored Feb 6, 2020
    Configuration menu
    Copy the full SHA
    2210d3f View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#68880 - JohnTitor:issue-non-zero, r=Dylan-DPC

    Forbid using `0` as issue number
    
    Fixes rust-lang#67496
    
    r? @Centril
    Dylan-DPC authored Feb 6, 2020
    Configuration menu
    Copy the full SHA
    1ad674a View commit details
    Browse the repository at this point in the history