Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 4 pull requests #68996

Closed
wants to merge 14 commits into from

Commits on Feb 6, 2020

  1. Configuration menu
    Copy the full SHA
    b82f6c5 View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2020

  1. Configuration menu
    Copy the full SHA
    73936ab View commit details
    Browse the repository at this point in the history
  2. add regression test

    basil-cow committed Feb 7, 2020
    Configuration menu
    Copy the full SHA
    ab6ea2b View commit details
    Browse the repository at this point in the history
  3. add hir printing

    basil-cow committed Feb 7, 2020
    Configuration menu
    Copy the full SHA
    bf82582 View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2020

  1. Configuration menu
    Copy the full SHA
    66fd4e6 View commit details
    Browse the repository at this point in the history
  2. Use associated_items query in impl overlap check

    This reduces the number of `associated_item` queries done here.
    jonas-schievink committed Feb 8, 2020
    Configuration menu
    Copy the full SHA
    f416573 View commit details
    Browse the repository at this point in the history
  3. Add a fast path to inherent impl overlap check

    Quickly skip impls that do not define any items with the same name
    jonas-schievink committed Feb 8, 2020
    Configuration menu
    Copy the full SHA
    52f7711 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    e0cb1ae View commit details
    Browse the repository at this point in the history
  5. Add missing import

    jonas-schievink committed Feb 8, 2020
    Configuration menu
    Copy the full SHA
    58a9284 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2020

  1. Reduce the number of RefCells in InferCtxt.

    `InferCtxt` contains six structures within `RefCell`s. Every time we
    create and dispose of (commit or rollback) a snapshot we have to
    `borrow_mut` each one of them.
    
    This commit moves the six structures under a single `RefCell`, which
    gives significant speed-ups by reducing the number of `borrow_mut`
    calls. To avoid runtime errors I had to reduce the lifetimes of dynamic
    borrows in a couple of places.
    nnethercote committed Feb 9, 2020
    Configuration menu
    Copy the full SHA
    e183f82 View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#68694 - nnethercote:reduce-RefCells-in-Infe…

    …rCtxt, r=varkor
    
    Reduce the number of `RefCell`s in `InferCtxt`.
    
    `InferCtxt` contains six structures within `RefCell`s. Every time we
    create and dispose of (commit or rollback) a snapshot we have to
    `borrow_mut` each one of them.
    
    This commit moves the six structures under a single `RefCell`, which
    gives significant speed-ups by reducing the number of `borrow_mut`
    calls. To avoid runtime errors I had to reduce the lifetimes of dynamic
    borrows in a couple of places.
    
    r? @varkor
    Dylan-DPC authored Feb 9, 2020
    Configuration menu
    Copy the full SHA
    8fabe85 View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#68881 - eddyb:always-preserve-dbg-vars, r=n…

    …agisa
    
    rustc_codegen_llvm: always set AlwaysPreserve on all debuginfo variables
    
    Making this depend on the optimization level appears to have been a copy-paste mistake (other LLVM functions called in this module also take a `bool` argument, but there it means something unrelated).
    Also see rust-lang#8855 (comment).
    
    I don't believe we have any reason to let LLVM omit user variables from DWARF, and we were already setting this to `true` when LLVM *could* optimize them away, so this PR should have no effect anyway.
    
    r? @michaelwoerister or @nagisa cc @rkruppe @nikomatsakis
    Dylan-DPC authored Feb 9, 2020
    Configuration menu
    Copy the full SHA
    9801a59 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#68911 - jonas-schievink:inherent-overlap, r…

    …=petrochenkov
    
    Speed up the inherent impl overlap check
    
    This gives a ~7% improvement in compile times for the stm32f0(x2) crate.
    
    Also addresses @eddyb's comment in rust-lang#68837 (comment).
    Dylan-DPC authored Feb 9, 2020
    Configuration menu
    Copy the full SHA
    ea48820 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#68913 - Areredify:gat_pretty, r=cramertj

    Pretty-print generic params and where clauses on associated types
    
    closes rust-lang#67509
    Dylan-DPC authored Feb 9, 2020
    Configuration menu
    Copy the full SHA
    96c6398 View commit details
    Browse the repository at this point in the history