Don't rustfmt check the vendor directory. #69047
Conversation
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
I would prefer if the rustfmt check was restricted to the |
| @@ -7,6 +7,7 @@ merge_derives = false | |||
| # tidy only checks files which are not ignored, each entry follows gitignore style | |||
| ignore = [ | |||
| "build", | |||
| "/vendor/", | |||
There was a problem hiding this comment.
double check: should there be a leading / here?
There was a problem hiding this comment.
Yea, it's a gitignore pattern:
foo— any file or directory named foo anywhere in the repo.foo/— any directory named foo anywhere in the repo./foo— a file or directory named foo at the root of the repo./foo/— a directory named foo at the root of the repo.
The vendor directory is created in the root.
There was a problem hiding this comment.
Ah ok; so not the root of the filesystem :D
|
@bors r+ rollup |
|
📌 Commit 6575abc has been approved by |
bors
added
S-waiting-on-bors
|
r? @Centril |
|
We can likely revise to ignore all but src; I wrote it this way to avoid accidentally not checking some directory, but there's no expectation in my mind that we would add such a directory. |
Don't rustfmt check the vendor directory. I need to be able to run `x.py tidy` to do license checks (which requires vendored dependencies). However, when vendoring is enabled, it wants to rustfmt check the entire vendor directory, which doesn't work.
Rollup of 8 pull requests Successful merges: - #66498 (Remove unused feature gates) - #68816 (Tweak borrow error on `FnMut` when `Fn` is expected) - #68824 (Enable Control Flow Guard in rustbuild) - #69022 (traits: preallocate 2 Vecs of known initial size) - #69031 (Use `dyn Trait` more in tests) - #69044 (Don't run coherence twice for future-compat lints) - #69047 (Don't rustfmt check the vendor directory.) - #69055 (Clean up E0307 explanation) Failed merges: r? @ghost
I need to be able to run
x.py tidyto do license checks (which requires vendored dependencies). However, when vendoring is enabled, it wants to rustfmt check the entire vendor directory, which doesn't work.