Rollup of 5 pull requests #69193
Closed
Rollup of 5 pull requests #69193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old code hard-coded the transfer function for the initialized places analyses.
…matthewjasper Don't give invalid suggestion on desugared span.
…ls2, r=eddyb Use `ResultsCursor` for `elaborate_drops` Some cleanup after rust-lang#68241. The old code was using a custom cursor-like struct called `InitializationData`.
…thewjasper Don't print block exit state in dataflow graphviz if unchanged A small quality-of-life improvement I was using while working on rust-lang#68528. It's pretty common to have a lot of zero-statement basic blocks, especially before a `SimplifyCfg` pass is run. When the dataflow state was dense, these blocks could take up a lot of vertical space since the full flow state was printed on both entry and exit. After this PR, we only print a block's exit state if it differs from that block's entry state. Take a look at the two basic blocks on the left. Before:  After: 
Rename `FunctionRetTy` to `FnRetTy` As per FIXME comment r? @Centril
[tiny] parser: `macro_rules` is a weak keyword r? @Centril
|
@bors r+ rollup=never p=6 |
|
📌 Commit 5f6432b has been approved by |
bors
added
the
S-waiting-on-bors
|
@bors retry |
|
⌛ Testing commit 5f6432b with merge 69f150e721d4cb34e9870a4324641a0a0cb603d7... |
|
Your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem. Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
💔 Test failed - checks-azure |
bors
added
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
ResultsCursorforelaborate_drops#69156 (UseResultsCursorforelaborate_drops)FunctionRetTytoFnRetTy#69179 (RenameFunctionRetTytoFnRetTy)macro_rulesis a weak keyword #69186 ([tiny] parser:macro_rulesis a weak keyword)Failed merges:
r? @ghost