Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 10 pull requests #69212

Closed
wants to merge 24 commits into from
Closed

Conversation

JohnTitor
Copy link
Member

Successful merges:

Failed merges:

r? @ghost

This might spare someone else a little time searching the stdlib for unicode/grapheme support.
s/for reads and writes/for both ...
Added missing condition:
`dst` must be readable
For all methods which read a value of type T, `read`, `read_unaligned`,
`read_volatile` and `replace`, added missing
constraint:
The value they point to must be properly initialized
Without `Compiletest.path` set running `x.py test src/test/rustdoc-js` would run the `rustdoc-js` test suite with everything filtered out.

As this was the only place setting `Compiletest.path` to `None` this removes the `Option` wrapper as well.
Added missing conditions:
- Valid for writes
- Valid for destructing
Updating str.chars docs to mention crates.io.

This might spare someone else a little time searching the stdlib for unicode/grapheme support.
Improve #Safety of various methods in core::ptr

For `read`, `read_unaligned`,`read_volatile`, `replace`, and `drop_in_place`:

- The value they point to must be properly initialized

For `replace`, additionally:

- The pointer must be readable
macOS: avoid calling pthread_self() twice
Rename `FunctionRetTy` to `FnRetTy`

As per FIXME comment

r? @Centril
[tiny] parser: `macro_rules` is a weak keyword

r? @Centril
…k-Simulacrum

Fix running rustdoc-js test suite individually

Without `Compiletest.path` set running `x.py test src/test/rustdoc-js` would run the `rustdoc-js` test suite with everything filtered out.

As this was the only place setting `Compiletest.path` to `None` this removes the `Option` wrapper as well.
…b,Zoxc

Fix printing of `Yield` terminator

Addresses the bug found in rust-lang#69039 (comment)
…-Simulacrum

Allow whitespaces in revision flags

Allow whitespaces in revision flags, like `// [foo]`.

Fixes rust-lang#69183
…acrum

debug_assert a few more raw pointer methods

Fixes rust-lang#53871
@JohnTitor
Copy link
Member Author

@bors r+ p=10 rollup=never

@bors
Copy link
Contributor

bors commented Feb 16, 2020

📌 Commit f34cf8d has been approved by JohnTitor

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Feb 16, 2020
@JohnTitor JohnTitor added the rollup A PR which is a rollup label Feb 16, 2020
@bors
Copy link
Contributor

bors commented Feb 16, 2020

⌛ Testing commit f34cf8d with merge e2ddf3fd8a66f9e5180ff10535eaba17ebd93aa4...

@rust-highfive
Copy link
Collaborator

The job x86_64-gnu of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2020-02-16T20:17:13.3874604Z 
2020-02-16T20:17:13.3874790Z ------------------------------------------
2020-02-16T20:17:13.3874864Z stderr:
2020-02-16T20:17:13.3875046Z ------------------------------------------
2020-02-16T20:17:13.3875528Z thread 'main' panicked at 'used 976 bytes of stack, but `struct Big` is only 384 bytes', /checkout/src/test/ui/issues/issue-40883.rs:83:9
2020-02-16T20:17:13.3875703Z 
2020-02-16T20:17:13.3876293Z ------------------------------------------
2020-02-16T20:17:13.3876356Z 
2020-02-16T20:17:13.3876390Z 
---
2020-02-16T20:17:13.3886898Z thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:348:22
2020-02-16T20:17:13.3887028Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
2020-02-16T20:17:13.3898344Z 
2020-02-16T20:17:13.3900216Z 
2020-02-16T20:17:13.3902125Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/checkout/obj/build/x86_64-unknown-linux-gnu/llvm/build/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--llvm-version" "9.0.1-rust-1.43.0-nightly\n" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2020-02-16T20:17:13.3902738Z 
2020-02-16T20:17:13.3902937Z 
2020-02-16T20:17:13.3904106Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2020-02-16T20:17:13.3904184Z Build completed unsuccessfully in 1:29:20
2020-02-16T20:17:13.3904184Z Build completed unsuccessfully in 1:29:20
2020-02-16T20:17:13.3955421Z == clock drift check ==
2020-02-16T20:17:13.3972908Z   local time: Sun Feb 16 20:17:13 UTC 2020
2020-02-16T20:17:13.6683594Z   network time: Sun, 16 Feb 2020 20:17:13 GMT
2020-02-16T20:17:13.6691391Z == end clock drift check ==
2020-02-16T20:17:14.1083401Z 
2020-02-16T20:17:14.1172472Z ##[error]Bash exited with code '1'.
2020-02-16T20:17:14.1210904Z ##[section]Starting: Checkout rust-lang/rust@auto to s
2020-02-16T20:17:14.1212585Z ==============================================================================
2020-02-16T20:17:14.1212657Z Task         : Get sources
2020-02-16T20:17:14.1212736Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@bors
Copy link
Contributor

bors commented Feb 16, 2020

💔 Test failed - checks-azure

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 16, 2020
@JohnTitor JohnTitor closed this Feb 16, 2020
@JohnTitor JohnTitor deleted the rollup-zcbtv4c branch February 16, 2020 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rollup A PR which is a rollup S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.