Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rollup of 7 pull requests #69215

Closed
wants to merge 17 commits into from
Closed

Rollup of 7 pull requests #69215

wants to merge 17 commits into from

Conversation

JohnTitor
Copy link
Member

Successful merges:

Failed merges:

r? @ghost

@thesoftwarephilosopher
Updating str.chars docs to mention crates.io.
ac19dff 
This might spare someone else a little time searching the stdlib for unicode/grapheme support.
@JohnTitor
Rename FunctionRetTy to FnRetTy
5c962c7
@petrochenkov
parser: macro_rules is a weak keyword
dcad07a
@amosonn
Improve #Safety in various methods in core::ptr
302b9e4 
s/for reads and writes/for both ...
@amosonn
Improve #Safety of core::ptr::replace
351782d 
Added missing condition:
`dst` must be readable
@amosonn
Improve #Safety in various methods in core::ptr
40ca167 
For all methods which read a value of type T, `read`, `read_unaligned`,
`read_volatile` and `replace`, added missing
constraint:
The value they point to must be properly initialized
@GuillaumeGomez
Clean up E0309 explanation
cadf9ef
@kubo39
macOS: avoid calling pthread_self() twice
67068f3
@amosonn
Improve #Safety of core::ptr::drop_in_place
943e653 
Added missing conditions:
- Valid for writes
- Valid for destructing
@RalfJung
debug_assert a few more raw pointer methods
bec5d37
@JohnTitor
Rollup merge of rust-lang#68495 - sdegutis:patch-1, r=Mark-Simulacrum
fbff711 
Updating str.chars docs to mention crates.io.

This might spare someone else a little time searching the stdlib for unicode/grapheme support.
@JohnTitor
Rollup merge of rust-lang#68701 - amosonn:patch-2, r=RalfJung
4e5b578 
Improve #Safety of various methods in core::ptr

For `read`, `read_unaligned`,`read_volatile`, `replace`, and `drop_in_place`:

- The value they point to must be properly initialized

For `replace`, additionally:

- The pointer must be readable
@JohnTitor
Rollup merge of rust-lang#68767 - kubo39:patch-macos, r=shepmaster
2f4d648 
macOS: avoid calling pthread_self() twice
@JohnTitor
Rollup merge of rust-lang#69179 - JohnTitor:rename-to-fnretty, r=Centril
fbd42a7 
Rename `FunctionRetTy` to `FnRetTy`

As per FIXME comment

r? @Centril
@JohnTitor
Rollup merge of rust-lang#69186 - petrochenkov:kwrules, r=Centril
f8d7282 
[tiny] parser: `macro_rules` is a weak keyword

r? @Centril
@JohnTitor
Rollup merge of rust-lang#69188 - GuillaumeGomez:clean-up-e0309, r=Dy…
2ecba06 
…lan-DPC

Clean up E0309 explanation

r? @Dylan-DPC
@JohnTitor
Rollup merge of rust-lang#69208 - RalfJung:debug-assert, r=Mark-Simul…
1dafcce 
…acrum

debug_assert a few more raw pointer methods

Fixes rust-lang#53871
@JohnTitor
Copy link
Member Author

@bors r+ p=7 rollup=never

@bors
Copy link
Contributor

bors commented Feb 16, 2020

📌 Commit 1dafcce has been approved by JohnTitor

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Feb 16, 2020
@bors
Copy link
Contributor

bors commented Feb 16, 2020

⌛ Testing commit 1dafcce with merge 0370cef186fc1a2dd44305b16234ec551d4ad408...

@JohnTitor JohnTitor added the rollup A PR which is a rollup label Feb 16, 2020
@rust-highfive
Copy link
Collaborator

The job x86_64-gnu of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
2020-02-16T22:24:06.2451111Z 
2020-02-16T22:24:06.2451588Z ------------------------------------------
2020-02-16T22:24:06.2451818Z stderr:
2020-02-16T22:24:06.2452156Z ------------------------------------------
2020-02-16T22:24:06.2452713Z thread 'main' panicked at 'used 976 bytes of stack, but `struct Big` is only 384 bytes', /checkout/src/test/ui/issues/issue-40883.rs:83:9
2020-02-16T22:24:06.2453368Z 
2020-02-16T22:24:06.2453718Z ------------------------------------------
2020-02-16T22:24:06.2453937Z 
2020-02-16T22:24:06.2454011Z 
---
2020-02-16T22:24:06.2467133Z thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:348:22
2020-02-16T22:24:06.2467594Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
2020-02-16T22:24:06.2481147Z 
2020-02-16T22:24:06.2481407Z 
2020-02-16T22:24:06.2485478Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/checkout/obj/build/x86_64-unknown-linux-gnu/llvm/build/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--llvm-version" "9.0.1-rust-1.43.0-nightly\n" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2020-02-16T22:24:06.2486609Z 
2020-02-16T22:24:06.2486778Z 
2020-02-16T22:24:06.2499656Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2020-02-16T22:24:06.2500170Z Build completed unsuccessfully in 1:47:08
2020-02-16T22:24:06.2500170Z Build completed unsuccessfully in 1:47:08
2020-02-16T22:24:06.2555345Z == clock drift check ==
2020-02-16T22:24:06.2575769Z   local time: Sun Feb 16 22:24:06 UTC 2020
2020-02-16T22:24:06.4924850Z   network time: Sun, 16 Feb 2020 22:24:06 GMT
2020-02-16T22:24:06.4924988Z == end clock drift check ==
2020-02-16T22:24:07.0506196Z 
2020-02-16T22:24:07.0611018Z ##[error]Bash exited with code '1'.
2020-02-16T22:24:07.0673530Z ##[section]Starting: Checkout rust-lang/rust@auto to s
2020-02-16T22:24:07.0675676Z ==============================================================================
2020-02-16T22:24:07.0675946Z Task         : Get sources
2020-02-16T22:24:07.0676047Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@bors
Copy link
Contributor

bors commented Feb 16, 2020

💔 Test failed - checks-azure

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 16, 2020
@JohnTitor JohnTitor closed this Feb 16, 2020
@JohnTitor JohnTitor deleted the rollup-h5pv0vc branch February 16, 2020 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
rollup A PR which is a rollup S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@JohnTitor @bors @rust-highfive @thesoftwarephilosopher @petrochenkov @amosonn @GuillaumeGomez @kubo39 @RalfJung