Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Querify object_safety_violations. #69242

Merged
merged 2 commits into from
Feb 22, 2020
Merged

Querify object_safety_violations. #69242

merged 2 commits into from
Feb 22, 2020

Conversation

cjgillot
Copy link
Contributor

Split from #69076

r? @Zoxc

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 17, 2020
@Zoxc
Copy link
Contributor

Zoxc commented Feb 17, 2020

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion

@bors
Copy link
Contributor

bors commented Feb 17, 2020

⌛ Trying commit 6e15faf with merge 5ed36c19ab9a38b71b3346273fcacb2737750539...

@bors
Copy link
Contributor

bors commented Feb 17, 2020

💔 Test failed - checks-azure

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 17, 2020
@cjgillot
Copy link
Contributor Author

Failure seems spurious.

@Zoxc
Copy link
Contributor

Zoxc commented Feb 18, 2020

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion

@bors
Copy link
Contributor

bors commented Feb 18, 2020

⌛ Trying commit 6e15faf with merge 4e3c536f7b0abc3f8ab5d0b62c6b8e53d6632bec...

@bors
Copy link
Contributor

bors commented Feb 18, 2020

☀️ Try build successful - checks-azure
Build commit: 4e3c536f7b0abc3f8ab5d0b62c6b8e53d6632bec (4e3c536f7b0abc3f8ab5d0b62c6b8e53d6632bec)

@rust-timer
Copy link
Collaborator

Queued 4e3c536f7b0abc3f8ab5d0b62c6b8e53d6632bec with parent 6317721, future comparison URL.

@jonas-schievink
Copy link
Contributor

The is_object_safe query can probably be removed then, and replaced with a method on TyCtxt

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit 4e3c536f7b0abc3f8ab5d0b62c6b8e53d6632bec, comparison URL.

@cjgillot
Copy link
Contributor Author

cjgillot commented Feb 19, 2020 •
edited
Loading

Perf seems good. Do we try with is_object_safe removed?

@Zoxc
Copy link
Contributor

Zoxc commented Feb 19, 2020

Yes we can probably make is_object_safe a method calling object_safety_violations now.

@cjgillot
Copy link
Contributor Author

Added a commit doing that.

@Zoxc
Copy link
Contributor

Zoxc commented Feb 21, 2020

@bors r+

@bors
Copy link
Contributor

bors commented Feb 21, 2020

📌 Commit 310f470 has been approved by Zoxc

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 21, 2020
@bors
Copy link
Contributor

bors commented Feb 21, 2020

⌛ Testing commit 310f470 with merge 1d7e818...

@bors
Copy link
Contributor

bors commented Feb 22, 2020

☀️ Test successful - checks-azure
Approved by: Zoxc
Pushing 1d7e818 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 22, 2020
@bors bors merged commit 1d7e818 into rust-lang:master Feb 22, 2020
@bors bors mentioned this pull request Feb 22, 2020
Merged
@cjgillot cjgillot deleted the object_violations branch February 22, 2020 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Zoxc Zoxc

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cjgillot @Zoxc @rust-timer @bors @jonas-schievink @rust-highfive