Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#[track_caller] in traits #69251

Merged
merged 2 commits into from
Mar 23, 2020
Merged

#[track_caller] in traits #69251

merged 2 commits into from
Mar 23, 2020

Commits on Mar 23, 2020

  1. Allow #[track_caller] in traits. 

    The codegen implementation already works for this, so we're:

* propagating track_caller attr from trait def to impl
* relaxing errors
* adding tests

Approved in a recent lang team meeting:
https://github.com/rust-lang/lang-team/blob/master/minutes/2020-01-09.md
    @anp
    anp committed Mar 23, 2020
    Configuration menu
    Copy the full SHA
    97da6da View commit details
    Browse the repository at this point in the history

  2. Remove special-casing from TyCtxt::impl_of_method. 

    We can do this now that opt_associated_item doesn't have any panicking paths.
    @anp
    anp committed Mar 23, 2020
    Configuration menu
    Copy the full SHA
    69bd46a View commit details
    Browse the repository at this point in the history