Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

print vis & defaultness for nested items #69334

Merged
merged 1 commit into from
Feb 23, 2020

Conversation

Centril
Copy link
Contributor

@Centril Centril commented Feb 21, 2020

Fixes #69315 which was injected by #69194.

r? @petrochenkov
cc @alexcrichton

@rust-highfive

This comment has been minimized.

@rust-highfive

This comment has been minimized.

@petrochenkov
Copy link
Contributor

r=me with the unused import removed.

@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 21, 2020
@Centril
Copy link
Contributor Author

Centril commented Feb 21, 2020

@bors r=petrochenkov

@bors
Copy link
Contributor

bors commented Feb 21, 2020

📌 Commit 14442e0 has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 21, 2020
@rust-highfive
Copy link
Collaborator

Your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2020-02-21T17:31:43.4641094Z ========================== Starting Command Output ===========================
2020-02-21T17:31:43.4645260Z [command]/bin/bash --noprofile --norc /home/vsts/work/_temp/5ce49279-6ad8-4ed9-b312-81e6985caf36.sh
2020-02-21T17:31:43.4645705Z 
2020-02-21T17:31:43.4649725Z ##[section]Finishing: Disable git automatic line ending conversion
2020-02-21T17:31:43.4670589Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/69334/merge to s
2020-02-21T17:31:43.4673981Z Task         : Get sources
2020-02-21T17:31:43.4674535Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-02-21T17:31:43.4674876Z Version      : 1.0.0
2020-02-21T17:31:43.4675089Z Author       : Microsoft
---
2020-02-21T17:31:44.4619701Z ##[command]git remote add origin https://github.com/rust-lang/rust
2020-02-21T17:31:44.4625275Z ##[command]git config gc.auto 0
2020-02-21T17:31:44.4628994Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2020-02-21T17:31:44.4632466Z ##[command]git config --get-all http.proxy
2020-02-21T17:31:44.4639717Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/69334/merge:refs/remotes/pull/69334/merge
---
2020-02-21T17:33:22.3338664Z tar: Exiting with failure status due to previous errors
2020-02-21T17:33:22.3368144Z 
2020-02-21T17:33:22.3464731Z ##[error]Bash exited with code '2'.
2020-02-21T17:33:22.3480325Z ##[section]Finishing: Install awscli
2020-02-21T17:33:22.3554919Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/69334/merge to s
2020-02-21T17:33:22.3562101Z Task         : Get sources
2020-02-21T17:33:22.3562952Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-02-21T17:33:22.3563311Z Version      : 1.0.0
2020-02-21T17:33:22.3563550Z Author       : Microsoft
2020-02-21T17:33:22.3563550Z Author       : Microsoft
2020-02-21T17:33:22.3563938Z Help         : [More Information](https://go.microsoft.com/fwlink/?LinkId=798199)
2020-02-21T17:33:22.3564366Z ==============================================================================
2020-02-21T17:33:22.6836966Z Cleaning any cached credential from repository: rust-lang/rust (GitHub)
2020-02-21T17:33:22.6893325Z ##[section]Finishing: Checkout rust-lang/rust@refs/pull/69334/merge to s
2020-02-21T17:33:22.6983208Z Cleaning up task key
2020-02-21T17:33:22.6984505Z Start cleaning up orphan processes.
2020-02-21T17:33:22.7253289Z Terminate orphan process: pid (3831) (python)
2020-02-21T17:33:22.7290084Z ##[section]Finishing: Finalize Job

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@Centril
Copy link
Contributor Author

Centril commented Feb 21, 2020

Failure is a spurious network issue.

@bors
Copy link
Contributor

bors commented Feb 22, 2020

⌛ Testing commit 14442e0 with merge a82d3cf...

bors added a commit that referenced this pull request Feb 22, 2020
print vis & defaultness for nested items

Fixes #69315 which was injected by #69194.

r? @petrochenkov
cc @alexcrichton
@bors
Copy link
Contributor

bors commented Feb 23, 2020

💔 Test failed - checks-azure

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 23, 2020
@Centril
Copy link
Contributor Author

Centril commented Feb 23, 2020

Failure looks spurious, @bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 23, 2020
@bors
Copy link
Contributor

bors commented Feb 23, 2020

⌛ Testing commit 14442e0 with merge 1484196...

@bors
Copy link
Contributor

bors commented Feb 23, 2020

☀️ Test successful - checks-azure
Approved by: petrochenkov
Pushing 1484196 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 23, 2020
@bors bors merged commit 1484196 into rust-lang:master Feb 23, 2020
@Centril Centril deleted the nested-item-vis-def branch February 23, 2020 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Visibility tokens on types in extern { ... } blocks are no longer given to procedural macros
4 participants