Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Clippy from 8fbb23f to fc5d0cc #69421

Merged
merged 1 commit into from
Feb 25, 2020
Merged

Update Clippy from 8fbb23f to fc5d0cc #69421

merged 1 commit into from
Feb 25, 2020

Conversation

flip1995
Copy link
Member

Fixes #69419

Fix false positive in `missing_const_for_fn`
Rustup to rust-lang/rust#69366
Add new lint [`wildcard imports`]. Add suggestion to [`enum_glob_use`]
Add new lint `lossy_float_literal` to detect lossy whole number float literals

@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 24, 2020
@Dylan-DPC-zz
Copy link

@bors r+ rollup=never p=1

@bors
Copy link
Contributor

bors commented Feb 24, 2020

📌 Commit a2a8980 has been approved by Dylan-DPC

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 24, 2020
@bors
Copy link
Contributor

bors commented Feb 24, 2020

⌛ Testing commit a2a8980 with merge 2f1aec9...

bors added a commit that referenced this pull request Feb 24, 2020
@bors
Auto merge of #69421 - flip1995:clippyup, r=Dylan-DPC
2f1aec9 
Update Clippy from 8fbb23f to fc5d0cc

Fixes #69419

```
Fix false positive in `missing_const_for_fn`
Rustup to #69366
Add new lint [`wildcard imports`]. Add suggestion to [`enum_glob_use`]
Add new lint `lossy_float_literal` to detect lossy whole number float literals
```
@bors
Copy link
Contributor

bors commented Feb 24, 2020

💔 Test failed - checks-azure

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 24, 2020
@matthiaskrgr
Copy link
Member

All builders passed except for one, looks spurious.
Could someone retry?

@Dylan-DPC-zz
Copy link

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 25, 2020
@bors
Copy link
Contributor

bors commented Feb 25, 2020

⌛ Testing commit a2a8980 with merge 6fd8798...

@bors
Copy link
Contributor

bors commented Feb 25, 2020

☀️ Test successful - checks-azure
Approved by: Dylan-DPC
Pushing 6fd8798 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 25, 2020
@bors bors merged commit 6fd8798 into rust-lang:master Feb 25, 2020
@rust-highfive
Copy link
Collaborator

📣 Toolstate changed by #69421!

Tested on commit 6fd8798.
Direct link to PR: #69421

🎉 clippy-driver on windows: build-fail → test-pass (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq).
🎉 clippy-driver on linux: build-fail → test-pass (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Feb 25, 2020
@rust-highfive
📣 Toolstate changed by rust-lang/rust#69421!
c7dc1db 
Tested on commit rust-lang/rust@6fd8798.
Direct link to PR: <rust-lang/rust#69421>

🎉 clippy-driver on windows: build-fail → test-pass (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq).
🎉 clippy-driver on linux: build-fail → test-pass (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq).
@flip1995 flip1995 deleted the clippyup branch February 25, 2020 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nikomatsakis nikomatsakis

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

clippy-driver no longer builds after rust-lang/rust#69366
6 participants
@flip1995 @rust-highfive @Dylan-DPC-zz @bors @matthiaskrgr @nikomatsakis