Stabilize `boxed_slice_try_from` #69538

JohnTitor · 2020-02-28T04:36:25Z

rust-highfive · 2020-02-28T04:58:00Z

Your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2020-02-28T04:36:59.1231483Z ========================== Starting Command Output ===========================
2020-02-28T04:36:59.1234394Z [command]/bin/bash --noprofile --norc /home/vsts/work/_temp/dfd0400f-8155-4197-9010-b02c204fb2ad.sh
2020-02-28T04:36:59.1234663Z 
2020-02-28T04:36:59.1239897Z ##[section]Finishing: Disable git automatic line ending conversion
2020-02-28T04:36:59.1259330Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/69538/merge to s
2020-02-28T04:36:59.1262907Z Task         : Get sources
2020-02-28T04:36:59.1263206Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-02-28T04:36:59.1263490Z Version      : 1.0.0
2020-02-28T04:36:59.1263684Z Author       : Microsoft
---
2020-02-28T04:37:00.3020847Z ##[command]git remote add origin https://github.com/rust-lang/rust
2020-02-28T04:37:00.3037024Z ##[command]git config gc.auto 0
2020-02-28T04:37:00.3041805Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2020-02-28T04:37:00.3045160Z ##[command]git config --get-all http.proxy
2020-02-28T04:37:00.3052413Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/69538/merge:refs/remotes/pull/69538/merge
---
2020-02-28T04:40:26.2415990Z E: Unable to fetch some archives, maybe run apt-get update or try with --fix-missing?
2020-02-28T04:40:26.2457491Z 
2020-02-28T04:40:26.2531910Z ##[error]Bash exited with code '100'.
2020-02-28T04:40:26.2545776Z ##[section]Finishing: Install awscli
2020-02-28T04:40:26.2609573Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/69538/merge to s
2020-02-28T04:40:26.2614626Z Task         : Get sources
2020-02-28T04:40:26.2614978Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-02-28T04:40:26.2615320Z Version      : 1.0.0
2020-02-28T04:40:26.2615544Z Author       : Microsoft
2020-02-28T04:40:26.2615544Z Author       : Microsoft
2020-02-28T04:40:26.2615903Z Help         : [More Information](https://go.microsoft.com/fwlink/?LinkId=798199)
2020-02-28T04:40:26.2616335Z ==============================================================================
2020-02-28T04:40:26.6000575Z Cleaning any cached credential from repository: rust-lang/rust (GitHub)
2020-02-28T04:40:26.6044664Z ##[section]Finishing: Checkout rust-lang/rust@refs/pull/69538/merge to s
2020-02-28T04:40:26.6139380Z Cleaning up task key
2020-02-28T04:40:26.6141186Z Start cleaning up orphan processes.
2020-02-28T04:40:26.6342542Z Terminate orphan process: pid (4339) (python)
2020-02-28T04:40:26.6594820Z ##[section]Finishing: Finalize Job

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

Centril · 2020-02-28T05:06:54Z

r? @Centril @bors r+

bors · 2020-02-28T05:06:55Z

📌 Commit 4e0bea3 has been approved by Centril

…entril Stabilize `boxed_slice_try_from` Closes rust-lang#69202

tesuji · 2020-02-28T13:47:27Z

Is there any FCP completed?

Mark-Simulacrum · 2020-02-28T13:53:49Z

These are already stable so FCP is a moot point I believe.

@ghost

Rollup of 10 pull requests Successful merges: - #68989 (Update RELEASES.md for 1.42.0) - #69340 (instantiate_value_path: on `SelfCtor`, avoid unconstrained tyvars) - #69384 (parser: `token` -> `normalized_token`, `nonnormalized_token` -> `token`) - #69452 (typeck: use `Pattern` obligation cause more for better diagnostics) - #69481 (use char instead of &str for single char patterns) - #69522 (error_derive_forbidden_on_non_adt: be more graceful) - #69538 (Stabilize `boxed_slice_try_from`) - #69539 (late resolve, visit_fn: bail early if there's no body.) - #69541 (Remove unneeded calls to format!()) - #69547 (remove redundant clones, references to operands, explicit boolean comparisons and filter(x).next() calls.) Failed merges: r? @ghost

Pkgsrc changes: * Bump rust bootstrap version to 1.42.0, except for Darwin/i686 where the bootstrap is not (yet?) available. Upstream changes: Version 1.43.0 (2020-04-23) ========================== Language -------- - [Fixed using binary operations with `&{number}` (e.g. `&1.0`) not having the type inferred correctly.][68129] - [Attributes such as `#[cfg()]` can now be used on `if` expressions.][69201] **Syntax only changes** - [Allow `type Foo: Ord` syntactically.][69361] - [Fuse associated and extern items up to defaultness.][69194] - [Syntactically allow `self` in all `fn` contexts.][68764] - [Merge `fn` syntax + cleanup item parsing.][68728] - [`item` macro fragments can be interpolated into `trait`s, `impl`s, and `extern` blocks.][69366] For example, you may now write: ```rust macro_rules! mac_trait { ($i:item) => { trait T { $i } } } mac_trait! { fn foo() {} } ``` These are still rejected *semantically*, so you will likely receive an error but these changes can be seen and parsed by macros and conditional compilation. Compiler -------- - [You can now pass multiple lint flags to rustc to override the previous flags.][67885] For example; `rustc -D unused -A unused-variables` denies everything in the `unused` lint group except `unused-variables` which is explicitly allowed. However, passing `rustc -A unused-variables -D unused` denies everything in the `unused` lint group **including** `unused-variables` since the allow flag is specified before the deny flag (and therefore overridden). - [rustc will now prefer your system MinGW libraries over its bundled libraries if they are available on `windows-gnu`.][67429] - [rustc now buffers errors/warnings printed in JSON.][69227] Libraries --------- - [`Arc<[T; N]>`, `Box<[T; N]>`, and `Rc<[T; N]>`, now implement `TryFrom<Arc<[T]>>`,`TryFrom<Box<[T]>>`, and `TryFrom<Rc<[T]>>` respectively.][69538] **Note** These conversions are only available when `N` is `0..=32`. - [You can now use associated constants on floats and integers directly, rather than having to import the module.][68952] e.g. You can now write `u32::MAX` or `f32::NAN` with no imports. - [`u8::is_ascii` is now `const`.][68984] - [`String` now implements `AsMut<str>`.][68742] - [Added the `primitive` module to `std` and `core`.][67637] This module reexports Rust's primitive types. This is mainly useful in macros where you want avoid these types being shadowed. - [Relaxed some of the trait bounds on `HashMap` and `HashSet`.][67642] - [`string::FromUtf8Error` now implements `Clone + Eq`.][68738] Stabilized APIs --------------- - [`Once::is_completed`] - [`f32::LOG10_2`] - [`f32::LOG2_10`] - [`f64::LOG10_2`] - [`f64::LOG2_10`] - [`iter::once_with`] Cargo ----- - [You can now set config `[profile]`s in your `.cargo/config`, or through your environment.][cargo/7823] - [Cargo will now set `CARGO_BIN_EXE_<name>` pointing to a binary's executable path when running integration tests or benchmarks.][cargo/7697] `<name>` is the name of your binary as-is e.g. If you wanted the executable path for a binary named `my-program`you would use `env!("CARGO_BIN_EXE_my-program")`. Misc ---- - [Certain checks in the `const_err` lint were deemed unrelated to const evaluation][69185], and have been moved to the `unconditional_panic` and `arithmetic_overflow` lints. Compatibility Notes ------------------- - [Having trailing syntax in the `assert!` macro is now a hard error.][69548] This has been a warning since 1.36.0. - [Fixed `Self` not having the correctly inferred type.][69340] This incorrectly led to some instances being accepted, and now correctly emits a hard error. [69340]: rust-lang/rust#69340 Internal Only ------------- These changes provide no direct user facing benefits, but represent significant improvements to the internals and overall performance of `rustc` and related tools. - [All components are now built with `opt-level=3` instead of `2`.][67878] - [Improved how rustc generates drop code.][67332] - [Improved performance from `#[inline]`-ing certain hot functions.][69256] - [traits: preallocate 2 Vecs of known initial size][69022] - [Avoid exponential behaviour when relating types][68772] - [Skip `Drop` terminators for enum variants without drop glue][68943] - [Improve performance of coherence checks][68966] - [Deduplicate types in the generator witness][68672] - [Invert control in struct_lint_level.][68725] [67332]: rust-lang/rust#67332 [67429]: rust-lang/rust#67429 [67637]: rust-lang/rust#67637 [67642]: rust-lang/rust#67642 [67878]: rust-lang/rust#67878 [67885]: rust-lang/rust#67885 [68129]: rust-lang/rust#68129 [68672]: rust-lang/rust#68672 [68725]: rust-lang/rust#68725 [68728]: rust-lang/rust#68728 [68738]: rust-lang/rust#68738 [68742]: rust-lang/rust#68742 [68764]: rust-lang/rust#68764 [68772]: rust-lang/rust#68772 [68943]: rust-lang/rust#68943 [68952]: rust-lang/rust#68952 [68966]: rust-lang/rust#68966 [68984]: rust-lang/rust#68984 [69022]: rust-lang/rust#69022 [69185]: rust-lang/rust#69185 [69194]: rust-lang/rust#69194 [69201]: rust-lang/rust#69201 [69227]: rust-lang/rust#69227 [69548]: rust-lang/rust#69548 [69256]: rust-lang/rust#69256 [69361]: rust-lang/rust#69361 [69366]: rust-lang/rust#69366 [69538]: rust-lang/rust#69538 [cargo/7823]: rust-lang/cargo#7823 [cargo/7697]: rust-lang/cargo#7697 [`Once::is_completed`]: https://doc.rust-lang.org/std/sync/struct.Once.html#method.is_completed [`f32::LOG10_2`]: https://doc.rust-lang.org/std/f32/consts/constant.LOG10_2.html [`f32::LOG2_10`]: https://doc.rust-lang.org/std/f32/consts/constant.LOG2_10.html [`f64::LOG10_2`]: https://doc.rust-lang.org/std/f64/consts/constant.LOG10_2.html [`f64::LOG2_10`]: https://doc.rust-lang.org/std/f64/consts/constant.LOG2_10.html [`iter::once_with`]: https://doc.rust-lang.org/std/iter/fn.once_with.html

Stabilize boxed_slice_try_from

4e0bea3

rust-highfive assigned dtolnay Feb 28, 2020

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 28, 2020

Centril added the relnotes Marks issues that should be documented in the release notes of the next release. label Feb 28, 2020

Centril added this to the 1.43 milestone Feb 28, 2020

Centril added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Feb 28, 2020

rust-highfive assigned Centril and unassigned dtolnay Feb 28, 2020

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 28, 2020

Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Feb 28, 2020

Rollup merge of rust-lang#69538 - JohnTitor:boxed-slice-try-from, r=C…

bad53f3

…entril Stabilize `boxed_slice_try_from` Closes rust-lang#69202

Dylan-DPC-zz mentioned this pull request Feb 28, 2020

Rollup of 7 pull requests #69543

Closed

Centril mentioned this pull request Feb 28, 2020

Rollup of 10 pull requests #69555

Merged

bors merged commit e4cedc9 into rust-lang:master Feb 28, 2020

JohnTitor deleted the boxed-slice-try-from branch February 29, 2020 03:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Stabilize `boxed_slice_try_from` #69538

Stabilize `boxed_slice_try_from` #69538

JohnTitor commented Feb 28, 2020 •

edited

Loading

rust-highfive commented Feb 28, 2020

Centril commented Feb 28, 2020

bors commented Feb 28, 2020

tesuji commented Feb 28, 2020

Mark-Simulacrum commented Feb 28, 2020

Stabilize boxed_slice_try_from #69538

Stabilize boxed_slice_try_from #69538

Conversation

JohnTitor commented Feb 28, 2020 • edited Loading

rust-highfive commented Feb 28, 2020

Centril commented Feb 28, 2020

bors commented Feb 28, 2020

tesuji commented Feb 28, 2020

Mark-Simulacrum commented Feb 28, 2020

Stabilize `boxed_slice_try_from` #69538

Stabilize `boxed_slice_try_from` #69538

JohnTitor commented Feb 28, 2020 •

edited

Loading