-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add long error explanation for E0634 #69998
Add long error explanation for E0634 #69998
Conversation
Some changes occurred in diagnostic error codes |
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @GuillaumeGomez (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me (minus the corrections @Dylan-DPC asked for)!
Co-Authored-By: Dylan DPC <dylan.dpc@gmail.com>
Co-Authored-By: Dylan DPC <dylan.dpc@gmail.com>
Thanks! @bors: r=Dylan-DPC,GuillaumeGomez rollup |
📌 Commit 2974685 has been approved by |
…error-code-e0634, r=Dylan-DPC,GuillaumeGomez Add long error explanation for E0634 Add long explanation for the E0634 error code Part of rust-lang#61137 r? @GuillaumeGomez
Rollup of 8 pull requests Successful merges: - #69686 (Use `pprust` to print attributes in rustdoc) - #69858 (std: on Windows, use GetSystemTimePreciseAsFileTime if it is available) - #69917 (Cleanup E0412 and E0422) - #69964 (Add Node.js to PR CI image) - #69992 (Block version-specific docs from search engines) - #69995 (Add more context to the literal overflow message) - #69998 (Add long error explanation for E0634) - #70014 (Small fixes in rustdoc book) Failed merges: r? @ghost
Add long explanation for the E0634 error code
Part of #61137
r? @GuillaumeGomez