Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store idents for DefPathData into crate metadata #70077

Merged
merged 2 commits into from
Mar 24, 2020
Merged

Store idents for DefPathData into crate metadata #70077

merged 2 commits into from
Mar 24, 2020

Commits on Mar 23, 2020

  1. Store idents for DefPathData into crate metadata 

    Previously, we threw away the `Span` associated with a definition's
identifier when we encoded crate metadata, causing us to lose location
and hygiene information.

We now store the identifier's `Span` in the crate metadata.
When we decode items from the metadata, we combine
the name and span back into an `Ident`.

This improves the output of several tests, which previously had messages
suppressed due to dummy spans.

This is a prerequisite for rust-lang#68686, since throwing away a `Span` means
that we lose hygiene information.
    @Aaron1011
    Aaron1011 committed Mar 23, 2020
    Configuration menu
    Copy the full SHA
    96e2d03 View commit details
    Browse the repository at this point in the history

  2. Ignore tests on some platforms due to rust-lang#53081

    @Aaron1011
    Aaron1011 committed Mar 23, 2020
    Configuration menu
    Copy the full SHA
    86b8dea View commit details
    Browse the repository at this point in the history