Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add copy bound to atomic & numeric intrinsics #70101

Merged
merged 2 commits into from
Mar 29, 2020
Merged

Add copy bound to atomic & numeric intrinsics #70101

merged 2 commits into from
Mar 29, 2020

Conversation

tmiasko
Copy link
Contributor

@tmiasko tmiasko commented Mar 18, 2020 •
edited
Loading

No description provided.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @withoutboats (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 18, 2020
@tmiasko
Copy link
Contributor Author

tmiasko commented Mar 18, 2020

r? @eddyb

@rust-highfive rust-highfive assigned eddyb and unassigned withoutboats Mar 18, 2020
@eddyb eddyb added S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 18, 2020
@eddyb
Copy link
Member

eddyb commented Mar 18, 2020 •
edited by Dylan-DPC-zz
Loading

Blocked on #70088.

But until then, let's see if all of these bounds slow down compilation:
@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion

@bors
Copy link
Contributor

bors commented Mar 18, 2020

⌛ Trying commit 90403dd with merge a32f3ae...

bors added a commit that referenced this pull request Mar 18, 2020
@bors
Auto merge of #70101 - tmiasko:intrinsics-copy, r=<try>
a32f3ae 
Add copy bound to atomic & numeric intrinsics

Includes changes from #70088.
@bors
Copy link
Contributor

bors commented Mar 18, 2020

💥 Test timed out

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. labels Mar 18, 2020
@Dylan-DPC-zz
Copy link

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion

@bors
Copy link
Contributor

bors commented Mar 29, 2020

⌛ Trying commit ec853b6 with merge 119f1f99f280ef63616a5850089cb3d96f05938a...

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion

@bors
Copy link
Contributor

bors commented Mar 29, 2020

⌛ Trying commit ec853b6 with merge c50daeeeb7cd5e2b6d5077742e980e9cf777832f...

@bors
Copy link
Contributor

bors commented Mar 29, 2020

☀️ Try build successful - checks-azure
Build commit: c50daeeeb7cd5e2b6d5077742e980e9cf777832f (c50daeeeb7cd5e2b6d5077742e980e9cf777832f)

@rust-timer
Copy link
Collaborator

Queued c50daeeeb7cd5e2b6d5077742e980e9cf777832f with parent 7762131, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit c50daeeeb7cd5e2b6d5077742e980e9cf777832f, comparison URL.

@eddyb
Copy link
Member

eddyb commented Mar 29, 2020

Wait, this is silly, only core's compilation would be slowed down, nothing uses the intrinsics directly.
And the results are likely all noise.

Sorry for the unnecessary delay, I didn't think the implications through properly.
@bors r+

@bors
Copy link
Contributor

bors commented Mar 29, 2020

📌 Commit ec853b6 has been approved by eddyb

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 29, 2020
@bjorn3
Copy link
Member

bjorn3 commented Mar 29, 2020

All regressions are for incremental mode.

@Centril Centril mentioned this pull request Mar 29, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 29, 2020
@bors
Auto merge of rust-lang#70525 - Centril:rollup-vj3esv3, r=Centril
8ab82b8 
Rollup of 3 pull requests

Successful merges:

 - rust-lang#68692 (impl From<[T; N]> for Vec<T>)
 - rust-lang#70101 (Add copy bound to atomic & numeric intrinsics)
 - rust-lang#70506 (BTreeMap testing: introduce symbolic constants and use height consistently)

Failed merges:

r? @ghost
@bors bors merged commit 873bf46 into rust-lang:master Mar 29, 2020
@tmiasko tmiasko deleted the intrinsics-copy branch July 1, 2020 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@eddyb eddyb

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@tmiasko @rust-highfive @eddyb @rust-timer @bors @Dylan-DPC-zz @bjorn3 @withoutboats