-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop compilation on missing const_generics
feature.
#70122
Conversation
After lazy normalisation (#67890) is merged, we should be able to remove this, but this is probably better than ICEing for now. |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
I disagree with this change. |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Maybe we should just leave #69913 open until lazy normalisation is merged, in light of @petrochenkov's objection. An ICE isn't pleasant for a user, but they still get a detailed error message beforehand, so it shouldn't be obstructive to them. |
Thanks for filing the pull request, though! |
fixes #69913
Currently aborts right after parsing. Considering that most problems only start during type checking,
this is not optimal.
I do not know of a simple way to delay this abort.
r? @varkor
cc @eddyb